Attachment 48157 Details for Bug 154289 – Make setViewerColumn private to Class

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Make setViewerColumn private to Class

patch.txt (text/plain), 1.65 KB, created by Thomas Schindl

on 2006-08-18 01:20:59 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Schindl

Created: 2006-08-18 01:20:59 EDT

Size: 1.65 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface
>Index: src/org/eclipse/jface/viewers/ColumnViewer.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/ColumnViewer.java,v
>retrieving revision 1.4
>diff -u -r1.4 ColumnViewer.java
>--- src/org/eclipse/jface/viewers/ColumnViewer.java	17 Aug 2006 19:34:41 -0000	1.4
>+++ src/org/eclipse/jface/viewers/ColumnViewer.java	18 Aug 2006 05:21:43 -0000
>@@ -126,7 +126,7 @@
> 	 * @param columnIndex
> 	 * @return TableColumnViewer
> 	 */
>-	public ViewerColumn getViewerColumn(final int columnIndex) {
>+	public ViewerColumn getViewerColumn(int columnIndex) {
> 
> 		ViewerColumn viewer;
> 		Widget columnOwner = getColumnViewerOwner(columnIndex);
>@@ -142,9 +142,9 @@
> 			viewer = createColumnViewer(columnOwner, ViewerLabelProvider
> 					.createViewerLabelProvider(getLabelProvider()));
> 			setViewerColumn(columnIndex, viewer);
>-		} else
>-			// Reset the colum-index because maybe it changed from the last time
>-			viewer.getLabelProvider().setColumnIndex(columnIndex);
>+		}
>+		
>+		viewer.getLabelProvider().setColumnIndex(columnIndex);
> 
> 		return viewer;
> 	}
>@@ -154,7 +154,7 @@
> 	 * @param columnIndex
> 	 * @param viewer
> 	 */
>-	public void setViewerColumn(final int columnIndex, ViewerColumn viewer) {
>+	private void setViewerColumn(final int columnIndex, ViewerColumn viewer) {
> 		if (getCellModifier() != null) {
> 			viewer.setEditingSupport(new EditingSupport() {
> 
>@@ -199,10 +199,6 @@
> 				}
> 			});
> 		}
>-
>-		// Reset the colum-index because maybe it changed from the last time
>-		viewer.getLabelProvider().setColumnIndex(columnIndex);
>-
> 	}
> 
> 	/**

Actions: View | Diff

Attachments on bug 154289: 48157 | 48158 | 48252 | 48253