Attachment 47944 Details for Bug 149193 – Fix Tooltip-Methods and Comments

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix Tooltip-Methods and Comments

patch.txt (text/plain), 9.24 KB, created by Thomas Schindl

on 2006-08-15 14:05:12 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Schindl

Created: 2006-08-15 14:05:12 EDT

Size: 9.24 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface
>Index: src/org/eclipse/jface/viewers/TableViewer.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TableViewer.java,v
>retrieving revision 1.57
>diff -u -r1.57 TableViewer.java
>--- src/org/eclipse/jface/viewers/TableViewer.java	15 Aug 2006 13:03:03 -0000	1.57
>+++ src/org/eclipse/jface/viewers/TableViewer.java	15 Aug 2006 17:56:45 -0000
>@@ -7,7 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>- *     Tom Schindl <tom.schindl@bestsolution.at> (bug 83200)
>+ *     Tom Schindl <tom.schindl@bestsolution.at> - concept of RowPart
>  *******************************************************************************/
> 
> package org.eclipse.jface.viewers;
>@@ -1247,9 +1247,9 @@
> 		TableItem item;
> 		
> 		if( rowIndex >= 0 ) {
>-			item = new TableItem(table,SWT.NONE,rowIndex);
>+			item = new TableItem(table,style,rowIndex);
> 		} else {
>-			item = new TableItem(table,SWT.NONE);
>+			item = new TableItem(table,style);
> 		}
> 		
> 		return getRowPartFromItem(item);
>Index: src/org/eclipse/jface/viewers/TreeViewer.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeViewer.java,v
>retrieving revision 1.51
>diff -u -r1.51 TreeViewer.java
>--- src/org/eclipse/jface/viewers/TreeViewer.java	15 Aug 2006 13:03:03 -0000	1.51
>+++ src/org/eclipse/jface/viewers/TreeViewer.java	15 Aug 2006 17:56:46 -0000
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Tom Schindl <tom.schindl@bestsolution.at> - concept of RowPart
>  *******************************************************************************/
> 
> package org.eclipse.jface.viewers;
>@@ -924,10 +925,10 @@
> 		}
> 		
> 		if( rowIndex >= 0 ) {
>-			return getRowPartFromItem(new TreeItem((TreeItem)parent.getItem(),SWT.NONE,rowIndex));
>+			return getRowPartFromItem(new TreeItem((TreeItem)parent.getItem(),style,rowIndex));
> 		}
> 		
>-		return getRowPartFromItem(new TreeItem((TreeItem)parent.getItem(),SWT.NONE));
>+		return getRowPartFromItem(new TreeItem((TreeItem)parent.getItem(),style));
> 	}
> 	
> 	protected ColumnViewerPart createColumnViewer(Widget columnOwner, ViewerLabelProvider labelProvider) {
>Index: src/org/eclipse/jface/viewers/ViewerLabelProvider.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/ViewerLabelProvider.java,v
>retrieving revision 1.1
>diff -u -r1.1 ViewerLabelProvider.java
>--- src/org/eclipse/jface/viewers/ViewerLabelProvider.java	15 Aug 2006 13:03:03 -0000	1.1
>+++ src/org/eclipse/jface/viewers/ViewerLabelProvider.java	15 Aug 2006 17:56:46 -0000
>@@ -294,20 +294,6 @@
> 	}
> 
> 	/**
>-	 * This is the amount the used to control how much the tooltip is shifted
>-	 * from the current mouse position
>-	 * 
>-	 * @param object
>-	 *            the element for which the tooltip is shown
>-	 * @param columnIndex
>-	 *            the column-index
>-	 * @return shift of the tooltip
>-	 */
>-	public Point getTooltipShift(Object object, int columnIndex) {
>-		return null;
>-	}
>-
>-	/**
> 	 * If you want your tooltip to be using the native Tooltip you can force
> 	 * this by returning true from this method. If native tooltips are used only
> 	 * the text-value is used all other feature are of custom tooltips are not
>@@ -324,45 +310,6 @@
> 	}
> 
> 	/**
>-	 * The time in milliseconds after the tooltip is hidden
>-	 * 
>-	 * @param object
>-	 *            the element for which the tooltip is shown
>-	 * @param columnIndex
>-	 *            the column-index
>-	 * @return milliseconds
>-	 */
>-	public int getTooltipTimeDisplayed(Object object, int columnIndex) {
>-		return 0;
>-	}
>-
>-	/**
>-	 * The time in milliseconds until the tooltip pops up
>-	 * 
>-	 * @param object
>-	 *            the element for which the tooltip is shown
>-	 * @param columnIndex
>-	 *            the column-index
>-	 * @return milliseconds
>-	 */
>-	public int getTooltipDisplayDelayTime(Object object, int columnIndex) {
>-		return 0;
>-	}
>-
>-	/**
>-	 * The style used to create the label
>-	 * 
>-	 * @param object
>-	 *            the element for which the tooltip is shown
>-	 * @param columnIndex
>-	 *            the column-index
>-	 * @return style mask
>-	 */
>-	public int getTooltipImageStyle(Object object, int columnIndex) {
>-		return SWT.SHADOW_NONE;
>-	}
>-
>-	/**
> 	 * This is the amount the used to control how much the tooltip is shifted
> 	 * from the current mouse position
> 	 * 
>@@ -417,7 +364,7 @@
> 	 *            the element for which the tooltip is shown
> 	 * @return style mask
> 	 */
>-	public int getTooltipImageStyle(Object object) {
>+	public int getTooltipStyle(Object object) {
> 		return SWT.SHADOW_NONE;
> 	}
> 
>Index: src/org/eclipse/jface/viewers/TreeColumnViewerPart.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeColumnViewerPart.java,v
>retrieving revision 1.1
>diff -u -r1.1 TreeColumnViewerPart.java
>--- src/org/eclipse/jface/viewers/TreeColumnViewerPart.java	15 Aug 2006 13:03:03 -0000	1.1
>+++ src/org/eclipse/jface/viewers/TreeColumnViewerPart.java	15 Aug 2006 17:56:45 -0000
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Tom Shindl <tom.schindl@bestsolution.at> - initial API and implementation
>  ******************************************************************************/
> 
> package org.eclipse.jface.viewers;
>Index: src/org/eclipse/jface/viewers/TreeEditorImpl.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeEditorImpl.java,v
>retrieving revision 1.8
>diff -u -r1.8 TreeEditorImpl.java
>--- src/org/eclipse/jface/viewers/TreeEditorImpl.java	15 Aug 2006 13:03:03 -0000	1.8
>+++ src/org/eclipse/jface/viewers/TreeEditorImpl.java	15 Aug 2006 17:56:45 -0000
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Tom Shindl <tom.schindl@bestsolution.at> - Refactored to use ColumnViewerPart
>  *******************************************************************************/
> 
> package org.eclipse.jface.viewers;
>Index: src/org/eclipse/jface/viewers/TooltipSupport.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TooltipSupport.java,v
>retrieving revision 1.1
>diff -u -r1.1 TooltipSupport.java
>--- src/org/eclipse/jface/viewers/TooltipSupport.java	15 Aug 2006 13:03:03 -0000	1.1
>+++ src/org/eclipse/jface/viewers/TooltipSupport.java	15 Aug 2006 17:56:45 -0000
>@@ -127,7 +127,7 @@
> 				
> 				tip = new Shell(viewer.getControl().getShell(), SWT.ON_TOP | SWT.TOOL);
> 				tip.setLayout(new FillLayout());
>-				CLabel label = new CLabel(tip, labelProvider.getTooltipImageStyle(element));
>+				CLabel label = new CLabel(tip, labelProvider.getTooltipStyle(element));
> 				label.setText(text);
> 				label.addListener(SWT.MouseExit, hideListener);
> 				label.addListener(SWT.MouseDown, hideListener);
>Index: src/org/eclipse/jface/viewers/TableColumnViewerLabelProvider.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TableColumnViewerLabelProvider.java,v
>retrieving revision 1.1
>diff -u -r1.1 TableColumnViewerLabelProvider.java
>--- src/org/eclipse/jface/viewers/TableColumnViewerLabelProvider.java	15 Aug 2006 13:03:03 -0000	1.1
>+++ src/org/eclipse/jface/viewers/TableColumnViewerLabelProvider.java	15 Aug 2006 17:56:44 -0000
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Tom Shindl <tom.schindl@bestsolution.at> - initial API and implementation
>  ******************************************************************************/
> 
> package org.eclipse.jface.viewers;
>@@ -23,9 +24,6 @@
>  * part of a work in progress. This API may change at any given time. Please 
>  * do not use this API without consulting with the Platform/UI team.
>  * @since 3.3
>- * Contributors:
>- *     IBM Corporation - initial API and implementation
>- *     Tom Shindl <tom.schindl@bestsolution.at> - initial API and implementation
>  * @see ITableLabelProvider
>  * @see ITableColorProvider
>  * @see ITableFontProvider
>Index: src/org/eclipse/jface/viewers/TableEditorImpl.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TableEditorImpl.java,v
>retrieving revision 1.8
>diff -u -r1.8 TableEditorImpl.java
>--- src/org/eclipse/jface/viewers/TableEditorImpl.java	15 Aug 2006 13:03:03 -0000	1.8
>+++ src/org/eclipse/jface/viewers/TableEditorImpl.java	15 Aug 2006 17:56:44 -0000
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Tom Shindl <tom.schindl@bestsolution.at> - Refactored to use ColumnViewerPart
>  *******************************************************************************/
> 
> package org.eclipse.jface.viewers;

Actions: View | Diff

Attachments on bug 149193: 46241 | 46254 | 46263 | 46677 | 46686 | 47008 | 47350 | 47453 | 47454 | 47472 | 47722 | 47944 | 48028 | 48089