Attachment 46989 Details for Bug 150890 – Strips slashes from repository url

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Strips slashes from repository url

mylar-trac-url-slash-patch.txt (text/plain), 2.53 KB, created by Steffen Pingel

on 2006-07-28 18:27:29 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Steffen Pingel

Created: 2006-07-28 18:27:29 EDT

Size: 2.53 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylar.jira
>Index: src/org/eclipse/mylar/internal/jira/ui/wizards/JiraRepositorySettingsPage.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.jira/src/org/eclipse/mylar/internal/jira/ui/wizards/JiraRepositorySettingsPage.java,v
>retrieving revision 1.10
>diff -u -r1.10 JiraRepositorySettingsPage.java
>--- src/org/eclipse/mylar/internal/jira/ui/wizards/JiraRepositorySettingsPage.java	14 Jul 2006 15:40:30 -0000	1.10
>+++ src/org/eclipse/mylar/internal/jira/ui/wizards/JiraRepositorySettingsPage.java	28 Jul 2006 22:23:17 -0000
>@@ -67,7 +67,7 @@
> //		} else {
> //			MessageDialog.openInformation(null, MylarJiraPlugin.TITLE_MESSAGE_DIALOG, MESSAGE_FAILURE_CONNECT);
> //		}
>-		final String serverUrl = super.serverUrlEditor.getStringValue();
>+		final String serverUrl = getServerUrl();
> 		final String userName = getUserName();
> 		final String password = getPassword();
> 		try {
>#P org.eclipse.mylar.tasks.ui
>Index: src/org/eclipse/mylar/internal/tasks/ui/wizards/AbstractRepositorySettingsPage.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.tasks.ui/src/org/eclipse/mylar/internal/tasks/ui/wizards/AbstractRepositorySettingsPage.java,v
>retrieving revision 1.8
>diff -u -r1.8 AbstractRepositorySettingsPage.java
>--- src/org/eclipse/mylar/internal/tasks/ui/wizards/AbstractRepositorySettingsPage.java	24 Jul 2006 23:44:38 -0000	1.8
>+++ src/org/eclipse/mylar/internal/tasks/ui/wizards/AbstractRepositorySettingsPage.java	28 Jul 2006 22:23:19 -0000
>@@ -320,12 +320,21 @@
> 
> 	protected abstract boolean isValidUrl(String name);
> 
>+	/* Public for testing. */
>+	public static String stripSlashes(String url) {
>+		StringBuilder sb = new StringBuilder(url.trim());
>+		while (sb.length() > 0 && sb.charAt(sb.length() - 1) == '/') {
>+			sb.deleteCharAt(sb.length() - 1);
>+		}
>+		return sb.toString();
>+	}
>+
> 	public String getRepositoryLabel() {
> 		return repositoryLabelCombo.getText();
> 	}
> 
> 	public String getServerUrl() {
>-		return serverUrlEditor.getStringValue();
>+		return stripSlashes(serverUrlEditor.getStringValue());
> 	}
> 
> 	public String getUserName() {
>@@ -372,7 +381,8 @@
> 
> 	@Override
> 	public boolean isPageComplete() {
>-		return isUniqueUrl(serverUrlEditor.getStringValue()) && isValidUrl(serverUrlEditor.getStringValue());
>+		String url = getServerUrl();
>+		return isUniqueUrl(url) && isValidUrl(url);
> 	}
> 
> 	protected boolean isUniqueUrl(String urlString) {

Actions: View | Diff

Attachments on bug 150890: 46989 | 46991