Attachment 46922 Details for Bug 151896 – add UseTLS option to UrlConnectionUtil

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] add UseTLS option to UrlConnectionUtil

151896-useTLS.txt (text/plain), 5.59 KB, created by Nathan Hapke

on 2006-07-27 19:58:10 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nathan Hapke

Created: 2006-07-27 19:58:10 EDT

Size: 5.59 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylar.bugzilla.core
>Index: src/org/eclipse/mylar/internal/bugzilla/core/BugzillaReportSubmitForm.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.bugzilla.core/src/org/eclipse/mylar/internal/bugzilla/core/BugzillaReportSubmitForm.java,v
>retrieving revision 1.43
>diff -u -r1.43 BugzillaReportSubmitForm.java
>--- src/org/eclipse/mylar/internal/bugzilla/core/BugzillaReportSubmitForm.java	21 Jul 2006 05:49:08 -0000	1.43
>+++ src/org/eclipse/mylar/internal/bugzilla/core/BugzillaReportSubmitForm.java	27 Jul 2006 23:58:26 -0000
>@@ -344,7 +344,7 @@
> 		String result = null;
> 		try {
> 			// connect to the bugzilla server
>-			URLConnection cntx = UrlConnectionUtil.getUrlConnection(postUrl, proxySettings);
>+			URLConnection cntx = UrlConnectionUtil.getUrlConnection(postUrl, proxySettings, false);
> 			if (cntx == null || !(cntx instanceof HttpURLConnection))
> 				return null;
> 
>Index: src/org/eclipse/mylar/internal/bugzilla/core/BugzillaAttachmentHandler.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.bugzilla.core/src/org/eclipse/mylar/internal/bugzilla/core/BugzillaAttachmentHandler.java,v
>retrieving revision 1.10
>diff -u -r1.10 BugzillaAttachmentHandler.java
>--- src/org/eclipse/mylar/internal/bugzilla/core/BugzillaAttachmentHandler.java	27 Jul 2006 18:51:28 -0000	1.10
>+++ src/org/eclipse/mylar/internal/bugzilla/core/BugzillaAttachmentHandler.java	27 Jul 2006 23:58:25 -0000
>@@ -195,7 +195,7 @@
> 			String url = repositoryUrl + POST_ARGS_ATTACHMENT_DOWNLOAD + id;
> 			url = BugzillaServerFacade.addCredentials(url, userName, password);
> 			URL downloadUrl = new URL(url);
>-			URLConnection connection = UrlConnectionUtil.getUrlConnection(downloadUrl, proxySettings);
>+			URLConnection connection = UrlConnectionUtil.getUrlConnection(downloadUrl, proxySettings, false);
> 			if (connection != null) {
> 				InputStream input = connection.getInputStream();
> 				outStream = new FileOutputStream(destinationFile);
>Index: src/org/eclipse/mylar/internal/bugzilla/core/AbstractReportFactory.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.bugzilla.core/src/org/eclipse/mylar/internal/bugzilla/core/AbstractReportFactory.java,v
>retrieving revision 1.15
>diff -u -r1.15 AbstractReportFactory.java
>--- src/org/eclipse/mylar/internal/bugzilla/core/AbstractReportFactory.java	21 Jul 2006 05:49:08 -0000	1.15
>+++ src/org/eclipse/mylar/internal/bugzilla/core/AbstractReportFactory.java	27 Jul 2006 23:58:25 -0000
>@@ -56,7 +56,7 @@
> 	protected void collectResults(URL url, Proxy proxySettings, String characterEncoding,
> 			DefaultHandler contentHandler, boolean clean) throws IOException, LoginException, KeyManagementException,
> 			NoSuchAlgorithmException, BugzillaException {
>-		URLConnection cntx = UrlConnectionUtil.getUrlConnection(url, proxySettings);
>+		URLConnection cntx = UrlConnectionUtil.getUrlConnection(url, proxySettings, false);
> 		if (cntx == null || !(cntx instanceof HttpURLConnection)) {
> 			throw new IOException("Could not form URLConnection.");
> 		}
>#P org.eclipse.mylar.bugzilla.ui
>Index: src/org/eclipse/mylar/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.bugzilla.ui/src/org/eclipse/mylar/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java,v
>retrieving revision 1.22
>diff -u -r1.22 BugzillaRepositorySettingsPage.java
>--- src/org/eclipse/mylar/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java	21 Jul 2006 05:49:00 -0000	1.22
>+++ src/org/eclipse/mylar/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java	27 Jul 2006 23:58:26 -0000
>@@ -146,7 +146,7 @@
> 					monitor.beginTask("Validating server settings", IProgressMonitor.UNKNOWN);
> 					try {
> 						Proxy proxySettings = TasksUiPlugin.getDefault().getProxySettings();
>-						URLConnection cntx = UrlConnectionUtil.getUrlConnection(serverURL, proxySettings);
>+						URLConnection cntx = UrlConnectionUtil.getUrlConnection(serverURL, proxySettings, false);
> 						if (cntx == null || !(cntx instanceof HttpURLConnection)) {
> 							throw new MalformedURLException();
> 						}
>#P org.eclipse.mylar.tasks.core
>Index: src/org/eclipse/mylar/internal/tasks/core/UrlConnectionUtil.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.tasks.core/src/org/eclipse/mylar/internal/tasks/core/UrlConnectionUtil.java,v
>retrieving revision 1.3
>diff -u -r1.3 UrlConnectionUtil.java
>--- src/org/eclipse/mylar/internal/tasks/core/UrlConnectionUtil.java	27 Jul 2006 23:15:09 -0000	1.3
>+++ src/org/eclipse/mylar/internal/tasks/core/UrlConnectionUtil.java	27 Jul 2006 23:58:26 -0000
>@@ -47,9 +47,13 @@
> 	 * @param proxy
> 	 *            can be null
> 	 */
>-	public static URLConnection getUrlConnection(URL url, Proxy proxy) throws IOException, NoSuchAlgorithmException,
>-			KeyManagementException {
>-		SSLContext ctx = SSLContext.getInstance("TLS");
>+	public static URLConnection getUrlConnection(URL url, Proxy proxy, boolean useTls) throws IOException,
>+			NoSuchAlgorithmException, KeyManagementException {
>+		SSLContext ctx;
>+		if (useTls)
>+			ctx = SSLContext.getInstance("TLS");
>+		else
>+			ctx = SSLContext.getInstance("SSL");
> 
> 		javax.net.ssl.TrustManager[] tm = new javax.net.ssl.TrustManager[] { new RepositoryTrustManager() };
> 		ctx.init(null, tm, null);

Actions: View | Diff

Attachments on bug 151896: 46883 | 46898 | 46922