Attachment 46457 Details for Bug 138260 – org.eclipse.pde.ui.patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] org.eclipse.pde.ui.patch

org.eclipse.pde.ui.patch (text/plain), 1.89 KB, created by Chris Aniszczyk

on 2006-07-18 12:57:37 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Aniszczyk

Created: 2006-07-18 12:57:37 EDT

Size: 1.89 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.core
>Index: src/org/eclipse/pde/internal/core/builders/BuildErrorReporter.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/BuildErrorReporter.java,v
>retrieving revision 1.18
>diff -u -r1.18 BuildErrorReporter.java
>--- src/org/eclipse/pde/internal/core/builders/BuildErrorReporter.java	12 Jun 2006 18:55:25 -0000	1.18
>+++ src/org/eclipse/pde/internal/core/builders/BuildErrorReporter.java	18 Jul 2006 17:00:17 -0000
>@@ -41,6 +41,7 @@
> import org.eclipse.pde.internal.core.PDECore;
> import org.eclipse.pde.internal.core.PDECoreMessages;
> import org.eclipse.pde.internal.core.PluginModelManager;
>+import org.eclipse.pde.internal.core.WorkspaceModelManager;
> import org.eclipse.pde.internal.core.build.WorkspaceBuildModel;
> import org.eclipse.pde.internal.core.ibundle.IBundleFragmentModel;
> import org.eclipse.pde.internal.core.ibundle.IBundleModel;
>@@ -166,7 +167,25 @@
> 		
> 		validateSourceEntries(sourceEntries);
> 		validateMissingSourceInBinIncludes(binIncludes, sourceEntryKeys, build);
>-		
>+		validateBinIncludes(binIncludes);
>+	}
>+	
>+	private void validateBinIncludes(IBuildEntry binIncludes) {
>+		if(WorkspaceModelManager.hasBundleManifest(fProject)) {
>+			String[] tokens = binIncludes.getTokens();
>+			boolean exists = false;
>+			String key = "META-INF/"; //$NON-NLS-1$
>+			for(int i = 0; i < tokens.length; i++) {
>+				if(tokens[i].startsWith(key))
>+					exists = true;
>+			}
>+			if(!exists) {
>+				prepareError(PROPERTY_BIN_INCLUDES, 
>+						key,
>+						NLS.bind(PDECoreMessages.BuildErrorReporter_binIncludesMissing, key),
>+						PDEMarkerFactory.B_ADDDITION);
>+			}
>+		}
> 	}
> 	
> 	private void validateJarsExtraClasspath(IBuildEntry javaExtra) {
>@@ -550,4 +569,5 @@
> 		} catch (CoreException e) {
> 		}
> 	}
>+	
>  }

Actions: View | Diff

Attachments on bug 138260: 46452 | 46457