Attachment 43850 Details for Bug 145332 – Proposed change

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed change

145332.txt (text/plain), 2.63 KB, created by Jerome Lanneluc

on 2006-06-08 06:41:59 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jerome Lanneluc

Created: 2006-06-08 06:41:59 EDT

Size: 2.63 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: model/org/eclipse/jdt/internal/core/hierarchy/HierarchyResolver.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/hierarchy/HierarchyResolver.java,v
>retrieving revision 1.66
>diff -u -r1.66 HierarchyResolver.java
>--- model/org/eclipse/jdt/internal/core/hierarchy/HierarchyResolver.java	3 May 2006 16:55:02 -0000	1.66
>+++ model/org/eclipse/jdt/internal/core/hierarchy/HierarchyResolver.java	8 Jun 2006 10:44:02 -0000
>@@ -58,6 +58,7 @@
> import org.eclipse.jdt.internal.core.*;
> import org.eclipse.jdt.internal.core.util.ASTNodeFinder;
> import org.eclipse.jdt.internal.core.util.HandleFactory;
>+import org.eclipse.jdt.internal.core.util.Util;
> 
> public class HierarchyResolver implements ITypeRequestor {
> 	
>@@ -616,7 +617,7 @@
> 							focusUnit = parsedUnit;
> 						}
> 					} catch (AbortCompilation e) {
>-						// classpath problem for this type: ignore
>+						Util.log(e, "Could not build type bindings for " + openable.getPath()); //$NON-NLS-1$
> 					}
> 				}
> 			} else {
>@@ -648,7 +649,7 @@
> 							focusBinaryBinding = binaryTypeBinding;
> 						}
> 					} catch (AbortCompilation e) {
>-						// classpath problem for this type: ignore
>+						Util.log(e, "Could not cache binary type for " + openable.getPath()); //$NON-NLS-1$
> 					}
> 				}
> 			}
>@@ -663,7 +664,7 @@
> 					typeBinding.superclass();
> 					typeBinding.superInterfaces();
> 				} catch (AbortCompilation e) {
>-					// classpath problem for this type: ignore
>+					Util.log(e, "Could not get the superclass/superInterfaces for " + new String(suppliedType.getFileName())); //$NON-NLS-1$
> 				}
> 			}
> 		}		
>@@ -681,6 +682,7 @@
> 				} catch (AbortCompilation e) {
> 					// classpath problem for this type: don't try to resolve (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=49809)
> 					hasLocalType[i] = false;
>+					Util.log(e, "Could not complete type bindings for " + new String(parsedUnit.getFileName())); //$NON-NLS-1$
> 				}
> 			}
> 			worked(monitor, 1);
>@@ -712,9 +714,8 @@
> 		reportHierarchy(focus, focusUnit, focusBinaryBinding);
> 		
> 	} catch (ClassCastException e){ // work-around for 1GF5W1S - can happen in case duplicates are fed to the hierarchy with binaries hiding sources
>-	} catch (AbortCompilation e) { // ignore this exception for now since it typically means we cannot find java.lang.Object
>-		if (TypeHierarchy.DEBUG)
>-			e.printStackTrace();
>+	} catch (AbortCompilation e) {
>+		Util.log(e, "Could not resolve hierarchy"); //$NON-NLS-1$
> 	} finally {
> 		reset();
> 	}

Actions: View | Diff

Attachments on bug 145332: 43850