Attachment 39484 Details for Bug 136219 – Fix npe in AbstractBugzillaWizardPage

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix npe in AbstractBugzillaWizardPage

patch136219-3.txt (text/plain), 2.12 KB, created by Robert Elves

on 2006-04-25 17:54:38 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Robert Elves

Created: 2006-04-25 17:54:38 EDT

Size: 2.12 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylar.bugzilla.ui
>Index: src/org/eclipse/mylar/internal/bugzilla/ui/wizard/AbstractBugzillaWizardPage.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.mylar/org.eclipse.mylar.bugzilla.ui/src/org/eclipse/mylar/internal/bugzilla/ui/wizard/AbstractBugzillaWizardPage.java,v
>retrieving revision 1.6
>diff -u -r1.6 AbstractBugzillaWizardPage.java
>--- src/org/eclipse/mylar/internal/bugzilla/ui/wizard/AbstractBugzillaWizardPage.java	7 Apr 2006 17:40:18 -0000	1.6
>+++ src/org/eclipse/mylar/internal/bugzilla/ui/wizard/AbstractBugzillaWizardPage.java	25 Apr 2006 21:40:54 -0000
>@@ -725,7 +725,7 @@
> 
> 			if (java2buzillaOSMap != null && java2buzillaOSMap.containsKey(OS) && opSysAttribute != null && opSysAttribute.getOptionValues() != null) {
> 				bugzillaOS = java2buzillaOSMap.get(OS);
>-				if (!opSysAttribute.getOptionValues().values().contains(bugzillaOS)) {
>+				if (opSysAttribute != null && !opSysAttribute.getOptionValues().values().contains(bugzillaOS)) {
> 					// If the OS we found is not in the list of available
> 					// options, set bugzillaOS
> 					// to null, and just use "other"
>@@ -739,7 +739,8 @@
> 
> 			if (platform != null && java2buzillaPlatformMap.containsKey(platform)) {
> 				bugzillaPlatform = java2buzillaPlatformMap.get(platform);
>-				if (!platformAttribute.getOptionValues().values().contains(bugzillaPlatform)) {
>+				
>+				if (platformAttribute != null && !platformAttribute.getOptionValues().values().contains(bugzillaPlatform)) {
> 					// If the platform we found is not int the list of available
> 					// optinos, set the
> 					// Bugzilla Platform to null, and juse use "other"
>@@ -752,9 +753,9 @@
> 			}
> 
> 			// Set the OS and the Platform in the model
>-			if (bugzillaOS != null)
>+			if (bugzillaOS != null && opSysAttribute != null)
> 				opSysAttribute.setValue(bugzillaOS);
>-			if (bugzillaPlatform != null)
>+			if (bugzillaPlatform != null && platformAttribute != null)
> 				platformAttribute.setValue(bugzillaPlatform);
> 		} catch (Exception e) {
> 			MylarStatusHandler.fail(e, "could not set platform options", false);

Actions: View | Diff

Attachments on bug 136219: 39378 | 39381 | 39429 | 39484 | 39498 | 39599 | 39615 | 39833 | 39835 | 40093 | 40670 | 40671