Attachment 39093 Details for Bug 136697 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix

136697.txt (text/plain), 3.16 KB, created by Sebastian Davids

on 2006-04-20 15:35:38 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sebastian Davids

Created: 2006-04-20 15:35:38 EDT

Size: 3.16 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface
>Index: src/org/eclipse/jface/preference/PreferenceDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceDialog.java,v
>retrieving revision 1.83
>diff -u -r1.83 PreferenceDialog.java
>--- src/org/eclipse/jface/preference/PreferenceDialog.java	24 Mar 2006 16:02:50 -0000	1.83
>+++ src/org/eclipse/jface/preference/PreferenceDialog.java	20 Apr 2006 19:21:32 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2005 IBM Corporation and others.
>+ * Copyright (c) 2000, 2006 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -357,7 +357,7 @@
> 	protected Control createDialogArea(Composite parent) {
> 		final Composite composite = (Composite) super.createDialogArea(parent);
> 		GridLayout parentLayout = ((GridLayout) composite.getLayout());
>-		parentLayout.numColumns = 4;
>+		parentLayout.numColumns = 5;
> 		parentLayout.marginHeight = 0;
> 		parentLayout.marginWidth = 0;
> 		parentLayout.verticalSpacing = 0;
>@@ -366,13 +366,10 @@
> 		composite.setBackground(parent.getDisplay().getSystemColor(SWT.COLOR_LIST_BACKGROUND));
> 		
> 		Control treeControl = createTreeAreaContents(composite);
>+
>+		createVerticalSeperator(composite);
> 		createSash(composite,treeControl);
>-		
>-		Label versep = new Label(composite, SWT.SEPARATOR | SWT.VERTICAL);
>-		GridData verGd = new GridData(GridData.FILL_VERTICAL | GridData.GRAB_VERTICAL);
>-	
>-		versep.setLayoutData(verGd);
>-		versep.setLayoutData(new GridData(SWT.LEFT, SWT.FILL, false, true));
>+		createVerticalSeperator(composite);
> 		
> 		Composite pageAreaComposite = new Composite(composite, SWT.NONE);
> 		pageAreaComposite.setLayoutData(new GridData(GridData.FILL_BOTH));
>@@ -427,6 +424,17 @@
> 	}
> 
> 	/**
>+	 * @param composite
>+	 */
>+	private void createVerticalSeperator(final Composite composite) {
>+		Label versep = new Label(composite, SWT.SEPARATOR | SWT.VERTICAL);
>+		GridData verGd = new GridData(GridData.FILL_VERTICAL | GridData.GRAB_VERTICAL);
>+	
>+		versep.setLayoutData(verGd);
>+		versep.setLayoutData(new GridData(SWT.LEFT, SWT.FILL, false, true));
>+	}
>+
>+	/**
> 	 * Create the sash with right control on the right. Note 
> 	 * that this method assumes GridData for the layout data
> 	 * of the rightControl.
>@@ -437,9 +445,8 @@
> 	 * @since 3.1
> 	 */
> 	protected Sash createSash(final Composite composite, final Control rightControl) {
>-		final Sash sash = new Sash(composite, SWT.VERTICAL);
>+		final Sash sash = new Sash(composite, SWT.SMOOTH | SWT.VERTICAL);
> 		sash.setLayoutData(new GridData(GridData.FILL_VERTICAL));
>-		sash.setBackground(composite.getDisplay().getSystemColor(SWT.COLOR_LIST_BACKGROUND));
> 		// the following listener resizes the tree control based on sash deltas.
> 		// If necessary, it will also grow/shrink the dialog.
> 		sash.addListener(SWT.Selection, new Listener() {

Actions: View | Diff

Attachments on bug 136697: 39093 | 39094