Attachment 38921 Details for Bug 137356 – Workaround for 137356

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Workaround for 137356

137356.txt (text/plain), 4.18 KB, created by Tod Creasey

on 2006-04-19 09:18:04 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tod Creasey

Created: 2006-04-19 09:18:04 EDT

Size: 4.18 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.ide
>Index: src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java,v
>retrieving revision 1.18
>diff -u -r1.18 MarkerSupportRegistry.java
>--- src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java	22 Mar 2006 17:43:01 -0000	1.18
>+++ src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java	19 Apr 2006 13:04:57 -0000
>@@ -7,6 +7,7 @@
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
>+import java.util.Set;
> 
> import org.eclipse.core.resources.IMarker;
> import org.eclipse.core.runtime.CoreException;
>@@ -143,28 +144,38 @@
> 		}
> 		IExtension[] extensions = point.getExtensions();
> 		// initial population
>+		Map groupingEntries = new HashMap();
>+		Set attributeMappings = new HashSet();
> 		for (int i = 0; i < extensions.length; i++) {
> 			IExtension extension = extensions[i];
>-			processExtension(tracker, extension);
>+			processExtension(tracker, extension, groupingEntries,
>+					attributeMappings);
> 		}
>+		postProcessExtensions(groupingEntries, attributeMappings);
> 		tracker.registerHandler(this, ExtensionTracker
> 				.createExtensionPointFilter(point));
> 
> 	}
> 
> 	/**
>-	 * Process the extension and register the result with the tracker.
>+	 * Process the extension and register the result with the tracker. Fill the
>+	 * map of groupingEntries and attribueMappings processed for post
>+	 * processing.
> 	 * 
> 	 * @param tracker
> 	 * @param extension
>+	 * @param groupingEntries
>+	 *            Mapping of group names to the markerGroupingEntries registered
>+	 *            for them
>+	 * @param attributeMappings
>+	 *            the markerAttributeGroupings found
>+	 * @see #postProcessExtensions(Map, Collection)
> 	 */
> 	private void processExtension(IExtensionTracker tracker,
>-			IExtension extension) {
>+			IExtension extension, Map groupingEntries,
>+			Collection attributeMappings) {
> 		IConfigurationElement[] elements = extension.getConfigurationElements();
> 
>-		Map groupingEntries = new HashMap();
>-		Collection attributeMappings = new HashSet();
>-
> 		for (int j = 0; j < elements.length; j++) {
> 			IConfigurationElement element = elements[j];
> 			if (element.getName().equals(PROBLEM_FILTER)) {
>@@ -233,14 +244,28 @@
> 						IExtensionTracker.REF_STRONG);
> 			}
> 
>-			processGroupingEntries(groupingEntries);
>-			processAttributeMappings(attributeMappings);
>-
> 		}
> 	}
> 
> 	/**
>-	 * Process the grouping entries into thier required plug-ins.
>+	 * Process the cross references after all of the extensions have been read.
>+	 * 
>+	 * @param groupingEntries
>+	 * @param attributeMappings
>+	 * @param groupingEntries
>+	 *            Mapping of group names to the markerGroupingEntries registered
>+	 *            for them
>+	 * @param attributeMappings
>+	 *            the markerAttributeGroupings found
>+	 */
>+	private void postProcessExtensions(Map groupingEntries,
>+			Collection attributeMappings) {
>+		processGroupingEntries(groupingEntries);
>+		processAttributeMappings(attributeMappings);
>+	}
>+
>+	/**
>+	 * Process the grouping entries into thier required grouping entries.
> 	 * 
> 	 * @param groupingEntries
> 	 */
>@@ -275,7 +300,7 @@
> 	}
> 
> 	/**
>-	 * Process the attribute mappings into thier required plug-ins.
>+	 * Process the attribute mappings into thier required grouping entries.
> 	 * 
> 	 * @param attributeMappings
> 	 */
>@@ -342,7 +367,10 @@
> 	 *      org.eclipse.core.runtime.IExtension)
> 	 */
> 	public void addExtension(IExtensionTracker tracker, IExtension extension) {
>-		processExtension(tracker, extension);
>+		Map groupingEntries = new HashMap();
>+		Set attributeMappings = new HashSet();
>+		processExtension(tracker, extension, groupingEntries, attributeMappings);
>+		postProcessExtensions(groupingEntries, attributeMappings);
> 	}
> 
> 	/**
>@@ -670,10 +698,11 @@
> 
> 	/**
> 	 * Return the default group.
>+	 * 
> 	 * @return IField
> 	 */
> 	public IField getDefaultGroup() {
>-		
>+
> 		return (IField) markerGroups.get(SEVERITY_ID);
> 	}
>

Actions: View | Diff

Attachments on bug 137356: 38921 | 39980