Attachment 38832 Details for Bug 128455 – Partial visibility patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Partial visibility patch

bug128455-ui.workbench-proxy01.txt (text/plain), 4.97 KB, created by Paul Webster

on 2006-04-18 14:55:40 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Webster

Created: 2006-04-18 14:55:40 EDT

Size: 4.97 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/presentations/util/AbstractTabFolder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/util/AbstractTabFolder.java,v
>retrieving revision 1.9
>diff -u -r1.9 AbstractTabFolder.java
>--- Eclipse UI/org/eclipse/ui/internal/presentations/util/AbstractTabFolder.java	25 May 2005 17:22:21 -0000	1.9
>+++ Eclipse UI/org/eclipse/ui/internal/presentations/util/AbstractTabFolder.java	18 Apr 2006 18:43:19 -0000
>@@ -377,4 +377,15 @@
>         return false;
>     }
>     
>+    /**
>+	 * Set the folder to visible. This can be extended to propogate the
>+	 * visibility request to other components in the subclass.
>+	 * 
>+	 * @param visible
>+	 *            <code>true</code> - the folder is visible.
>+	 * @since 3.2
>+	 */
>+    public void setVisible(boolean visible) {
>+		getControl().setVisible(visible);
>+	}
> }
>Index: Eclipse UI/org/eclipse/ui/internal/presentations/util/ProxyControl.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/util/ProxyControl.java,v
>retrieving revision 1.10
>diff -u -r1.10 ProxyControl.java
>--- Eclipse UI/org/eclipse/ui/internal/presentations/util/ProxyControl.java	11 Jul 2005 23:14:35 -0000	1.10
>+++ Eclipse UI/org/eclipse/ui/internal/presentations/util/ProxyControl.java	18 Apr 2006 18:43:19 -0000
>@@ -117,6 +117,21 @@
>         }
> 	    
> 	};
>+	
>+	/**
>+	 * Allow the visibility of the proxy control to be updated while the target
>+	 * is <code>null</code>. When the target is not <code>null</code> it's
>+	 * visibility is tied to the listener.
>+	 * 
>+	 * @param visible
>+	 *            <code>true</code> - set it to visible
>+	 * @since 3.2
>+	 */
>+	public void setVisible(boolean visible) {
>+		if (target == null) {
>+			this.visible = visible;
>+		}
>+	}
>     
> 	/**
> 	 * Movement listener. Updates the bounds of the target to match the 
>Index: Eclipse UI/org/eclipse/ui/internal/presentations/util/PresentablePartFolder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/util/PresentablePartFolder.java,v
>retrieving revision 1.15
>diff -u -r1.15 PresentablePartFolder.java
>--- Eclipse UI/org/eclipse/ui/internal/presentations/util/PresentablePartFolder.java	2 Mar 2006 14:44:49 -0000	1.15
>+++ Eclipse UI/org/eclipse/ui/internal/presentations/util/PresentablePartFolder.java	18 Apr 2006 18:43:19 -0000
>@@ -389,7 +389,8 @@
>     
>     public void setVisible(boolean isVisible) {
>         this.isVisible  = isVisible;
>-        getTabFolder().getControl().setVisible(isVisible);
>+        getTabFolder().setVisible(isVisible);
>+//        getTabFolder().getControl().setVisible(isVisible);
>         if (isVisible) {
>             layout(true);
>         }
>Index: Eclipse UI/org/eclipse/ui/internal/presentations/defaultpresentation/DefaultTabFolder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/defaultpresentation/DefaultTabFolder.java,v
>retrieving revision 1.19
>diff -u -r1.19 DefaultTabFolder.java
>--- Eclipse UI/org/eclipse/ui/internal/presentations/defaultpresentation/DefaultTabFolder.java	2 Mar 2006 14:44:49 -0000	1.19
>+++ Eclipse UI/org/eclipse/ui/internal/presentations/defaultpresentation/DefaultTabFolder.java	18 Apr 2006 18:43:19 -0000
>@@ -495,4 +495,12 @@
>         
>         layout(true);
>     }
>+
>+	/* (non-Javadoc)
>+	 * @see org.eclipse.ui.internal.presentations.util.AbstractTabFolder#setVisible(boolean)
>+	 */
>+	public void setVisible(boolean visible) {
>+		super.setVisible(visible);
>+		getFolder().setVisible(visible);
>+	}
> }
>Index: Eclipse UI/org/eclipse/ui/internal/presentations/PaneFolder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/PaneFolder.java,v
>retrieving revision 1.34
>diff -u -r1.34 PaneFolder.java
>--- Eclipse UI/org/eclipse/ui/internal/presentations/PaneFolder.java	24 Feb 2006 18:36:21 -0000	1.34
>+++ Eclipse UI/org/eclipse/ui/internal/presentations/PaneFolder.java	18 Apr 2006 18:43:19 -0000
>@@ -817,4 +817,20 @@
>         return viewForm;
>     }
> 
>+    /**
>+	 * Propogate the visibility change requests to the proxy controls. When
>+	 * their target is null, they no longer get visibility updates. Currently
>+	 * this only propagates the changes to the ProxyControls held by this
>+	 * folder.
>+	 * 
>+	 * @param visible
>+	 *            <code>true</code> - it's visible.
>+	 * @since 3.2
>+	 */
>+    public void setVisible(boolean visible) {
>+		contentProxy.setVisible(visible);
>+		viewFormTopCenterProxy.setVisible(visible);
>+		viewFormTopLeftProxy.setVisible(visible);
>+		viewFormTopRightProxy.setVisible(visible);
>+	}
> }

Actions: View | Diff

Attachments on bug 128455: 34939 | 34966 | 38832 | 51226 | 72352