Attachment 377 Details for Bug 9480 – patch uses the OK/FAILURE/ERROR icons to indicate the test suite's status; if there's a test case with ERROR then the test suite will get the ERROR icon; if there's a FAILURE but no ERROR then the FAILURE icon is used; otherwise the OK icon is used

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch uses the OK/FAILURE/ERROR icons to indicate the test suite's status; if there's a test case with ERROR then the test suite will get the ERROR icon; if there's a FAILURE but no ERROR then the FAILURE icon is used; otherwise the OK icon is used

bug9480 (text/plain), 2.01 KB, created by Sebastian Davids

on 2002-02-16 06:58:13 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Sebastian Davids

Created: 2002-02-16 06:58:13 EST

Size: 2.01 KB

patch

obsolete

>Index: Eclipse JUnit/org/eclipse/jdt/internal/junit/ui/HierarchyRunView.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.junit/Eclipse JUnit/org/eclipse/jdt/internal/junit/ui/HierarchyRunView.java,v
>retrieving revision 1.5
>diff -u -r1.5 HierarchyRunView.java
>--- Eclipse JUnit/org/eclipse/jdt/internal/junit/ui/HierarchyRunView.java	29 Jan 2002 11:33:39 -0000	1.5
>+++ Eclipse JUnit/org/eclipse/jdt/internal/junit/ui/HierarchyRunView.java	16 Feb 2002 11:47:34 -0000
>@@ -197,12 +197,32 @@
> 
> 	private void updateItem(TreeItem treeItem, TestRunInfo testInfo) {
> 		treeItem.setData(testInfo);
>-		if(testInfo.fStatus == ITestRunListener.STATUS_OK)
>-			treeItem.setImage(fOkIcon);	
>-		else if (testInfo.fStatus == ITestRunListener.STATUS_FAILURE)
>+		
>+		if(testInfo.fStatus == ITestRunListener.STATUS_OK) {
>+			treeItem.setImage(fOkIcon);
>+			return;
>+		}
>+
>+		TreeItem parentItem = treeItem.getParentItem();
>+		//assert(null != testSuite);
>+		Image currentImage = parentItem.getImage();
>+		//assert(null != image);
>+				
>+		if (testInfo.fStatus == ITestRunListener.STATUS_FAILURE) {
> 			treeItem.setImage(fFailureIcon);
>-		else if (testInfo.fStatus == ITestRunListener.STATUS_ERROR)
>+			
>+			if (currentImage.equals(fFailureIcon) || currentImage.equals(fErrorIcon))
>+				return;
>+			
>+			parentItem.setImage(fFailureIcon);
>+		} else if (testInfo.fStatus == ITestRunListener.STATUS_ERROR) {
> 			treeItem.setImage(fErrorIcon);
>+			
>+			if (currentImage.equals(fErrorIcon))
>+				return;
>+			
>+			parentItem.setImage(fErrorIcon);			
>+		}
> 	}
> 
> 	public void activate() {
>@@ -332,7 +352,7 @@
> 		} else if(isSuite.equals("true")) {
> 			testInfo.fStatus= IS_SUITE;
> 			treeItem= new TreeItem(((SuiteInfo) fSuiteInfos.lastElement()).fTreeItem, SWT.NONE);
>-			treeItem.setImage(fHierarchyIcon);
>+			treeItem.setImage(fOkIcon);
> 			((SuiteInfo)fSuiteInfos.lastElement()).fTestCount -= 1;
> 			fSuiteInfos.addElement(new SuiteInfo(treeItem, testCount));
> 		} else {

Actions: View | Diff

Attachments on bug 9480: 377