Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 35112 Details for
Bug 119111
Exception with web service wizards when no server runtime installed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
[patch]
apply to org.eclipse.jst.ws.creation.ui
patch119111_o.e.jst.ws.creation.ui.txt (text/plain), 22.15 KB, created by
Rupam Kuehner
on 2006-02-21 19:26:17 EST
(
hide
)
Description:
apply to org.eclipse.jst.ws.creation.ui
Filename:
MIME Type:
Creator:
Rupam Kuehner
Created:
2006-02-21 19:26:17 EST
Size:
22.15 KB
patch
obsolete
>### Eclipse Workspace Patch 1.0 >#P org.eclipse.jst.ws.creation.ui >Index: src/org/eclipse/jst/ws/internal/creation/ui/extension/PreServiceDeployCommand.java >=================================================================== >RCS file: /cvsroot/webtools/jst/components/ws/plugins/org.eclipse.jst.ws.creation.ui/src/org/eclipse/jst/ws/internal/creation/ui/extension/PreServiceDeployCommand.java,v >retrieving revision 1.6 >diff -u -r1.6 PreServiceDeployCommand.java >--- src/org/eclipse/jst/ws/internal/creation/ui/extension/PreServiceDeployCommand.java 29 Nov 2005 18:06:44 -0000 1.6 >+++ src/org/eclipse/jst/ws/internal/creation/ui/extension/PreServiceDeployCommand.java 22 Feb 2006 00:24:35 -0000 >@@ -1,12 +1,15 @@ > /******************************************************************************* >- * Copyright (c) 2005 IBM Corporation and others. >+ * Copyright (c) 2005, 2006 IBM Corporation and others. > * All rights reserved. This program and the accompanying materials > * are made available under the terms of the Eclipse Public License v1.0 > * which accompanies this distribution, and is available at > * http://www.eclipse.org/legal/epl-v10.html >- * >+ * > * Contributors: >- * IBM Corporation - initial API and implementation >+ * IBM Corporation - initial API and implementation >+ * yyyymmdd bug Email and other contact information >+ * -------- -------- ----------------------------------------------------------- >+ * 20060221 119111 rsinha@ca.ibm.com - Rupam Kuehner > *******************************************************************************/ > > package org.eclipse.jst.ws.internal.creation.ui.extension; >@@ -16,11 +19,24 @@ > import org.eclipse.core.runtime.IStatus; > import org.eclipse.core.runtime.Status; > import org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation; >+import org.eclipse.wst.ws.internal.wsrt.IContext; > > public class PreServiceDeployCommand extends AbstractDataModelOperation > { >+ private IContext context_; > public IStatus execute( IProgressMonitor monitor, IAdaptable adaptable ) > { >+ if (context_.getDeploy()) >+ { >+ //If and when there are framework specific deploy things to be done, >+ //do them here. >+ } >+ > return Status.OK_STATUS; > } >+ >+ public void setContext(IContext context) >+ { >+ context_=context; >+ } > } >Index: src/org/eclipse/jst/ws/internal/creation/ui/extension/ServiceRootFragment.java >=================================================================== >RCS file: /cvsroot/webtools/jst/components/ws/plugins/org.eclipse.jst.ws.creation.ui/src/org/eclipse/jst/ws/internal/creation/ui/extension/ServiceRootFragment.java,v >retrieving revision 1.8 >diff -u -r1.8 ServiceRootFragment.java >--- src/org/eclipse/jst/ws/internal/creation/ui/extension/ServiceRootFragment.java 2 Feb 2006 19:04:58 -0000 1.8 >+++ src/org/eclipse/jst/ws/internal/creation/ui/extension/ServiceRootFragment.java 22 Feb 2006 00:24:36 -0000 >@@ -1,15 +1,16 @@ > /******************************************************************************* >- * Copyright (c) 2005 IBM Corporation and others. >+ * Copyright (c) 2005, 2006 IBM Corporation and others. > * All rights reserved. This program and the accompanying materials > * are made available under the terms of the Eclipse Public License v1.0 > * which accompanies this distribution, and is available at > * http://www.eclipse.org/legal/epl-v10.html >- * >+ * > * Contributors: >- * IBM Corporation - initial API and implementation >+ * IBM Corporation - initial API and implementation > * yyyymmdd bug Email and other contact information > * -------- -------- ----------------------------------------------------------- > * 20060131 121071 rsinha@ca.ibm.com - Rupam Kuehner >+ * 20060221 119111 rsinha@ca.ibm.com - Rupam Kuehner > *******************************************************************************/ > > package org.eclipse.jst.ws.internal.creation.ui.extension; >@@ -101,6 +102,8 @@ > registry.addMapping( PreServiceDevelopCommand.class, "EarProject", PreServiceAssembleCommand.class ); > registry.addMapping( PreServiceDevelopCommand.class, "Ear", PreServiceAssembleCommand.class ); > >+ registry.addMapping( PreServiceDevelopCommand.class, "Context", PreServiceDeployCommand.class ); >+ > registry.addMapping( PreServiceDevelopCommand.class, "WebService", PreServiceInstallCommand.class ); > registry.addMapping( PreServiceDevelopCommand.class, "Project", PreServiceInstallCommand.class ); > registry.addMapping( PreServiceDevelopCommand.class, "Module", PreServiceInstallCommand.class ); >Index: src/org/eclipse/jst/ws/internal/creation/ui/extension/PreServiceDevelopCommand.java >=================================================================== >RCS file: /cvsroot/webtools/jst/components/ws/plugins/org.eclipse.jst.ws.creation.ui/src/org/eclipse/jst/ws/internal/creation/ui/extension/PreServiceDevelopCommand.java,v >retrieving revision 1.30 >diff -u -r1.30 PreServiceDevelopCommand.java >--- src/org/eclipse/jst/ws/internal/creation/ui/extension/PreServiceDevelopCommand.java 2 Feb 2006 19:04:58 -0000 1.30 >+++ src/org/eclipse/jst/ws/internal/creation/ui/extension/PreServiceDevelopCommand.java 22 Feb 2006 00:24:36 -0000 >@@ -1,15 +1,16 @@ > /******************************************************************************* >- * Copyright (c) 2005 IBM Corporation and others. >+ * Copyright (c) 2005, 2006 IBM Corporation and others. > * All rights reserved. This program and the accompanying materials > * are made available under the terms of the Eclipse Public License v1.0 > * which accompanies this distribution, and is available at > * http://www.eclipse.org/legal/epl-v10.html >- * >+ * > * Contributors: >- * IBM Corporation - initial API and implementation >+ * IBM Corporation - initial API and implementation > * yyyymmdd bug Email and other contact information > * -------- -------- ----------------------------------------------------------- > * 20060131 121071 rsinha@ca.ibm.com - Rupam Kuehner >+ * 20060221 119111 rsinha@ca.ibm.com - Rupam Kuehner > *******************************************************************************/ > > package org.eclipse.jst.ws.internal.creation.ui.extension; >@@ -53,6 +54,7 @@ > private String j2eeLevel_; > private ResourceContext resourceContext_; > >+ private boolean deploy_; > private boolean install_; > private boolean run_; > private boolean client_; >@@ -107,7 +109,7 @@ > wsInfo.setWsdlURL(wsdlURL); > } > >- context_ = new SimpleContext(true, true, true, install_, run_, client_, test_, publish_, >+ context_ = new SimpleContext(true, true, deploy_, install_, run_, client_, test_, publish_, > scenario, > resourceContext_.isOverwriteFilesEnabled(), > resourceContext_.isCreateFoldersEnabled(), >@@ -234,6 +236,11 @@ > { > install_ = installService; > } >+ >+ public void setDeployService(boolean deployService) >+ { >+ deploy_ = deployService; >+ } > > public void setStartService(boolean startService) > { >Index: src/org/eclipse/jst/ws/internal/creation/ui/widgets/runtime/ServerRuntimeSelectionWidget.java >=================================================================== >RCS file: /cvsroot/webtools/jst/components/ws/plugins/org.eclipse.jst.ws.creation.ui/src/org/eclipse/jst/ws/internal/creation/ui/widgets/runtime/ServerRuntimeSelectionWidget.java,v >retrieving revision 1.25 >diff -u -r1.25 ServerRuntimeSelectionWidget.java >--- src/org/eclipse/jst/ws/internal/creation/ui/widgets/runtime/ServerRuntimeSelectionWidget.java 22 Feb 2006 00:15:12 -0000 1.25 >+++ src/org/eclipse/jst/ws/internal/creation/ui/widgets/runtime/ServerRuntimeSelectionWidget.java 22 Feb 2006 00:24:37 -0000 >@@ -9,8 +9,9 @@ > * IBM Corporation - initial API and implementation > * yyyymmdd bug Email and other contact information > * -------- -------- ----------------------------------------------------------- >- * 20060204 124408 rsinha@ca.ibm.com - Rupam Kuehner >- * 20060221 100190 pmoogk@ca.ibm.com - Peter Moogk >+ * 20060204 124408 rsinha@ca.ibm.com - Rupam Kuehner >+ * 20060221 100190 pmoogk@ca.ibm.com - Peter Moogk >+ * 20060221 119111 rsinha@ca.ibm.com - Rupam Kuehner > *******************************************************************************/ > package org.eclipse.jst.ws.internal.creation.ui.widgets.runtime; > >@@ -333,35 +334,44 @@ > } > else > { >- //Look at the project type to ensure that it is suitable for the selected runtime >- //and server. >- >- String templateId = getServiceComponentType(); >- >- if (templateId != null && templateId.length()>0) >+ //Non-existing project is only permitted if there is a server selected. >+ if (serverFactoryId==null || serverFactoryId.length()==0) > { >- //Check if the runtime supports it. >- if (!WebServiceRuntimeExtensionUtils2.doesServiceTypeAndRuntimeSupportTemplate(typeId, runtimeId, templateId)) >- { >- String runtimeLabel = WebServiceRuntimeExtensionUtils2.getRuntimeLabelById(runtimeId); >- String templateLabel = FacetUtils.getTemplateLabelById(templateId); >- finalStatus = StatusUtils.errorStatus(NLS.bind(ConsumptionUIMessages.MSG_SERVICE_RUNTIME_DOES_NOT_SUPPORT_TEMPLATE, new String[]{runtimeLabel, templateLabel})); >- } >- >- //Check if the server supports it. >- if (serverFactoryId!=null && serverFactoryId.length()>0) >+ finalStatus = StatusUtils.errorStatus(NLS.bind(ConsumptionUIMessages.MSG_PROJECT_MUST_EXIST, new String[]{projectName})); >+ } >+ else >+ { >+ // Look at the project type to ensure that it is suitable for the >+ // selected runtime and server. >+ String templateId = getServiceComponentType(); >+ >+ if (templateId != null && templateId.length() > 0) > { >- if (!valUtils.doesServerSupportTemplate(serverFactoryId, templateId)) >+ // Check if the runtime supports it. >+ if (!WebServiceRuntimeExtensionUtils2.doesServiceTypeAndRuntimeSupportTemplate(typeId, runtimeId, templateId)) > { >- String serverLabel = WebServiceRuntimeExtensionUtils2.getServerLabelById(serverFactoryId); >+ String runtimeLabel = WebServiceRuntimeExtensionUtils2.getRuntimeLabelById(runtimeId); > String templateLabel = FacetUtils.getTemplateLabelById(templateId); >- finalStatus = StatusUtils.errorStatus(NLS.bind(ConsumptionUIMessages.MSG_SERVICE_SERVER_DOES_NOT_SUPPORT_TEMPLATE, new String[]{serverLabel, templateLabel})); >+ finalStatus = StatusUtils.errorStatus(NLS.bind(ConsumptionUIMessages.MSG_SERVICE_RUNTIME_DOES_NOT_SUPPORT_TEMPLATE, >+ new String[] { runtimeLabel, templateLabel })); >+ } >+ >+ // Check if the server supports it. >+ if (serverFactoryId != null && serverFactoryId.length() > 0) >+ { >+ if (!valUtils.doesServerSupportTemplate(serverFactoryId, templateId)) >+ { >+ String serverLabel = WebServiceRuntimeExtensionUtils2.getServerLabelById(serverFactoryId); >+ String templateLabel = FacetUtils.getTemplateLabelById(templateId); >+ finalStatus = StatusUtils.errorStatus(NLS.bind( >+ ConsumptionUIMessages.MSG_SERVICE_SERVER_DOES_NOT_SUPPORT_TEMPLATE, >+ new String[] { serverLabel, templateLabel })); >+ } > } > } > } > > >- > } > } > >Index: src/org/eclipse/jst/ws/internal/creation/ui/widgets/runtime/ServerRuntimeSelectionWidgetDefaultingCommand.java >=================================================================== >RCS file: /cvsroot/webtools/jst/components/ws/plugins/org.eclipse.jst.ws.creation.ui/src/org/eclipse/jst/ws/internal/creation/ui/widgets/runtime/ServerRuntimeSelectionWidgetDefaultingCommand.java,v >retrieving revision 1.41 >diff -u -r1.41 ServerRuntimeSelectionWidgetDefaultingCommand.java >--- src/org/eclipse/jst/ws/internal/creation/ui/widgets/runtime/ServerRuntimeSelectionWidgetDefaultingCommand.java 2 Feb 2006 19:04:59 -0000 1.41 >+++ src/org/eclipse/jst/ws/internal/creation/ui/widgets/runtime/ServerRuntimeSelectionWidgetDefaultingCommand.java 22 Feb 2006 00:24:37 -0000 >@@ -1,15 +1,16 @@ > /******************************************************************************* >- * Copyright (c) 2004 IBM Corporation and others. >+ * Copyright (c) 2004, 2006 IBM Corporation and others. > * All rights reserved. This program and the accompanying materials > * are made available under the terms of the Eclipse Public License v1.0 > * which accompanies this distribution, and is available at > * http://www.eclipse.org/legal/epl-v10.html >- * >+ * > * Contributors: >- * IBM Corporation - initial API and implementation >+ * IBM Corporation - initial API and implementation > * yyyymmdd bug Email and other contact information > * -------- -------- ----------------------------------------------------------- > * 20060131 121071 rsinha@ca.ibm.com - Rupam Kuehner >+ * 20060221 119111 rsinha@ca.ibm.com - Rupam Kuehner > *******************************************************************************/ > package org.eclipse.jst.ws.internal.creation.ui.widgets.runtime; > >@@ -35,8 +36,8 @@ > import org.eclipse.jst.ws.internal.consumption.ui.preferences.ProjectTopologyContext; > import org.eclipse.jst.ws.internal.consumption.ui.widgets.runtime.ClientRuntimeSelectionWidgetDefaultingCommand; > import org.eclipse.jst.ws.internal.consumption.ui.wsrt.FacetMatchCache; >+import org.eclipse.jst.ws.internal.consumption.ui.wsrt.RuntimeDescriptor; > import org.eclipse.jst.ws.internal.consumption.ui.wsrt.ServiceRuntimeDescriptor; >-import org.eclipse.jst.ws.internal.consumption.ui.wsrt.WebServiceRuntimeExtensionUtils; > import org.eclipse.jst.ws.internal.consumption.ui.wsrt.WebServiceRuntimeExtensionUtils2; > import org.eclipse.jst.ws.internal.data.TypeRuntimeServer; > import org.eclipse.osgi.util.NLS; >@@ -308,10 +309,15 @@ > } > > //No suitable server was found. Popup an error. >- String runtimeLabel = WebServiceRuntimeExtensionUtils2.getRuntimeLabelById(serviceIds_.getRuntimeId()); >- String serverLabels = getServerLabels(serviceIds_.getRuntimeId()); >- IStatus status = StatusUtils.errorStatus(NLS.bind(ConsumptionUIMessages.MSG_ERROR_NO_SERVER_RUNTIME, new String[]{runtimeLabel, serverLabels}) ); >- return status; >+ RuntimeDescriptor runtimeDescriptor = WebServiceRuntimeExtensionUtils2.getRuntimeById(serviceIds_.getRuntimeId()); >+ if (runtimeDescriptor.getServerRequired()) >+ { >+ String runtimeLabel = WebServiceRuntimeExtensionUtils2.getRuntimeLabelById(serviceIds_.getRuntimeId()); >+ IStatus status = StatusUtils.errorStatus(NLS.bind(ConsumptionUIMessages.MSG_ERROR_NO_SERVER_RUNTIME, new String[]{runtimeLabel}) ); >+ return status; >+ } >+ >+ return Status.OK_STATUS; > } > > private IServer getServerFromServiceRuntimeId() >@@ -352,41 +358,7 @@ > return null; > } > >- /* >- private IServer getFirstSupportedServer(IServer[] servers, String serviceRuntimeId, IProject serviceProject) >- { >- if (servers != null && servers.length > 0) { >- for (int i = 0; i < servers.length; i++) >- { >- String serverFactoryId = servers[i].getServerType().getId(); >- if (WebServiceRuntimeExtensionUtils2.doesServiceRuntimeSupportServer(serviceRuntimeId, serverFactoryId)) >- { >- //TODO check if the server type supports the project before returning. >- return servers[i]; >- } >- } >- } >- return null; >- } >- */ > >- private String getServerLabels(String serviceRuntimeId) >- { >- String[] validServerFactoryIds = WebServiceRuntimeExtensionUtils2.getServerFactoryIdsByServiceRuntime(serviceRuntimeId); >- //String[] validServerLabels = new String[validServerFactoryIds.length]; >- StringBuffer validServerLabels = new StringBuffer(); >- for (int i=0; i<validServerFactoryIds.length; i++) >- { >- if (i>0) >- { >- validServerLabels.append(", "); >- } >- validServerLabels.append(WebServiceRuntimeExtensionUtils.getServerLabelById(validServerFactoryIds[i])); >- >- } >- return validServerLabels.toString(); >- } >- > private String getDefaultServiceProjectTemplate() > { > String[] templates = WebServiceRuntimeExtensionUtils2.getServiceProjectTemplates(serviceIds_.getTypeId(), serviceIds_.getRuntimeId()); >@@ -604,4 +576,4 @@ > return serviceNeedEAR_; > } > >-} >\ No newline at end of file >+} >Index: src/org/eclipse/jst/ws/internal/creation/ui/widgets/binding/ServerWidgetBinding.java >=================================================================== >RCS file: /cvsroot/webtools/jst/components/ws/plugins/org.eclipse.jst.ws.creation.ui/src/org/eclipse/jst/ws/internal/creation/ui/widgets/binding/ServerWidgetBinding.java,v >retrieving revision 1.37 >diff -u -r1.37 ServerWidgetBinding.java >--- src/org/eclipse/jst/ws/internal/creation/ui/widgets/binding/ServerWidgetBinding.java 6 Feb 2006 19:42:22 -0000 1.37 >+++ src/org/eclipse/jst/ws/internal/creation/ui/widgets/binding/ServerWidgetBinding.java 22 Feb 2006 00:24:37 -0000 >@@ -1,16 +1,17 @@ > /******************************************************************************* >- * Copyright (c) 2004 IBM Corporation and others. >+ * Copyright (c) 2004, 2006 IBM Corporation and others. > * All rights reserved. This program and the accompanying materials > * are made available under the terms of the Eclipse Public License v1.0 > * which accompanies this distribution, and is available at > * http://www.eclipse.org/legal/epl-v10.html >- * >+ * > * Contributors: >- * IBM Corporation - initial API and implementation >+ * IBM Corporation - initial API and implementation > * yyyymmdd bug Email and other contact information > * -------- -------- ----------------------------------------------------------- > * 20060204 124408 rsinha@ca.ibm.com - Rupam Kuehner > * 20060204 121605 rsinha@ca.ibm.com - Rupam Kuehner >+ * 20060221 119111 rsinha@ca.ibm.com - Rupam Kuehner > *******************************************************************************/ > package org.eclipse.jst.ws.internal.creation.ui.widgets.binding; > >@@ -381,6 +382,7 @@ > dataRegistry.addMapping( ServerExtensionDefaultingCommand.class, "TestService", PreClientDevelopCommand.class); > > dataRegistry.addMapping( ServerWizardWidgetOutputCommand.class, "ResourceContext", PreClientDevelopCommand.class); >+ dataRegistry.addMapping( ClientExtensionDefaultingCommand.class, "DeployClient", PreClientDevelopCommand.class ); > dataRegistry.addMapping( ClientExtensionDefaultingCommand.class, "InstallClient", PreClientDevelopCommand.class ); > dataRegistry.addMapping( ClientExtensionDefaultingCommand.class, "InstallClient", PreClientDevelopCommand.class, "StartService", null); > dataRegistry.addMapping( ClientExtensionDefaultingCommand.class, "ClientTypeRuntimeServer", PreClientDevelopCommand.class ); >@@ -512,6 +514,7 @@ > dataRegistry.addMapping(ServerExtensionDefaultingCommand.class, "ServiceTypeRuntimeServer", ClientTestDelegateCommand.class); > > // Setup the PreServiceDevelopCommand. >+ dataRegistry.addMapping( ServerExtensionDefaultingCommand.class, "DeployService", PreServiceDevelopCommand.class); > dataRegistry.addMapping( ServerExtensionDefaultingCommand.class, "InstallService", PreServiceDevelopCommand.class); > dataRegistry.addMapping( ServerExtensionDefaultingCommand.class, "StartService", PreServiceDevelopCommand.class); > dataRegistry.addMapping( ServerExtensionDefaultingCommand.class, "TestService", PreServiceDevelopCommand.class); >Index: src/org/eclipse/jst/ws/internal/creation/ui/ant/AntServiceRootCommandFragment.java >=================================================================== >RCS file: /cvsroot/webtools/jst/components/ws/plugins/org.eclipse.jst.ws.creation.ui/src/org/eclipse/jst/ws/internal/creation/ui/ant/AntServiceRootCommandFragment.java,v >retrieving revision 1.6 >diff -u -r1.6 AntServiceRootCommandFragment.java >--- src/org/eclipse/jst/ws/internal/creation/ui/ant/AntServiceRootCommandFragment.java 5 Dec 2005 01:50:46 -0000 1.6 >+++ src/org/eclipse/jst/ws/internal/creation/ui/ant/AntServiceRootCommandFragment.java 22 Feb 2006 00:24:35 -0000 >@@ -1,12 +1,15 @@ > /******************************************************************************* >- * Copyright (c) 2005 IBM Corporation and others. >+ * Copyright (c) 2005, 2006 IBM Corporation and others. > * All rights reserved. This program and the accompanying materials > * are made available under the terms of the Eclipse Public License v1.0 > * which accompanies this distribution, and is available at > * http://www.eclipse.org/legal/epl-v10.html >- * >+ * > * Contributors: >- * IBM Corporation - initial API and implementation >+ * IBM Corporation - initial API and implementation >+ * yyyymmdd bug Email and other contact information >+ * -------- -------- ----------------------------------------------------------- >+ * 20060221 119111 rsinha@ca.ibm.com - Rupam Kuehner > *******************************************************************************/ > package org.eclipse.jst.ws.internal.creation.ui.ant; > >@@ -90,6 +93,7 @@ > dataRegistry.addMapping(AntDefaultingOperation.class, "ClientIdsFixed", ServerRuntimeSelectionWidgetDefaultingCommand.class); > dataRegistry.addMapping(AntDefaultingOperation.class, "StartService", PreServiceDevelopCommand.class); > dataRegistry.addMapping(AntDefaultingOperation.class, "InstallService", PreServiceDevelopCommand.class); >+ dataRegistry.addMapping(AntDefaultingOperation.class, "DeployService", PreServiceDevelopCommand.class); > > // Map ServerRuntimeSelectionWidgetDefaultingCommand > dataRegistry.addMapping(ServerRuntimeSelectionWidgetDefaultingCommand.class, "ServiceTypeRuntimeServer", ServerExtensionDefaultingCommand.class);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 119111
:
35109
|
35110
|
35111
| 35112 |
35113