Attachment 31761 Details for Bug 120411 – add protected double getThreshold ()

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] add protected double getThreshold ()

SnapToGeometry patch.txt (text/plain), 5.18 KB, created by Chris Lee

on 2005-12-14 12:25:26 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Lee

Created: 2005-12-14 12:25:26 EST

Size: 5.18 KB

patch

obsolete

>Index: SnapToGeometry.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.gef/src/org/eclipse/gef/SnapToGeometry.java,v
>retrieving revision 1.37
>diff -u -r1.37 SnapToGeometry.java
>--- SnapToGeometry.java	8 Dec 2005 18:46:04 -0000	1.37
>+++ SnapToGeometry.java	14 Dec 2005 17:24:51 -0000
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Business Objects SA - getThreshold()
>  *******************************************************************************/
> package org.eclipse.gef;
> 
>@@ -165,6 +166,17 @@
> }
> 
> /**
>+ * The sensitivity of the snapping.  Corrections greater than this value will not occur.
>+ * Subclasses may override this method to change the sensitivity.
>+ * 
>+ * @return the snapping threshold
>+ * @since 3.2
>+ */
>+protected double getThreshold() {
>+    return THRESHOLD;
>+}
>+
>+/**
>  * Generates a list of parts which should be snapped to.  The list is the original
>  * children, minus the given exclusions, minus and children whose figures are not visible.
>  * @since 3.0
>@@ -196,7 +208,7 @@
>  * @param vert <code>true</code> if the correction is vertical
>  * @param near the left/top side of the rectangle 
>  * @param far the right/bottom side of the rectangle
>- * @return the correction amount or THRESHOLD if no correction was made
>+ * @return the correction amount or getThreshold () if no correction was made
>  */
> protected double getCorrectionFor(Entry entries[], Map extendedData, boolean vert, 
>                                 double near, double far) {
>@@ -208,27 +220,27 @@
> 	if ((int)(near - far) % 2 != 0)
> 		total -= 1.0;
> 	double result = getCorrectionFor(entries, extendedData, vert, total / 2, 0);
>-	if (result == THRESHOLD)
>+	if (result == getThreshold ())
> 		result = getCorrectionFor(entries, extendedData, vert, near, -1);
>-	if (result == THRESHOLD)
>+	if (result == getThreshold ())
> 		result = getCorrectionFor(entries, extendedData, vert, far, 1);
> 	return result;
> }
> 
> /**
>- * Returns the correction value between ± {@link #THRESHOLD}, or the THRESHOLD if no
>- * corrections were found.
>+ * Returns the correction value between ± {@link #getThreshold ()}, or the getThreshold ()
>+ * if no corrections were found.
>  * @param entries the entries
>  * @param extendedData the map for setting values
>  * @param vert <code>true</code> if vertical
>  * @param value the value being corrected
>  * @param side which sides should be considered
>- * @return the correction or THRESHOLD if no correction was made
>+ * @return the correction or getThreshold () if no correction was made
>  */
> protected double getCorrectionFor(Entry entries[], Map extendedData, boolean vert, 
>                                 double value, int side) {
>-	double resultMag = THRESHOLD;
>-	double result = THRESHOLD;
>+	double resultMag = getThreshold ();
>+	double result = getThreshold ();
> 	
> 	String property;
> 	if (side == -1)
>@@ -322,20 +334,20 @@
> 	}
> 	
> 	if ((snapOrientation & HORIZONTAL) != 0) {
>-		double xcorrect = THRESHOLD;
>+		double xcorrect = getThreshold ();
> 		xcorrect = getCorrectionFor(cols, request.getExtendedData(), true, 
> 				baseRect.preciseX, baseRect.preciseRight());
>-		if (xcorrect != THRESHOLD) {
>+		if (xcorrect != getThreshold ()) {
> 			snapOrientation &= ~HORIZONTAL;
> 			correction.preciseX += xcorrect;
> 		}
> 	}
> 	
> 	if ((snapOrientation & VERTICAL) != 0) {
>-		double ycorrect = THRESHOLD;
>+		double ycorrect = getThreshold ();
> 		ycorrect = getCorrectionFor(rows, request.getExtendedData(), false, 
> 				baseRect.preciseY, baseRect.preciseBottom());
>-		if (ycorrect != THRESHOLD) {
>+		if (ycorrect != getThreshold ()) {
> 			snapOrientation &= ~VERTICAL;
> 			correction.preciseY += ycorrect;
> 		}
>@@ -344,7 +356,7 @@
> 	if ((snapOrientation & EAST) != 0) {
> 		double rightCorrection = getCorrectionFor(cols, request.getExtendedData(), 
> 				true, baseRect.preciseRight() - 1, 1);
>-		if (rightCorrection != THRESHOLD) {
>+		if (rightCorrection != getThreshold ()) {
> 			snapOrientation &= ~EAST;
> 			correction.preciseWidth += rightCorrection;
> 		}
>@@ -353,7 +365,7 @@
> 	if ((snapOrientation & WEST) != 0) {
> 		double leftCorrection = getCorrectionFor(cols, request.getExtendedData(), 
> 				true, baseRect.preciseX, -1);
>-		if (leftCorrection != THRESHOLD) {
>+		if (leftCorrection != getThreshold ()) {
> 			snapOrientation &= ~WEST;
> 			correction.preciseWidth -= leftCorrection;
> 			correction.preciseX += leftCorrection;
>@@ -363,7 +375,7 @@
> 	if ((snapOrientation & SOUTH) != 0) {
> 		double bottom = getCorrectionFor(rows, request.getExtendedData(), false,
> 				baseRect.preciseBottom() - 1, 1);
>-		if (bottom != THRESHOLD) {
>+		if (bottom != getThreshold ()) {
> 			snapOrientation &= ~SOUTH;
> 			correction.preciseHeight += bottom;
> 		}
>@@ -372,7 +384,7 @@
> 	if ((snapOrientation & NORTH) != 0) {
> 		double topCorrection = getCorrectionFor(rows, request.getExtendedData(), 
> 				false, baseRect.preciseY, -1);
>-		if (topCorrection != THRESHOLD) {
>+		if (topCorrection != getThreshold ()) {
> 			snapOrientation &= ~NORTH;
> 			correction.preciseHeight -= topCorrection;
> 			correction.preciseY += topCorrection;

Actions: View | Diff

Attachments on bug 120411: 31761 | 56006