Attachment 31698 Details for Bug 120656 – PopupDialog patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] PopupDialog patch

PopupDialog.120656.patch (text/plain), 1.05 KB, created by Susan McCourt

on 2005-12-13 19:54:30 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Susan McCourt

Created: 2005-12-13 19:54:30 EST

Size: 1.05 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface
>Index: src/org/eclipse/jface/dialogs/PopupDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface/src/org/eclipse/jface/dialogs/PopupDialog.java,v
>retrieving revision 1.18
>diff -u -r1.18 PopupDialog.java
>--- src/org/eclipse/jface/dialogs/PopupDialog.java	13 Dec 2005 23:11:33 -0000	1.18
>+++ src/org/eclipse/jface/dialogs/PopupDialog.java	14 Dec 2005 00:54:55 -0000
>@@ -741,9 +741,15 @@
> 		Rectangle[] r = new Rectangle[] { shell.getBounds() };
> 		tracker.setRectangles(r);
> 
>+		// Ignore any deactivate events caused by opening the tracker.
>+		// See https://bugs.eclipse.org/bugs/show_bug.cgi?id=120656
>+		boolean oldListenToDeactivate = listenToDeactivate;
>+		listenToDeactivate = false;
> 		if (tracker.open()) {
>-			shell.setBounds(tracker.getRectangles()[0]);
>-
>+			if (shell != null && !shell.isDisposed()) {
>+				shell.setBounds(tracker.getRectangles()[0]);
>+			}
>+			listenToDeactivate = oldListenToDeactivate;
> 		}
> 	}
>

Actions: View | Diff

Attachments on bug 120656: 31698