Attachment 30303 Details for Bug 117295 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix

fix_117295.txt (text/plain), 18.99 KB, created by Benno Baumgartner

on 2005-11-21 05:53:13 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Benno Baumgartner

Created: 2005-11-21 05:53:13 EST

Size: 18.99 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.ui
>Index: ui/org/eclipse/jdt/internal/ui/fix/CleanUpRefactoringWizard.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/CleanUpRefactoringWizard.java,v
>retrieving revision 1.8
>diff -u -r1.8 CleanUpRefactoringWizard.java
>--- ui/org/eclipse/jdt/internal/ui/fix/CleanUpRefactoringWizard.java	10 Nov 2005 13:33:19 -0000	1.8
>+++ ui/org/eclipse/jdt/internal/ui/fix/CleanUpRefactoringWizard.java	21 Nov 2005 10:52:32 -0000
>@@ -10,6 +10,9 @@
>  *******************************************************************************/
> package org.eclipse.jdt.internal.ui.fix;
> 
>+import java.util.ArrayList;
>+import java.util.List;
>+
> import org.eclipse.core.resources.ResourcesPlugin;
> 
> import org.eclipse.swt.SWT;
>@@ -30,12 +33,14 @@
> 
> import org.eclipse.ui.dialogs.ContainerCheckedTreeViewer;
> 
>+import org.eclipse.ltk.internal.ui.refactoring.RefactoringUIPlugin;
> import org.eclipse.ltk.ui.refactoring.RefactoringWizard;
> import org.eclipse.ltk.ui.refactoring.UserInputWizardPage;
> 
> import org.eclipse.jdt.core.ICompilationUnit;
> import org.eclipse.jdt.core.IJavaElement;
> import org.eclipse.jdt.core.IJavaModel;
>+import org.eclipse.jdt.core.IPackageFragment;
> import org.eclipse.jdt.core.JavaCore;
> 
> import org.eclipse.jdt.internal.corext.fix.CleanUpRefactoring;
>@@ -124,7 +129,54 @@
> 				treeViewer.expandToLevel(compilationUnit, 0);
> 				treeViewer.setChecked(compilationUnit, true);
> 			}
>-			treeViewer.setSelection(new StructuredSelection(compilationUnits), true);
>+			treeViewer.setSelection(new StructuredSelection(smallestCommonParents(compilationUnits)), true);
>+		}
>+		
>+		private IJavaElement[] smallestCommonParents(IJavaElement[] elements) {
>+			if (elements.length == 1) {
>+				return elements;
>+			} else {
>+				List parents= new ArrayList();
>+				boolean hasParents= false;
>+				
>+				IJavaElement parent= getParent(elements[0]);
>+				if (parent == null) {
>+					parent= elements[0];
>+				} else {
>+					hasParents= true;
>+				}
>+				parents.add(parent);
>+				
>+				for (int i= 1; i < elements.length; i++) {
>+					parent= getParent(elements[i]);
>+					if (getParent(elements[i - 1]) != parent) {
>+						if (parent == null) {
>+							parent= elements[i];
>+						} else {
>+							hasParents= true;
>+						}
>+						if (!parents.contains(parent)) {
>+							parents.add(parent);
>+						}
>+					}
>+				}
>+				
>+				IJavaElement[] parentsArray= (IJavaElement[])parents.toArray(new IJavaElement[parents.size()]);
>+				if (hasParents) {
>+					return smallestCommonParents(parentsArray);
>+				}
>+				return parentsArray;
>+			}
>+		}
>+		
>+		private IJavaElement getParent(IJavaElement element) {
>+			if (element instanceof ICompilationUnit) {
>+				return element.getParent();
>+			} else if (element instanceof IPackageFragment){
>+				return element.getParent().getParent();
>+			} else {
>+				return element.getParent();
>+			}
> 		}
> 
> 		protected boolean performFinish() {
>@@ -146,9 +198,9 @@
> 					refactoring.addCompilationUnit((ICompilationUnit)checkedElements[i]);
> 			}
> 			if (!refactoring.hasMultiFix()) {
>-				NameFixTuple[] multiFixes= getMultiFixes();
>+				IMultiFix[] multiFixes= createAllMultiFixes();
> 				for (int i= 0; i < multiFixes.length; i++) {
>-					refactoring.addMultiFix(multiFixes[i].getFix());
>+					refactoring.addMultiFix(multiFixes[i]);
> 				}
> 			}
> 		}
>@@ -156,6 +208,8 @@
> 	
> 	private class SelectFixesPage extends UserInputWizardPage {
> 		
>+		private NameFixTuple[] fMultiFixes;
>+		
> 		public SelectFixesPage(String name) {
> 			super(name);
> 		}
>@@ -207,6 +261,14 @@
> 			storeSettings();
> 			return super.getNextPage();
> 		}
>+		
>+		private void storeSettings() {
>+			IDialogSettings settings= getCleanUpWizardSettings();
>+			NameFixTuple[] fixes= getMultiFixes();
>+			for (int i= 0; i < fixes.length; i++) {
>+				fixes[i].getFix().saveSettings(settings);
>+			}
>+		}
> 
> 		private void initializeRefactoring() {
> 			CleanUpRefactoring refactoring= (CleanUpRefactoring)getRefactoring();
>@@ -216,11 +278,22 @@
> 				refactoring.addMultiFix(multiFixes[i].getFix());
> 			}
> 		}	
>+		
>+		private NameFixTuple[] getMultiFixes() {
>+			if (fMultiFixes == null) {
>+				IMultiFix[] fixes= createAllMultiFixes();
>+				fMultiFixes= new NameFixTuple[4];
>+				fMultiFixes[0]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_CodeStyleSection_description, fixes[0]);
>+				fMultiFixes[1]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_UnusedCodeSection_description, fixes[1]);
>+				fMultiFixes[2]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_J2SE50Section_description, fixes[2]);
>+				fMultiFixes[3]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_StringExternalization_description, fixes[3]);
>+			}
>+			return fMultiFixes;
>+		}
> 	}
> 	
> 	private final boolean fShowCUPage;
> 	private final boolean fShowCleanUpPage;
>-	private NameFixTuple[] fMultiFixes;
> 	
> 	public CleanUpRefactoringWizard(CleanUpRefactoring refactoring, int flags, boolean showCUPage, boolean showCleanUpPage) {
> 		super(refactoring, flags);
>@@ -247,35 +320,26 @@
> 			addPage(selectSolverPage);
> 		}
> 	}
>+	
>+	public static IMultiFix[] createAllMultiFixes() {
>+		IDialogSettings section= getCleanUpWizardSettings();
> 		
>-	private NameFixTuple[] getMultiFixes() {
>-		if (fMultiFixes == null) {
>-			IDialogSettings settings= CleanUpRefactoringWizard.this.getDialogSettings();
>-			IDialogSettings section= settings.getSection(CLEAN_UP_WIZARD_SETTINGS_SECTION_ID);
>-			fMultiFixes= new NameFixTuple[4];
>-			if (section == null) {
>-				section= settings.addNewSection(CLEAN_UP_WIZARD_SETTINGS_SECTION_ID);
>-				fMultiFixes[0]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_CodeStyleSection_description, new CodeStyleMultiFix(false, true, false, false));
>-				fMultiFixes[1]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_UnusedCodeSection_description, new UnusedCodeMultiFix(true, true, true, false, true, false));	
>-				fMultiFixes[2]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_J2SE50Section_description, new Java50MultiFix(true, true));
>-				fMultiFixes[3]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_StringExternalization_description, new StringMultiFix(false, true));
>-				storeSettings();
>-			} else {
>-				fMultiFixes[0]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_CodeStyleSection_description, new CodeStyleMultiFix(section));
>-				fMultiFixes[1]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_UnusedCodeSection_description, new UnusedCodeMultiFix(section));
>-				fMultiFixes[2]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_J2SE50Section_description, new Java50MultiFix(section));
>-				fMultiFixes[3]= new NameFixTuple(MultiFixMessages.CleanUpRefactoringWizard_StringExternalization_description, new StringMultiFix(section));
>-			}
>-		}
>-		return fMultiFixes;
>+		IMultiFix[] result= new IMultiFix[4];
>+		result[0]= new CodeStyleMultiFix(section);
>+		result[1]= new UnusedCodeMultiFix(section);
>+		result[2]= new Java50MultiFix(section);
>+		result[3]= new StringMultiFix(section);
>+		
>+		return result;
> 	}
> 	
>-	private void storeSettings() {
>-		IDialogSettings settings= CleanUpRefactoringWizard.this.getDialogSettings().getSection(CLEAN_UP_WIZARD_SETTINGS_SECTION_ID);
>-		NameFixTuple[] fixes= getMultiFixes();
>-		for (int i= 0; i < fixes.length; i++) {
>-			fixes[i].getFix().saveSettings(settings);
>+	private static IDialogSettings getCleanUpWizardSettings() {
>+		IDialogSettings settings= RefactoringUIPlugin.getDefault().getDialogSettings();
>+		IDialogSettings section= settings.getSection(CLEAN_UP_WIZARD_SETTINGS_SECTION_ID);
>+		if (section == null) {
>+			section= settings.addNewSection(CLEAN_UP_WIZARD_SETTINGS_SECTION_ID);
> 		}
>+		return section;
> 	}
> 
> }
>Index: ui/org/eclipse/jdt/internal/ui/fix/Java50MultiFix.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/Java50MultiFix.java,v
>retrieving revision 1.4
>diff -u -r1.4 Java50MultiFix.java
>--- ui/org/eclipse/jdt/internal/ui/fix/Java50MultiFix.java	31 Oct 2005 15:07:32 -0000	1.4
>+++ ui/org/eclipse/jdt/internal/ui/fix/Java50MultiFix.java	21 Nov 2005 10:52:32 -0000
>@@ -56,12 +56,24 @@
> 	private boolean fAddDepricatedAnnotation;
> 
> 	public Java50MultiFix(boolean addOverrideAnnotation, boolean addDepricatedAnnotation) {
>-		fAddOverrideAnnotation= addOverrideAnnotation;
>-		fAddDepricatedAnnotation= addDepricatedAnnotation;
>+		init(	addOverrideAnnotation,
>+				addDepricatedAnnotation);
> 	}
> 
> 	public Java50MultiFix(IDialogSettings settings) {
>-		this(settings.getBoolean(ADD_OVERRIDE_ANNOTATION_SETTINGS_ID), settings.getBoolean(ADD_DEPRICATED_ANNOTATION_SETTINGS_ID));
>+		if (settings.get(ADD_OVERRIDE_ANNOTATION_SETTINGS_ID) == null) {
>+			settings.put(ADD_OVERRIDE_ANNOTATION_SETTINGS_ID, true);
>+		}
>+		if (settings.get(ADD_DEPRICATED_ANNOTATION_SETTINGS_ID) == null) {
>+			settings.put(ADD_DEPRICATED_ANNOTATION_SETTINGS_ID, true);
>+		}
>+		init(	settings.getBoolean(ADD_OVERRIDE_ANNOTATION_SETTINGS_ID), 
>+				settings.getBoolean(ADD_DEPRICATED_ANNOTATION_SETTINGS_ID));
>+	}
>+
>+	private void init(boolean addOverrideAnnotation, boolean addDepricatedAnnotation) {
>+		fAddOverrideAnnotation= addOverrideAnnotation;
>+		fAddDepricatedAnnotation= addDepricatedAnnotation;
> 	}
> 
> 	public IFix createFix(CompilationUnit compilationUnit) throws CoreException {
>Index: ui/org/eclipse/jdt/internal/ui/fix/StringMultiFix.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/StringMultiFix.java,v
>retrieving revision 1.4
>diff -u -r1.4 StringMultiFix.java
>--- ui/org/eclipse/jdt/internal/ui/fix/StringMultiFix.java	31 Oct 2005 15:07:32 -0000	1.4
>+++ ui/org/eclipse/jdt/internal/ui/fix/StringMultiFix.java	21 Nov 2005 10:52:32 -0000
>@@ -55,12 +55,23 @@
> 	private boolean fRemoveNlsTag;
> 
> 	public StringMultiFix(boolean addNLSTag, boolean removeNLSTag) {
>-		fAddNlsTag= addNLSTag;
>-		fRemoveNlsTag= removeNLSTag;
>+		init(addNLSTag, removeNLSTag);
> 	}
> 
> 	public StringMultiFix(IDialogSettings settings) {
>-		this(settings.getBoolean(ADD_NLS_TAG_SETTINGS_ID), settings.getBoolean(REMOVE_NLS_TAG_SETTINGS_ID));
>+		if (settings.get(ADD_NLS_TAG_SETTINGS_ID) == null) {
>+			settings.put(ADD_NLS_TAG_SETTINGS_ID, false);
>+		}
>+		if (settings.get(REMOVE_NLS_TAG_SETTINGS_ID) == null) {
>+			settings.put(REMOVE_NLS_TAG_SETTINGS_ID, true);
>+		}
>+		init(	settings.getBoolean(ADD_NLS_TAG_SETTINGS_ID), 
>+				settings.getBoolean(REMOVE_NLS_TAG_SETTINGS_ID));
>+	}
>+
>+	private void init(boolean addNLSTag, boolean removeNLSTag) {
>+		fAddNlsTag= addNLSTag;
>+		fRemoveNlsTag= removeNLSTag;
> 	}
> 
> 	public IFix createFix(CompilationUnit compilationUnit) throws CoreException {
>Index: ui/org/eclipse/jdt/internal/ui/fix/UnusedCodeMultiFix.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/UnusedCodeMultiFix.java,v
>retrieving revision 1.5
>diff -u -r1.5 UnusedCodeMultiFix.java
>--- ui/org/eclipse/jdt/internal/ui/fix/UnusedCodeMultiFix.java	2 Nov 2005 09:48:41 -0000	1.5
>+++ ui/org/eclipse/jdt/internal/ui/fix/UnusedCodeMultiFix.java	21 Nov 2005 10:52:32 -0000
>@@ -67,26 +67,54 @@
> 			boolean removeUnusedPrivateConstructors, boolean removeUnusedPrivateFields,
> 			boolean removeUnusedPrivateTypes, boolean removeUnusedLocalVariables) {
> 		
>-		fRemoveUnusedImports= removeUnusedImports;
>-		fRemoveUnusedPrivateMethods= removeUnusedPrivateMethods;
>-		fRemoveUnusedPrivateConstructors= removeUnusedPrivateConstructors;
>-		fRemoveUnusedPrivateFields= removeUnusedPrivateFields;
>-		fRemoveUnusedPrivateTypes= removeUnusedPrivateTypes;
>-		fRemoveUnusedLocalVariables= removeUnusedLocalVariables;
>+		init(	removeUnusedImports, 
>+				removeUnusedPrivateMethods,
>+				removeUnusedPrivateConstructors,
>+				removeUnusedPrivateFields,
>+				removeUnusedPrivateTypes,
>+				removeUnusedLocalVariables);
> 	}
> 
> 	public UnusedCodeMultiFix(IDialogSettings settings) {
>-		this(	settings.getBoolean(REMOVE_UNUSED_IMPORTS_SETTINGS_ID), 
>+		if (settings.get(REMOVE_UNUSED_IMPORTS_SETTINGS_ID) == null) {
>+			settings.put(REMOVE_UNUSED_IMPORTS_SETTINGS_ID, true);
>+		}
>+		if (settings.get(REMOVE_UNUSED_PRIVATE_METHODES_SETTINGS_ID) == null) {
>+			settings.put(REMOVE_UNUSED_PRIVATE_METHODES_SETTINGS_ID, false);
>+		}
>+		if (settings.get(REMOVE_UNUSED_PRIVATE_CONSTRUCTORS_SETTINGS_ID) == null) {
>+			settings.put(REMOVE_UNUSED_PRIVATE_CONSTRUCTORS_SETTINGS_ID, false);
>+		}
>+//		if (settings.get(REMOVE_UNUSED_PRIVATE_FIELDS_SETTINGS_ID) == null) {
>+			settings.put(REMOVE_UNUSED_PRIVATE_FIELDS_SETTINGS_ID, false);
>+//		}
>+		if (settings.get(REMOVE_UNUSED_PRIVATE_TYPE_SETTINGS_ID) == null) {
>+			settings.put(REMOVE_UNUSED_PRIVATE_TYPE_SETTINGS_ID, false);
>+		}
>+//		if (settings.get(REMOVE_UNUSED_LOCAL_VARIABLES_SETTINGS_ID) == null) {
>+			settings.put(REMOVE_UNUSED_LOCAL_VARIABLES_SETTINGS_ID, false);
>+//		}
>+		init(	settings.getBoolean(REMOVE_UNUSED_IMPORTS_SETTINGS_ID), 
> 				settings.getBoolean(REMOVE_UNUSED_PRIVATE_METHODES_SETTINGS_ID),
> 				settings.getBoolean(REMOVE_UNUSED_PRIVATE_CONSTRUCTORS_SETTINGS_ID),
>-//				settings.getBoolean(REMOVE_UNUSED_PRIVATE_FIELDS_SETTINGS_ID),
>-				false,
>+				settings.getBoolean(REMOVE_UNUSED_PRIVATE_FIELDS_SETTINGS_ID),
> 				settings.getBoolean(REMOVE_UNUSED_PRIVATE_TYPE_SETTINGS_ID),
>-//				settings.getBoolean(REMOVE_UNUSED_LOCAL_VARIABLES_SETTINGS_ID)
>-				false	
>+				settings.getBoolean(REMOVE_UNUSED_LOCAL_VARIABLES_SETTINGS_ID)
> 				);
> 	}
> 
>+	private void init(boolean removeUnusedImports, boolean removeUnusedPrivateMethods, 
>+			boolean removeUnusedPrivateConstructors, boolean removeUnusedPrivateFields,
>+			boolean removeUnusedPrivateTypes, boolean removeUnusedLocalVariables) {
>+		
>+		fRemoveUnusedImports= removeUnusedImports;
>+		fRemoveUnusedPrivateMethods= removeUnusedPrivateMethods;
>+		fRemoveUnusedPrivateConstructors= removeUnusedPrivateConstructors;
>+		fRemoveUnusedPrivateFields= removeUnusedPrivateFields;
>+		fRemoveUnusedPrivateTypes= removeUnusedPrivateTypes;
>+		fRemoveUnusedLocalVariables= removeUnusedLocalVariables;
>+	}
>+
> 	public IFix createFix(CompilationUnit compilationUnit) throws CoreException {
> 		
> 		List/*<ImportDeclaration>*/ removeImports= new ArrayList();
>Index: ui/org/eclipse/jdt/internal/ui/actions/CleanUpAction.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/CleanUpAction.java,v
>retrieving revision 1.2
>diff -u -r1.2 CleanUpAction.java
>--- ui/org/eclipse/jdt/internal/ui/actions/CleanUpAction.java	24 Oct 2005 13:46:44 -0000	1.2
>+++ ui/org/eclipse/jdt/internal/ui/actions/CleanUpAction.java	21 Nov 2005 10:52:32 -0000
>@@ -10,16 +10,21 @@
>  *******************************************************************************/
> package org.eclipse.jdt.internal.ui.actions;
> 
>+import java.lang.reflect.InvocationTargetException;
> import java.util.Arrays;
> import java.util.Collection;
> import java.util.HashSet;
> 
>+import org.eclipse.swt.widgets.Shell;
>+
> import org.eclipse.jface.viewers.IStructuredSelection;
> 
> import org.eclipse.jface.text.ITextSelection;
> 
> import org.eclipse.ui.IWorkbenchSite;
> 
>+import org.eclipse.ltk.core.refactoring.RefactoringCore;
>+
> import org.eclipse.ltk.ui.refactoring.RefactoringWizard;
> 
> import org.eclipse.jdt.core.ICompilationUnit;
>@@ -38,8 +43,11 @@
> import org.eclipse.jdt.internal.ui.JavaPlugin;
> import org.eclipse.jdt.internal.ui.browsing.LogicalPackage;
> import org.eclipse.jdt.internal.ui.fix.CleanUpRefactoringWizard;
>+import org.eclipse.jdt.internal.ui.fix.IMultiFix;
> import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor;
>+import org.eclipse.jdt.internal.ui.refactoring.RefactoringExecutionHelper;
> import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter;
>+import org.eclipse.jdt.internal.ui.util.BusyIndicatorRunnableContext;
> import org.eclipse.jdt.internal.ui.util.ElementValidator;
> 
> public class CleanUpAction extends SelectionDispatchAction {
>@@ -71,7 +79,7 @@
> 	public void run(ITextSelection selection) {
> 		ICompilationUnit cu= getCompilationUnit(fEditor);
> 		if (cu != null) {
>-			run(cu, true);
>+			runLight(cu);
> 		}
> 	}
> 	
>@@ -83,7 +91,7 @@
> 		if (cus.length == 0)
> 			return;
> 		if (cus.length == 1) {
>-			run(cus[0], false);
>+			run(cus[0]);
> 		} else {
> 			runOnMultiple(cus);
> 		}
>@@ -142,28 +150,38 @@
> 	 * Note: This method is for internal use only. Clients should not call this method.
> 	 * @param cu The compilation unit to process
> 	 */
>-	public void run(ICompilationUnit cu, boolean selectUnits) {
>+	public void run(ICompilationUnit cu) {
> 		if (!ElementValidator.check(cu, getShell(), ActionMessages.OrganizeImportsAction_error_title, fEditor != null)) 
> 			return;
> 		if (!ActionUtil.isProcessable(getShell(), cu))
> 			return;
> 		
>+		runOnMultiple(new ICompilationUnit[] {cu});
>+	}
>+
>+	private void runLight(ICompilationUnit cu) {
> 		CleanUpRefactoring refactoring= new CleanUpRefactoring();
> 		refactoring.addCompilationUnit(cu);
> 		
>-		CleanUpRefactoringWizard refactoringWizard= new CleanUpRefactoringWizard(refactoring, RefactoringWizard.WIZARD_BASED_USER_INTERFACE, selectUnits, true);
>+		IMultiFix[] fixes= CleanUpRefactoringWizard.createAllMultiFixes();
>+		for (int i= 0; i < fixes.length; i++) {
>+			refactoring.addMultiFix(fixes[i]);
>+		}
> 		
>-		RefactoringStarter starter= new RefactoringStarter();
>+		int stopSeverity= RefactoringCore.getConditionCheckingFailedSeverity();
>+		Shell shell= JavaPlugin.getActiveWorkbenchShell();
>+		BusyIndicatorRunnableContext context= new BusyIndicatorRunnableContext();
>+		RefactoringExecutionHelper executer= new RefactoringExecutionHelper(refactoring, stopSeverity, true, shell, context);
> 		try {
>-			starter.activate(refactoring, refactoringWizard, JavaPlugin.getActiveWorkbenchShell(), "Clean ups", true); //$NON-NLS-1$
>-		} catch (JavaModelException e) {
>+			executer.perform();
>+		} catch (InterruptedException e) {
>+		} catch (InvocationTargetException e) {
> 			JavaPlugin.log(e);
> 		}
>-		return;
> 	}
>-	
>+
> 	/**
>-	 * Perform organize import on multiple compilation units. No editors are opened.
>+	 * Perform on multiple compilation units. No editors are opened.
> 	 * @param cus The compilation units to run on
> 	 */
> 	public void runOnMultiple(final ICompilationUnit[] cus) {
>@@ -172,7 +190,7 @@
> 			refactoring.addCompilationUnit(cus[i]);
> 		}
> 		
>-		CleanUpRefactoringWizard refactoringWizard= new CleanUpRefactoringWizard(refactoring, RefactoringWizard.WIZARD_BASED_USER_INTERFACE, false, true);
>+		CleanUpRefactoringWizard refactoringWizard= new CleanUpRefactoringWizard(refactoring, RefactoringWizard.WIZARD_BASED_USER_INTERFACE, true, true);
> 		
> 		RefactoringStarter starter= new RefactoringStarter();
> 		try {

Actions: View | Diff

Attachments on bug 117295: 30303