Attachment 282083 Details for Bug 560620 – WIP

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] WIP

wip_record_since.patch (text/plain), 3.01 KB, created by Vikas Chandra

on 2020-03-11 05:37:57 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Vikas Chandra

Created: 2020-03-11 05:37:57 EDT

Size: 3.01 KB

patch

obsolete

>diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/BaseApiAnalyzer.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/BaseApiAnalyzer.java
>index 7a34505..606d84f 100644
>--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/BaseApiAnalyzer.java
>+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/BaseApiAnalyzer.java
>@@ -879,11 +879,12 @@
> 		if (fJavaProject == null) {
> 			return null;
> 		}
>-		ASTParser parser = ASTParser.newParser(AST.JLS10);
>+		ASTParser parser = ASTParser.newParser(AST.JLS14);
> 		parser.setFocalPosition(offset);
> 		parser.setResolveBindings(false);
> 		parser.setSource(root);
> 		Map<String, String> options = fJavaProject.getOptions(true);
>+		options.put(JavaCore.COMPILER_PB_ENABLE_PREVIEW_FEATURES, JavaCore.ENABLED);
> 		options.put(JavaCore.COMPILER_DOC_COMMENT_SUPPORT, JavaCore.ENABLED);
> 		parser.setCompilerOptions(options);
> 		return (CompilationUnit) parser.createAST(new NullProgressMonitor());
>diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/SinceTagChecker.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/SinceTagChecker.java
>index 2334e14..a083b91 100644
>--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/SinceTagChecker.java
>+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/builder/SinceTagChecker.java
>@@ -28,6 +28,7 @@
> import org.eclipse.jdt.core.dom.Initializer;
> import org.eclipse.jdt.core.dom.Javadoc;
> import org.eclipse.jdt.core.dom.MethodDeclaration;
>+import org.eclipse.jdt.core.dom.RecordDeclaration;
> import org.eclipse.jdt.core.dom.TagElement;
> import org.eclipse.jdt.core.dom.TextElement;
> import org.eclipse.jdt.core.dom.TypeDeclaration;
>@@ -90,6 +91,11 @@
> 		return visitAbstractTypeDeclaration(node);
> 	}
> 
>+	@Override
>+	public boolean visit(RecordDeclaration node) {
>+		return visitAbstractTypeDeclaration(node);
>+	}
>+
> 	/**
> 	 * @param declaration
> 	 * @return
>diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/provisional/scanner/TagScanner.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/provisional/scanner/TagScanner.java
>index b7054a7..897a928 100644
>--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/provisional/scanner/TagScanner.java
>+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/provisional/scanner/TagScanner.java
>@@ -610,7 +610,7 @@
> 	 */
> 	public void scan(CompilationUnit source, IApiDescription description, IApiTypeContainer container, Map<String, String> options, IProgressMonitor monitor) throws CoreException {
> 		SubMonitor localmonitor = SubMonitor.convert(monitor, 2);
>-		ASTParser parser = ASTParser.newParser(AST.JLS10);
>+		ASTParser parser = ASTParser.newParser(AST.JLS14);
> 		InputStream inputStream = null;
> 		try {
> 			inputStream = source.getInputStream();

Actions: View | Diff

Attachments on bug 560620: 282083