Attachment 27709 Details for Bug 106111 – Workaround for bug 106111

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Workaround for bug 106111

patch106111.txt (text/plain), 2.44 KB, created by Walter Harley

on 2005-09-29 20:01:05 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Walter Harley

Created: 2005-09-29 20:01:05 EDT

Size: 2.44 KB

patch

obsolete

>Index: BaseConfigurationBlock.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.apt.ui/src/org/eclipse/jdt/apt/ui/internal/preferences/BaseConfigurationBlock.java,v
>retrieving revision 1.7
>diff -u -r1.7 BaseConfigurationBlock.java
>--- BaseConfigurationBlock.java	30 Jul 2005 00:32:36 -0000	1.7
>+++ BaseConfigurationBlock.java	29 Sep 2005 23:59:03 -0000
>@@ -12,6 +12,7 @@
> package org.eclipse.jdt.apt.ui.internal.preferences;
> 
> import org.eclipse.core.resources.IProject;
>+import org.eclipse.core.resources.ProjectScope;
> import org.eclipse.core.runtime.preferences.DefaultScope;
> import org.eclipse.core.runtime.preferences.IScopeContext;
> import org.eclipse.core.runtime.preferences.InstanceScope;
>@@ -96,4 +97,24 @@
> 	 * @param changedKey Key that changed, or null, if all changed.
> 	 */	
> 	protected abstract void validateSettings(Key changedKey, String oldValue, String newValue);
>+
>+	/**
>+	 * TODO: this method is a workaround for Bugzilla 111144 and 106111.  When
>+	 * 111144 is fixed, remove this method and call hasProjectSpecificOptions() 
>+	 * instead.  The difference is that this one does not cause project prefs nodes
>+	 * to be cached in the WorkingCopyManager.
>+	 * @return true if the project has project-specific options.
>+	 */
>+	public boolean hasProjectSpecificOptionsNoCache(IProject project) {
>+		if (project != null) {
>+			IScopeContext projectContext= new ProjectScope(project);
>+			Key[] allKeys= fAllKeys;
>+			for (int i= 0; i < allKeys.length; i++) {
>+				if (allKeys[i].getStoredValue(projectContext, null) != null) {
>+					return true;
>+				}
>+			}
>+		}
>+		return false;
>+	}
> }
>Index: BasePreferencePage.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.apt.ui/src/org/eclipse/jdt/apt/ui/internal/preferences/BasePreferencePage.java,v
>retrieving revision 1.1
>diff -u -r1.1 BasePreferencePage.java
>--- BasePreferencePage.java	10 Jun 2005 17:50:41 -0000	1.1
>+++ BasePreferencePage.java	29 Sep 2005 23:59:03 -0000
>@@ -51,7 +51,9 @@
> 	}
> 	
> 	protected boolean hasProjectSpecificOptions(IProject project) {
>-		return getConfigurationBlock().hasProjectSpecificOptions(project);
>+		// Workaround for bug 106111 / 111144:
>+		// See BaseConfigurationBlock.hasProjectSpecificOptionsNoCache() for details.
>+		return getConfigurationBlock().hasProjectSpecificOptionsNoCache(project);
> 	}
> 	
> 	/*

Actions: View | Diff

Attachments on bug 106111: 27709