Attachment 27446 Details for Bug 110438 – proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed fix

fix_110438.txt (text/plain), 1.30 KB, created by Benno Baumgartner

on 2005-09-23 12:22:25 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Benno Baumgartner

Created: 2005-09-23 12:22:25 EDT

Size: 1.30 KB

patch

obsolete

>Index: ui/org/eclipse/jdt/internal/ui/text/correction/SurroundWithRunnableProposal.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/SurroundWithRunnableProposal.java,v
>retrieving revision 1.1
>diff -u -r1.1 SurroundWithRunnableProposal.java
>--- ui/org/eclipse/jdt/internal/ui/text/correction/SurroundWithRunnableProposal.java	23 Sep 2005 13:44:23 -0000	1.1
>+++ ui/org/eclipse/jdt/internal/ui/text/correction/SurroundWithRunnableProposal.java	23 Sep 2005 16:20:45 -0000
>@@ -191,7 +191,13 @@
> 			
> 			moveToBlock(selectedNodes, newBody, accessedAfter, readInside, fRewrite);
> 			
>-			getListRewrite(selectedNodes[0], fRewrite).insertAfter(insertedCode, selectedNodes[selectedNodes.length - 1], null);
>+			if (selectedNodes.length == 1 && ASTNodes.isControlStatementBody(selectedNodes[0].getLocationInParent())) {
>+				Block wrap= ast.newBlock();
>+				fRewrite.replace(selectedNodes[0], wrap, null);
>+				fRewrite.getListRewrite(wrap, Block.STATEMENTS_PROPERTY).insertFirst(insertedCode, null);
>+			} else {
>+				getListRewrite(selectedNodes[0], fRewrite).insertAfter(insertedCode, selectedNodes[selectedNodes.length - 1], null);
>+			}
> 			
> 			setEndPosition(fRewrite.track(insertedCode));
> 		}

Actions: View | Diff

Attachments on bug 110438: 27446 | 27447