Attachment 272580 Details for Bug 529327 – Proposed patch hiDPI DND bug

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch hiDPI DND bug

hiresDND.patch (text/plain), 1.41 KB, created by Janis Danisevskis

on 2018-02-08 01:53:01 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Janis Danisevskis

Created: 2018-02-08 01:53:01 EST

Size: 1.41 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java
>index 618caa2..4f1dabf 100644
>--- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java	
>+++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java	
>@@ -3284,7 +3284,8 @@ long /*int*/ gtk_button_press_event (long /*int*/ widget, long /*int*/ event, bo
> 		 */
> 		if (OS.isX11()) { // Wayland
> 			if (dragging) {
>-				sendDragEvent (gdkEvent.button, gdkEvent.state, (int) gdkEvent.x, (int) gdkEvent.y, false);
>+				Point scaledEvent = DPIUtil.autoScaleDown(new Point((int)gdkEvent.x, (int)gdkEvent.y));
>+				sendDragEvent (gdkEvent.button, gdkEvent.state, scaledEvent.x, scaledEvent.y, false);
> 				if (isDisposed ()) return 1;
> 			}
> 		}
>@@ -3622,7 +3623,8 @@ long /*int*/ gtk_motion_notify_event (long /*int*/ widget, long /*int*/ event) {
> 			GdkEventButton gdkEvent1 = new GdkEventButton ();
> 			OS.memmove (gdkEvent1, event, GdkEventButton.sizeof);
> 			if (gdkEvent1.type == OS.GDK_3BUTTON_PRESS) return 0;
>-			if (sendDragEvent (gdkEvent1.button, gdkEvent1.state, (int) gdkEvent1.x, (int) gdkEvent1.y, false)){
>+			Point scaledEvent = DPIUtil.autoScaleDown(new Point((int)gdkEvent1.x, (int)gdkEvent1.y));
>+			if (sendDragEvent (gdkEvent1.button, gdkEvent1.state, scaledEvent.x, scaledEvent.y, false)){
> 				return 1;
> 		}
> 	}

Actions: View | Diff

Attachments on bug 529327: 272580