Attachment 267217 Details for Bug 513367 – Check that stream is not closed before using decoder

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Check that stream is not closed before using decoder

check closed stream.patch (text/plain), 1.01 KB, created by Andreas Loth

on 2017-03-11 05:51:41 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Loth

Created: 2017-03-11 05:51:41 EST

Size: 1.01 KB

patch

obsolete

>diff --git a/org.eclipse.ui.console/src/org/eclipse/ui/console/IOConsoleOutputStream.java b/org.eclipse.ui.console/src/org/eclipse/ui/console/IOConsoleOutputStream.java
>index 8ee4707..0cba219 100644
>--- a/org.eclipse.ui.console/src/org/eclipse/ui/console/IOConsoleOutputStream.java
>+++ b/org.eclipse.ui.console/src/org/eclipse/ui/console/IOConsoleOutputStream.java
>@@ -199,6 +199,9 @@
>      */
>     @Override
> 	public synchronized void write(byte[] b, int off, int len) throws IOException {
>+		if (closed) {
>+			throw new IOException("Output Stream is closed"); //$NON-NLS-1$
>+		}
> 		StringBuilder builder = new StringBuilder();
> 		this.decoder.decode(builder, b, off, len);
> 		encodedWrite(builder.toString());
>@@ -323,6 +326,9 @@
> 	 * @since 3.7
> 	 */
> 	public synchronized void setCharset(Charset charset) throws IOException {
>+		if (closed) {
>+			throw new IOException("Output Stream is closed"); //$NON-NLS-1$
>+		}
> 		StringBuilder builder = new StringBuilder();
> 		this.decoder.finish(builder);
> 		if (builder.length() > 0) {

Actions: View | Diff

Attachments on bug 513367: 267217 | 267218 | 267466