Attachment 265830 Details for Bug 507701 – Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix

507701_updated_fix.patch (text/plain), 2.14 KB, created by Vikas Chandra

on 2016-12-12 07:59:46 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Vikas Chandra

Created: 2016-12-12 07:59:46 EST

Size: 2.14 KB

patch

obsolete

>diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/comparator/ClassFileComparator.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/comparator/ClassFileComparator.java
>index 7257030..4790310 100644
>--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/comparator/ClassFileComparator.java
>+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/comparator/ClassFileComparator.java
>@@ -2104,6 +2104,18 @@
> 								} else {
> 									int access3 = method3.getModifiers();
> 									if (Flags.isPublic(access3) || Flags.isProtected(access3)) {
>+										IApiAnnotations apiAnnotations = null;
>+										if (apiDescription != null) {
>+											apiAnnotations = apiDescription.resolveAnnotations(method3.getHandle());
>+										}
>+										if (apiAnnotations != null) {
>+											int restrictions = apiAnnotations.getRestrictions();
>+											// if overriding no reference method, break the loop and report method addition
>+											if (RestrictionModifiers.isReferenceRestriction(restrictions)) {
>+												found = false;
>+												break loop;
>+											}
>+										}
> 										// method has been move up in the
> 										// hierarchy - report the delta and
> 										// abort loop
>@@ -2153,6 +2165,21 @@
> 									} else {
> 										int access3 = method3.getModifiers();
> 										if (Flags.isPublic(access3) || Flags.isProtected(access3)) {
>+											IApiAnnotations apiAnnotations = null;
>+											if (apiDescription != null) {
>+												apiAnnotations = apiDescription.resolveAnnotations(method3.getHandle());
>+											}
>+											if (apiAnnotations != null) {
>+												int restrictions = apiAnnotations.getRestrictions();
>+												// if overriding no reference
>+												// method, break the loop and
>+												// report method addition
>+												if (RestrictionModifiers.isReferenceRestriction(restrictions)) {
>+													found = false;
>+													break loop;
>+												}
>+
>+											}
> 											// method has been pushed down in
> 											// the hierarchy - report the delta
> 											// and abort loop

Actions: View | Diff

Attachments on bug 507701: 265830 | 265844