Attachment 26477 Details for Bug 96600 – Patch to "org.eclipse.jface"

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to "org.eclipse.jface"

Bug96600-org.eclipse.jface.patch (text/plain), 1.33 KB, created by Douglas Pollock

on 2005-08-25 15:41:15 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Douglas Pollock

Created: 2005-08-25 15:41:15 EDT

Size: 1.33 KB

patch

obsolete

>Index: src/org/eclipse/jface/bindings/BindingManager.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/bindings/BindingManager.java,v
>retrieving revision 1.18
>diff -u -r1.18 BindingManager.java
>--- src/org/eclipse/jface/bindings/BindingManager.java	12 Aug 2005 19:07:05 -0000	1.18
>+++ src/org/eclipse/jface/bindings/BindingManager.java	25 Aug 2005 19:38:58 -0000
>@@ -520,10 +520,12 @@
> 			// Check the scheme ids.
> 			final String schemeId = binding.getSchemeId();
> 			found = false;
>-			for (int j = 0; j < activeSchemeIds.length; j++) {
>-				if (Util.equals(schemeId, activeSchemeIds[j])) {
>-					found = true;
>-					break;
>+			if (activeSchemeIds != null) {
>+				for (int j = 0; j < activeSchemeIds.length; j++) {
>+					if (Util.equals(schemeId, activeSchemeIds[j])) {
>+						found = true;
>+						break;
>+					}
> 				}
> 			}
> 			if (!found) {
>@@ -1023,8 +1025,8 @@
> 	 * This method completes in <code>O(1)</code>.
> 	 * </p>
> 	 * 
>-	 * @return The array of defined schemes; this value may be empty, but it is
>-	 *         never <code>null</code>.
>+	 * @return The array of defined schemes; this value may be empty, and it may
>+	 *         be <code>null</code>.
> 	 */
> 	public final Scheme[] getDefinedSchemes() {
> 		if ((definedSchemes == null) || (definedSchemeCount == 0)) {

Actions: View | Diff

Attachments on bug 96600: 26476 | 26477 | 26479 | 26556 | 26557 | 26558 | 26561 | 26590 | 26591