Attachment 26460 Details for Bug 2389 – Remove the workarounds

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Remove the workarounds

bug2389-ui.workbench.txt (text/plain), 1.78 KB, created by Paul Webster

on 2005-08-25 13:31:41 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Webster

Created: 2005-08-25 13:31:41 EDT

Size: 1.78 KB

patch

obsolete

>Index: Eclipse UI/org/eclipse/ui/part/MultiPageEditorPart.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/MultiPageEditorPart.java,v
>retrieving revision 1.18
>diff -u -r1.18 MultiPageEditorPart.java
>--- Eclipse UI/org/eclipse/ui/part/MultiPageEditorPart.java	25 Feb 2005 20:52:16 -0000	1.18
>+++ Eclipse UI/org/eclipse/ui/part/MultiPageEditorPart.java	25 Aug 2005 16:55:34 -0000
>@@ -495,12 +495,6 @@
>      * @param newPageIndex the index of the activated page 
>      */
>     protected void pageChange(int newPageIndex) {
>-        // XXX: Workaround for 1GCN531: SWT:WIN2000 - CTabFolder child's visibility is false on notification
>-        Control control = getControl(newPageIndex);
>-        if (control != null) {
>-            control.setVisible(true);
>-        }
>-        // XXX: End workaround
>         setFocus();
>         IEditorPart activeEditor = getEditor(newPageIndex);
>         IEditorActionBarContributor contributor = getEditorSite()
>@@ -511,16 +505,12 @@
>                     .setActivePage(activeEditor);
>         }
>         if (activeEditor != null) {
>-            //Workaround for 1GAUS7C: ITPUI:ALL - Editor not activated when restored from previous session
>-            //do not need second if once fixed
>             ISelectionProvider selectionProvider = activeEditor.getSite()
>                     .getSelectionProvider();
>-            if (selectionProvider != null) {
>                 SelectionChangedEvent event = new SelectionChangedEvent(
>                         selectionProvider, selectionProvider.getSelection());
>                 ((MultiPageSelectionProvider) getSite().getSelectionProvider())
>                         .fireSelectionChanged(event);
>-            }
>         }
>     }
>

Actions: View | Diff

Attachments on bug 2389: 26460