Attachment 263729 Details for Bug 499683 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

499683.patch (text/plain), 1.34 KB, created by Olivier Thomann

on 2016-08-23 12:13:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2016-08-23 12:13:43 EDT

Size: 1.34 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.webtools/web/webtools/cssHover.js b/bundles/org.eclipse.orion.client.webtools/web/webtools/cssHover.js
>index 2b99471..69ce72b 100644
>--- a/bundles/org.eclipse.orion.client.webtools/web/webtools/cssHover.js
>+++ b/bundles/org.eclipse.orion.client.webtools/web/webtools/cssHover.js
>@@ -84,11 +84,22 @@ define([
> 				    if(tok) {
> 				        var color = this._collectColorId(tok, results.tokens);
> 		                if(color) {
>-		                    return this._getColorHover(color);    
>+		                    return this._getColorHover(color);
> 		                }
> 				    }
>-					if (CSSLint.Colors[token.value]){
>-						return this._getColorHover(token.value);
>+				    var colorValue = CSSLint.Colors[token.value];
>+					if (colorValue) {
>+						if (/\#[0-9A-Fa-f]{1,6}/.test(colorValue)){
>+							// this is a color hash not a deprecated css2 color attribute
>+							return this._getColorHover(token.value);
>+						}
>+						// check the next token to see if it is a ':'
>+						// this is a deprecated css2 color attribute
>+						var nextToken = results.tokens[token.index + 1];
>+						if (nextToken && nextToken.type !== 'COLON') {
>+							return this._getColorHover(token.value);
>+						}
>+						return null;
> 					}
> 					if (/\#[0-9A-Fa-f]{1,6}/.test(token.value)){
> 						return this._getColorHover(token.value);

Actions: View | Diff

Attachments on bug 499683: 263601 | 263729