Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
View | Details | Raw Unified | Return to bug 259958 | Differences between
and this patch

Collapse All | Expand All

(-)a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/PreferenceInitializer.java (-1 / +2 lines)
Lines 1-5 Link Here
1
/*******************************************************************************
1
/*******************************************************************************
2
 * Copyright (c) 2005, 2013 IBM Corporation and others.
2
 * Copyright (c) 2005, 2016 IBM Corporation and others.
3
 * All rights reserved. This program and the accompanying materials
3
 * All rights reserved. This program and the accompanying materials
4
 * are made available under the terms of the Eclipse Public License v1.0
4
 * are made available under the terms of the Eclipse Public License v1.0
5
 * which accompanies this distribution, and is available at
5
 * which accompanies this distribution, and is available at
Lines 22-27 Link Here
22
		//set defaults for compiler preferences in org.eclipse.pde pref node, not org.eclipse.pde.core
22
		//set defaults for compiler preferences in org.eclipse.pde pref node, not org.eclipse.pde.core
23
		IEclipsePreferences prefs = DefaultScope.INSTANCE.getNode(PDE.PLUGIN_ID);
23
		IEclipsePreferences prefs = DefaultScope.INSTANCE.getNode(PDE.PLUGIN_ID);
24
		prefs.putInt(CompilerFlags.P_UNRESOLVED_IMPORTS, CompilerFlags.ERROR);
24
		prefs.putInt(CompilerFlags.P_UNRESOLVED_IMPORTS, CompilerFlags.ERROR);
25
		prefs.putInt(CompilerFlags.P_EXPORTED_PACKAGE_MISSING, CompilerFlags.ERROR);
25
		prefs.putInt(CompilerFlags.P_UNRESOLVED_EX_POINTS, CompilerFlags.ERROR);
26
		prefs.putInt(CompilerFlags.P_UNRESOLVED_EX_POINTS, CompilerFlags.ERROR);
26
		prefs.putInt(CompilerFlags.P_NO_REQUIRED_ATT, CompilerFlags.ERROR);
27
		prefs.putInt(CompilerFlags.P_NO_REQUIRED_ATT, CompilerFlags.ERROR);
27
		prefs.putInt(CompilerFlags.P_UNKNOWN_ELEMENT, CompilerFlags.WARNING);
28
		prefs.putInt(CompilerFlags.P_UNKNOWN_ELEMENT, CompilerFlags.WARNING);
(-)a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/BundleErrorReporter.java (-1 / +3 lines)
Lines 882-888 Link Here
882
				/* The exported package does not exist in the bundle.  Allow project folders to be packages (see bug 166680 comment 17)*/
882
				/* The exported package does not exist in the bundle.  Allow project folders to be packages (see bug 166680 comment 17)*/
883
				if (!getExportedPackages().contains(name) && !(fProject.getFolder(name.replace('.', '/')).exists())) {
883
				if (!getExportedPackages().contains(name) && !(fProject.getFolder(name.replace('.', '/')).exists())) {
884
					message = NLS.bind(PDECoreMessages.BundleErrorReporter_NotExistInProject, name);
884
					message = NLS.bind(PDECoreMessages.BundleErrorReporter_NotExistInProject, name);
885
					IMarker marker = report(message, getPackageLine(header, elements[i]), CompilerFlags.P_UNRESOLVED_IMPORTS, PDEMarkerFactory.M_EXPORT_PKG_NOT_EXIST, PDEMarkerFactory.CAT_OTHER);
885
					IMarker marker = report(message, getPackageLine(header, elements[i]),
886
							CompilerFlags.P_EXPORTED_PACKAGE_MISSING, PDEMarkerFactory.M_EXPORT_PKG_NOT_EXIST,
887
							PDEMarkerFactory.CAT_OTHER);
886
					addMarkerAttribute(marker, "packageName", name); //$NON-NLS-1$
888
					addMarkerAttribute(marker, "packageName", name); //$NON-NLS-1$
887
				}
889
				}
888
			}
890
			}
(-)a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/CompilerFlags.java (-1 / +2 lines)
Lines 1-5 Link Here
1
/*******************************************************************************
1
/*******************************************************************************
2
 * Copyright (c) 2000, 2013 IBM Corporation and others.
2
 * Copyright (c) 2000, 2016 IBM Corporation and others.
3
 * All rights reserved. This program and the accompanying materials
3
 * All rights reserved. This program and the accompanying materials
4
 * are made available under the terms of the Eclipse Public License v1.0
4
 * are made available under the terms of the Eclipse Public License v1.0
5
 * which accompanies this distribution, and is available at
5
 * which accompanies this distribution, and is available at
Lines 44-49 Link Here
44
	 * plugin preferences
44
	 * plugin preferences
45
	 */
45
	 */
46
	public static final String P_UNRESOLVED_IMPORTS = "compilers.p.unresolved-import"; //$NON-NLS-1$
46
	public static final String P_UNRESOLVED_IMPORTS = "compilers.p.unresolved-import"; //$NON-NLS-1$
47
	public static final String P_EXPORTED_PACKAGE_MISSING = "compilers.p.exported-package-missing"; //$NON-NLS-1$
47
	public static final String P_UNRESOLVED_EX_POINTS = "compilers.p.unresolved-ex-points"; //$NON-NLS-1$
48
	public static final String P_UNRESOLVED_EX_POINTS = "compilers.p.unresolved-ex-points"; //$NON-NLS-1$
48
	public static final String P_UNKNOWN_ELEMENT = "compilers.p.unknown-element"; //$NON-NLS-1$
49
	public static final String P_UNKNOWN_ELEMENT = "compilers.p.unknown-element"; //$NON-NLS-1$
49
	public static final String P_UNKNOWN_ATTRIBUTE = "compilers.p.unknown-attribute"; //$NON-NLS-1$
50
	public static final String P_UNKNOWN_ATTRIBUTE = "compilers.p.unknown-attribute"; //$NON-NLS-1$
(-)a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java (+1 lines)
Lines 1685-1690 Link Here
1685
	public static String CompilersPropertyPage_useprojectsettings_label;
1685
	public static String CompilersPropertyPage_useprojectsettings_label;
1686
1686
1687
	public static String compilers_p_unresolved_import;
1687
	public static String compilers_p_unresolved_import;
1688
	public static String compilers_p_export_package_missing_in_plugin;
1688
	public static String compilers_p_unresolved_ex_points;
1689
	public static String compilers_p_unresolved_ex_points;
1689
	public static String compilers_p_unknown_element;
1690
	public static String compilers_p_unknown_element;
1690
	public static String compilers_p_unknown_attribute;
1691
	public static String compilers_p_unknown_attribute;
(-)a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties (-1 / +2 lines)
Lines 1490-1495 Link Here
1490
CompilersPropertyPage_useprojectsettings_label = E&nable project specific settings
1490
CompilersPropertyPage_useprojectsettings_label = E&nable project specific settings
1491
1491
1492
compilers_p_unresolved_import= U&nresolved dependencies:
1492
compilers_p_unresolved_import= U&nresolved dependencies:
1493
compilers_p_export_package_missing_in_plugin= Exported packages &missing:
1493
compilers_p_unresolved_ex_points= Un&resolved extension points:
1494
compilers_p_unresolved_ex_points= Un&resolved extension points:
1494
compilers_p_unknown_element= Ille&gal elements:
1495
compilers_p_unknown_element= Ille&gal elements:
1495
compilers_p_unknown_attribute=&Illegal attributes:
1496
compilers_p_unknown_attribute=&Illegal attributes:
Lines 1501-1507 Link Here
1501
compilers_p_not_externalized_att = Usage of non-externali&zed strings:
1502
compilers_p_not_externalized_att = Usage of non-externali&zed strings:
1502
compilers_p_deprecated = Usage of deprecated attributes and &elements:
1503
compilers_p_deprecated = Usage of deprecated attributes and &elements:
1503
compilers_p_internal = Usage o&f internal extension points:
1504
compilers_p_internal = Usage o&f internal extension points:
1504
compilers_p_exported_pkgs = Missing exported pac&kages:
1505
compilers_p_exported_pkgs = Unexported pac&kages:
1505
compilers_p_missing_exp_pkg = Missing versions on exported packages:
1506
compilers_p_missing_exp_pkg = Missing versions on exported packages:
1506
compilers_p_missing_imp_pkg = Missing versions on imported packages:
1507
compilers_p_missing_imp_pkg = Missing versions on imported packages:
1507
compilers_p_missing_require_bundle = Missing versions on required bundles:
1508
compilers_p_missing_require_bundle = Missing versions on required bundles:
(-)a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/preferences/PDECompilersConfigurationBlock.java (-1 / +11 lines)
Lines 184-189 Link Here
184
184
185
	//unresolved
185
	//unresolved
186
	private static final Key KEY_P_UNRESOLVED_IMPORTS = getPDEPrefKey(CompilerFlags.P_UNRESOLVED_IMPORTS);
186
	private static final Key KEY_P_UNRESOLVED_IMPORTS = getPDEPrefKey(CompilerFlags.P_UNRESOLVED_IMPORTS);
187
	private static final Key KEY_P_EXPORTED_PACKAGE_MISSING = getPDEPrefKey(
188
			CompilerFlags.P_EXPORTED_PACKAGE_MISSING);
187
	private static final Key KEY_P_UNRESOLVED_EX_POINTS = getPDEPrefKey(CompilerFlags.P_UNRESOLVED_EX_POINTS);
189
	private static final Key KEY_P_UNRESOLVED_EX_POINTS = getPDEPrefKey(CompilerFlags.P_UNRESOLVED_EX_POINTS);
188
	private static final Key KEY_F_UNRESOLVED_PLUGINS = getPDEPrefKey(CompilerFlags.F_UNRESOLVED_PLUGINS);
190
	private static final Key KEY_F_UNRESOLVED_PLUGINS = getPDEPrefKey(CompilerFlags.F_UNRESOLVED_PLUGINS);
189
	private static final Key KEY_F_UNRESOLVED_FEATURES = getPDEPrefKey(CompilerFlags.F_UNRESOLVED_FEATURES);
191
	private static final Key KEY_F_UNRESOLVED_FEATURES = getPDEPrefKey(CompilerFlags.F_UNRESOLVED_FEATURES);
Lines 527-533 Link Here
527
				initializeComboControls(client, new String[] {PDEUIMessages.compilers_p_missing_require_bundle, PDEUIMessages.compilers_p_missing_exp_pkg, PDEUIMessages.compilers_p_missing_imp_pkg}, new Key[] {KEY_P_VERSION_REQ_BUNDLE, KEY_P_VERSION_EXP_PKG, KEY_P_VERSION_IMP_PKG}, CompilerFlags.PLUGIN_FLAGS);
529
				initializeComboControls(client, new String[] {PDEUIMessages.compilers_p_missing_require_bundle, PDEUIMessages.compilers_p_missing_exp_pkg, PDEUIMessages.compilers_p_missing_imp_pkg}, new Key[] {KEY_P_VERSION_REQ_BUNDLE, KEY_P_VERSION_EXP_PKG, KEY_P_VERSION_IMP_PKG}, CompilerFlags.PLUGIN_FLAGS);
528
				// Usage
530
				// Usage
529
				client = createExpansibleComposite(sbody, PDEUIMessages.PDECompilersConfigurationBlock_usage);
531
				client = createExpansibleComposite(sbody, PDEUIMessages.PDECompilersConfigurationBlock_usage);
530
				initializeComboControls(client, new String[] {PDEUIMessages.compilers_p_unresolved_import, PDEUIMessages.compilers_p_unresolved_ex_points, PDEUIMessages.compilers_p_internal, PDEUIMessages.compilers_p_deprecated, PDEUIMessages.compilers_p_not_externalized_att}, new Key[] {KEY_P_UNRESOLVED_IMPORTS, KEY_P_UNRESOLVED_EX_POINTS, KEY_P_INTERNAL, KEY_P_DEPRECATED, KEY_P_NOT_EXTERNALIZED}, CompilerFlags.PLUGIN_FLAGS);
532
			initializeComboControls(client,
533
					new String[] { PDEUIMessages.compilers_p_unresolved_import,
534
							PDEUIMessages.compilers_p_export_package_missing_in_plugin,
535
							PDEUIMessages.compilers_p_unresolved_ex_points, PDEUIMessages.compilers_p_internal,
536
							PDEUIMessages.compilers_p_deprecated, PDEUIMessages.compilers_p_not_externalized_att },
537
					new Key[] { KEY_P_UNRESOLVED_IMPORTS, KEY_P_EXPORTED_PACKAGE_MISSING, KEY_P_UNRESOLVED_EX_POINTS,
538
							KEY_P_INTERNAL, KEY_P_DEPRECATED,
539
							KEY_P_NOT_EXTERNALIZED },
540
					CompilerFlags.PLUGIN_FLAGS);
531
				// References
541
				// References
532
				client = createExpansibleComposite(sbody, PDEUIMessages.PDECompilersConfigurationBlock_references);
542
				client = createExpansibleComposite(sbody, PDEUIMessages.PDECompilersConfigurationBlock_references);
533
				initializeComboControls(client, new String[] {PDEUIMessages.compilers_p_unknown_element, PDEUIMessages.compilers_p_unknown_attribute, PDEUIMessages.compilers_p_unknown_class, PDEUIMessages.compilers_p_discouraged_class, PDEUIMessages.compilers_p_unknown_resource, PDEUIMessages.compilers_p_unknown_identifier}, new Key[] {KEY_P_UNKNOWN_ELEMENT, KEY_P_UNKNOWN_ATTRIBUTE, KEY_P_UNKNOWN_CLASS, KEY_P_DISCOURAGED_CLASS, KEY_P_UNKNOWN_RESOURCE, KEY_P_UNKNOWN_IDENTIFIER,}, CompilerFlags.PLUGIN_FLAGS);
543
				initializeComboControls(client, new String[] {PDEUIMessages.compilers_p_unknown_element, PDEUIMessages.compilers_p_unknown_attribute, PDEUIMessages.compilers_p_unknown_class, PDEUIMessages.compilers_p_discouraged_class, PDEUIMessages.compilers_p_unknown_resource, PDEUIMessages.compilers_p_unknown_identifier}, new Key[] {KEY_P_UNKNOWN_ELEMENT, KEY_P_UNKNOWN_ATTRIBUTE, KEY_P_UNKNOWN_CLASS, KEY_P_DISCOURAGED_CLASS, KEY_P_UNKNOWN_RESOURCE, KEY_P_UNKNOWN_IDENTIFIER,}, CompilerFlags.PLUGIN_FLAGS);

Return to bug 259958