Attachment 262518 Details for Bug 496313 – Proposed patch including regression tests

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch including regression tests

changes (1).patch (text/plain), 2.68 KB, created by Olivier Thomann

on 2016-06-17 13:43:42 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2016-06-17 13:43:42 EDT

Size: 2.68 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.javascript/web/eslint/lib/load-rules-async.js b/bundles/org.eclipse.orion.client.javascript/web/eslint/lib/load-rules-async.js
>index d32f874..2e0fa73 100644
>--- a/bundles/org.eclipse.orion.client.javascript/web/eslint/lib/load-rules-async.js
>+++ b/bundles/org.eclipse.orion.client.javascript/web/eslint/lib/load-rules-async.js
>@@ -1366,14 +1366,17 @@ define([
>         },
>         /** @callback */
>         'no-undef-expression': function(context){
>-        	return {
>-        		/* @callback */
>-        		'MemberExpression': function(node){
>-                	if (node.property && node.object && node.object.type !== 'ThisExpression'){
>-                		if (node.parent && node.parent.type === 'CallExpression' && node.parent.callee && node.parent.callee === node){
>-                			var tern = context.getTern();
>-                			var propName = node.property.name ? node.property.name : node.property.value;
>+			return {
>+				/* @callback */
>+				'MemberExpression': function(node){
>+					if (node.property && node.object && node.object.type !== 'ThisExpression'){
>+						if (node.parent && node.parent.type === 'CallExpression' && node.parent.callee && node.parent.callee === node){
>+							var propName = node.property.name ? node.property.name : node.property.value;
>+							if (!propName) {
>+								return;
>+							}
> 							var query = {start: node.property.start, end: node.property.end};
>+							var tern = context.getTern();
> 							var expr = tern.findQueryExpr(tern.file, query);
> 							if (!expr) {
> 								// no expression found. No need to look for the type
>diff --git a/bundles/org.eclipse.orion.client.javascript/web/js-tests/javascript/validatorTests.js b/bundles/org.eclipse.orion.client.javascript/web/js-tests/javascript/validatorTests.js
>index 9d61d62..3b13cda 100644
>--- a/bundles/org.eclipse.orion.client.javascript/web/js-tests/javascript/validatorTests.js
>+++ b/bundles/org.eclipse.orion.client.javascript/web/js-tests/javascript/validatorTests.js
>@@ -8559,6 +8559,19 @@ define([
> 								}
> 							);
> 						});
>+						it("Should not flag array access using a binary expression", function(callback) {
>+							var topic = "var funcs = [], i = 5; return funcs[i - 1]();";
>+							var config = { rules: {} };
>+							config.rules[RULE_ID] = 1;
>+							validate({buffer: topic, callback: callback, config: config}).then(
>+								function (problems) {
>+									assertProblems(problems, [
>+									]);
>+								},
>+								function (error) {
>+									worker.getTestState().callback(error);
>+								});
>+						});
> 					});
> 					//NO-UNDEF-INIT -------------------------------------------------
> 					describe('no-unreachable', function() {

Actions: View | Diff

Attachments on bug 496313: 262518