Attachment 26211 Details for Bug 96893 – proposed 3.1.1 patch - name gets set to product ID if it is not filled in by user

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed 3.1.1 patch - name gets set to product ID if it is not filled in by user

org.eclipse.pde.ui_b#96893_patch-R3_1_maintenance.txt (text/plain), 1.87 KB, created by Janek Lasocki-Biczysko

on 2005-08-17 15:20:21 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Janek Lasocki-Biczysko

Created: 2005-08-17 15:20:21 EDT

Size: 1.87 KB

patch

obsolete

>Index: src/org/eclipse/pde/internal/ui/editor/product/ProductInfoSection.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/product/ProductInfoSection.java,v
>retrieving revision 1.21
>diff -u -r1.21 ProductInfoSection.java
>--- src/org/eclipse/pde/internal/ui/editor/product/ProductInfoSection.java	19 May 2005 23:02:46 -0000	1.21
>+++ src/org/eclipse/pde/internal/ui/editor/product/ProductInfoSection.java	17 Aug 2005 19:17:42 -0000
>@@ -141,12 +141,14 @@
> 		dialog.create();
> 		if (dialog.open() == WizardDialog.OK) {
> 			String id = wizard.getProductId();
>+			IProduct product = getProduct();
> 			fProductCombo.add(id, 0);
> 			fProductCombo.setText(id);
>-			getProduct().setId(id);
>+			product.setId(id);
> 			String app = wizard.getApplication();
> 			fAppCombo.setText(app);
>-			getProduct().setApplication(app);
>+			product.setApplication(app);
>+			fNameEntry.setValue(product.getName());
> 		}
> 	}
> 
>Index: src/org/eclipse/pde/internal/ui/wizards/product/ProductDefinitionWizard.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/product/ProductDefinitionWizard.java,v
>retrieving revision 1.5
>diff -u -r1.5 ProductDefinitionWizard.java
>--- src/org/eclipse/pde/internal/ui/wizards/product/ProductDefinitionWizard.java	9 Apr 2005 01:53:43 -0000	1.5
>+++ src/org/eclipse/pde/internal/ui/wizards/product/ProductDefinitionWizard.java	17 Aug 2005 19:17:42 -0000
>@@ -42,6 +42,8 @@
> 			fProductId = fMainPage.getProductId();
> 			fPluginId = fMainPage.getDefiningPlugin();
> 			fApplication = fMainPage.getApplication();
>+			if (fProduct.getName() == null || fProduct.getName().equals(""))
>+				fProduct.setName(fProductId);
> 			getContainer().run(
> 					false,
> 					true,

Actions: View | Diff

Attachments on bug 96893: 26211 | 26217