Attachment 259447 Details for Bug 483591 – Patch to fix issue mentioned above.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to fix issue mentioned above.

patch_over_gerrit_change.patch (text/plain), 1.59 KB, created by Vikas Chandra

on 2016-01-29 06:37:30 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Vikas Chandra

Created: 2016-01-29 06:37:30 EST

Size: 1.59 KB

patch

obsolete

>diff --git a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/comparator/ClassFileComparator.java b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/comparator/ClassFileComparator.java
>index 9bb888a..04dfbd2 100644
>--- a/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/comparator/ClassFileComparator.java
>+++ b/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/comparator/ClassFileComparator.java
>@@ -1222,7 +1222,7 @@
> 				}
> 				return;
> 			}
>-			if ((Flags.isPrivate(access) || Util.isDefault(access)) && (Flags.isPrivate(access2) || Util.isDefault(access2))) {
>+			if ((Flags.isPrivate(access) || Util.isDefault(access) || (Flags.isProtected(access) && RestrictionModifiers.isExtendRestriction(this.currentDescriptorRestrictions))) && (Flags.isPrivate(access2) || Util.isDefault(access2) || (Flags.isProtected(access2) && RestrictionModifiers.isExtendRestriction(this.currentDescriptorRestrictions)))) {
> 				// don't report non-API deltas
> 				return;
> 			}
>@@ -1590,7 +1590,7 @@
> 					return;
> 				}
> 			}
>-			if ((Flags.isPrivate(access) || Util.isDefault(access)) && (Flags.isPrivate(access2) || Util.isDefault(access2))) {
>+			if ((Flags.isPrivate(access) || Util.isDefault(access) || (Flags.isProtected(access) && RestrictionModifiers.isExtendRestriction(this.currentDescriptorRestrictions))) && (Flags.isPrivate(access2) || Util.isDefault(access2) || (Flags.isProtected(access2) && RestrictionModifiers.isExtendRestriction(this.currentDescriptorRestrictions)))) {
> 				// don't report non-API deltas
> 				return;
> 			}

Actions: View | Diff

Attachments on bug 483591: 259447