Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 257624 Details for
Bug 480998
Crash when tabbing through View parts with contribution items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
[patch]
Proposed fix: test if _hoverItem has a _onKeyDown / _onKeyUp function before calling it
fix.patch (text/plain), 853 bytes, created by
Martin Domig
on 2015-10-29 09:55:39 EDT
(
hide
)
Description:
Proposed fix: test if _hoverItem has a _onKeyDown / _onKeyUp function before calling it
Filename:
MIME Type:
Creator:
Martin Domig
Created:
2015-10-29 09:55:39 EDT
Size:
853 bytes
patch
obsolete
>diff --git a/bundles/org.eclipse.rap.rwt/js/rwt/widgets/ToolBar.js b/bundles/org.eclipse.rap.rwt/js/rwt/widgets/ToolBar.js >index da0c29d..b5c56d9 100644 >--- a/bundles/org.eclipse.rap.rwt/js/rwt/widgets/ToolBar.js >+++ b/bundles/org.eclipse.rap.rwt/js/rwt/widgets/ToolBar.js >@@ -94,13 +94,13 @@ > }, > > _onKeyDown : function( event ) { >- if( this._hoverItem != null && this._isRelevantEvent( event ) ) { >+ if( this._hoverItem != null && this._isRelevantEvent( event ) && this._hoverItem._onKeyDown ) { > this._hoverItem._onKeyDown( event ); > } > }, > > _onKeyUp : function( event ) { >- if( this._hoverItem != null && this._isRelevantEvent( event ) ) { >+ if( this._hoverItem != null && this._isRelevantEvent( event ) && this._hoverItem._onKeyUp ) { > this._hoverItem._onKeyUp( event ); > } > },
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=257624">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 480998
:
257623
| 257624
