Attachment 256461 Details for Bug 476961 – Simple patch to fix the client crash

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Simple patch to fix the client crash

0001-DnD-with-UI-feedback-can-crash-the-client.patch (text/plain), 1.10 KB, created by Martin Domig

on 2015-09-09 08:44:40 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Domig

Created: 2015-09-09 08:44:40 EDT

Size: 1.10 KB

patch

obsolete

>From 1edfeb8636a7be366bb43fbc4e0c445a714a23f2 Mon Sep 17 00:00:00 2001
>From: Martin Domig <martin.domig@finkzeit.at>
>Date: Wed, 9 Sep 2015 14:42:37 +0200
>Subject: [PATCH] DnD with UI feedback can crash the client.
>
>Proposed fix for bug 476961
>---
> bundles/org.eclipse.rap.rwt/js/rwt/widgets/util/GridDNDFeedback.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/bundles/org.eclipse.rap.rwt/js/rwt/widgets/util/GridDNDFeedback.js b/bundles/org.eclipse.rap.rwt/js/rwt/widgets/util/GridDNDFeedback.js
>index 48014c6..692013f 100644
>--- a/bundles/org.eclipse.rap.rwt/js/rwt/widgets/util/GridDNDFeedback.js
>+++ b/bundles/org.eclipse.rap.rwt/js/rwt/widgets/util/GridDNDFeedback.js
>@@ -137,7 +137,7 @@ rwt.qx.Class.define( "rwt.widgets.util.GridDNDFeedback", {
>       var location = { x : 0, y : 0 };
>       var node = row.$el.get( 0 );
>       var treeNode = this._tree._getTargetNode();
>-      while( node != treeNode ) {
>+      while( node != null && node != treeNode ) {
>         location.x += node.offsetLeft;
>         location.y += node.offsetTop;
>         node = node.parentNode;
>-- 
>2.3.2 (Apple Git-55)
>

Actions: View | Diff

Attachments on bug 476961: 256460 | 256461 | 256493 | 256494