Attachment 256117 Details for Bug 475857 – Additional checks for isDisposed()

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Additional checks for isDisposed()

0001-dispose-check.patch (text/plain), 1.92 KB, created by Frank Jakop

on 2015-08-26 02:20:57 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Jakop

Created: 2015-08-26 02:20:57 EDT

Size: 1.92 KB

patch

obsolete

>From e11811f77fa20567fdef57b85dadf1d7e546ef6e Mon Sep 17 00:00:00 2001
>From: Daniel Ebert <daniel.ebert@tolina.de>
>Date: Tue, 25 Aug 2015 18:02:05 +0200
>Subject: [PATCH] =?UTF-8?q?2=20durch=20Supportf=C3=A4lle=20bekannte=20Widg?=
> =?UTF-8?q?etIsDisposed=20Probleme=20behoben?=
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>---
> .../src/org/eclipse/swt/internal/widgets/ProgressCollector.java       | 4 +++-
> .../src/org/eclipse/swt/internal/widgets/UploaderWidget.java          | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/org.eclipse.rap.addons.filedialog/src/org/eclipse/swt/internal/widgets/ProgressCollector.java b/org.eclipse.rap.addons.filedialog/src/org/eclipse/swt/internal/widgets/ProgressCollector.java
>index c69b215..c858b2b 100644
>--- a/org.eclipse.rap.addons.filedialog/src/org/eclipse/swt/internal/widgets/ProgressCollector.java
>+++ b/org.eclipse.rap.addons.filedialog/src/org/eclipse/swt/internal/widgets/ProgressCollector.java
>@@ -56,7 +56,9 @@ public class ProgressCollector extends Composite {
>   }
> 
>   void resetToolTip() {
>-    progressBar.setToolTipText( null );
>+    if( !isDisposed() ) {
>+      progressBar.setToolTipText( null );
>+    }
>   }
> 
> }
>diff --git a/org.eclipse.rap.addons.filedialog/src/org/eclipse/swt/internal/widgets/UploaderWidget.java b/org.eclipse.rap.addons.filedialog/src/org/eclipse/swt/internal/widgets/UploaderWidget.java
>index 6874fbf..5ac2cdd 100644
>--- a/org.eclipse.rap.addons.filedialog/src/org/eclipse/swt/internal/widgets/UploaderWidget.java
>+++ b/org.eclipse.rap.addons.filedialog/src/org/eclipse/swt/internal/widgets/UploaderWidget.java
>@@ -27,7 +27,7 @@ public class UploaderWidget implements Uploader {
>   }
> 
>   public void dispose() {
>-    if( ( fileUpload.getStyle() & SWT.MULTI ) != 0 ) {
>+    if(!fileUpload.isDisposed() && ( fileUpload.getStyle() & SWT.MULTI ) != 0 ) {
>       fileUpload.dispose();
>     }
>   }
>-- 
>1.8.4.msysgit.0
>

Actions: View | Diff

Attachments on bug 475857: 256117