Attachment 256004 Details for Bug 461083 – Another fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Another fix

461083_another_fix.patch (text/plain), 2.20 KB, created by Vikas Chandra

on 2015-08-21 04:59:16 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Vikas Chandra

Created: 2015-08-21 04:59:16 EDT

Size: 2.20 KB

patch

obsolete

>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/shared/target/TargetLocationsGroup.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/shared/target/TargetLocationsGroup.java
>index 7c7b0c2..4fa198c 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/shared/target/TargetLocationsGroup.java
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/shared/target/TargetLocationsGroup.java
>@@ -324,7 +324,7 @@
> 			Object currentSelection = iterator.next();
> 			if (currentSelection instanceof ITargetLocation) {
> 				ITargetLocation location = (ITargetLocation) currentSelection;
>-				ITargetLocationEditor editor = (ITargetLocationEditor) Platform.getAdapterManager().getAdapter(location, ITargetLocationEditor.class);
>+				ITargetLocationEditor editor = Platform.getAdapterManager().getAdapter(location, ITargetLocationEditor.class);
> 				if (editor != null) {
> 					if (editor.canEdit(fTarget, location)) {
> 						IWizard editWizard = editor.getEditWizard(fTarget, location);
>@@ -510,7 +510,7 @@
> 				canRemove = true;
> 				if (!canEdit) {
> 					ITargetLocation location = (ITargetLocation) currentSelection;
>-					ITargetLocationEditor editor = (ITargetLocationEditor) Platform.getAdapterManager().getAdapter(location, ITargetLocationEditor.class);
>+					ITargetLocationEditor editor = Platform.getAdapterManager().getAdapter(location, ITargetLocationEditor.class);
> 					if (editor != null) {
> 						canEdit = editor.canEdit(fTarget, location);
> 					}
>@@ -521,7 +521,7 @@
> 				}
> 				if (!canUpdate) {
> 					ITargetLocation location = (ITargetLocation) currentSelection;
>-					ITargetLocationUpdater updater = (ITargetLocationUpdater) Platform.getAdapterManager().getAdapter(location, ITargetLocationUpdater.class);
>+					ITargetLocationUpdater updater = Platform.getAdapterManager().getAdapter(location, ITargetLocationUpdater.class);
> 					if (updater != null) {
> 						canUpdate = updater.canUpdate(fTarget, location);
> 					}
>@@ -539,7 +539,7 @@
> 
> 		}
> 		fRemoveButton.setEnabled(canRemove);
>-		fEditButton.setEnabled(canEdit);
>+		fEditButton.setEnabled(canEdit && fTarget.isResolved());
> 		fUpdateButton.setEnabled(canUpdate);
> 
> 		// TODO Some code to find the parent location of items in the tree

Actions: View | Diff

Attachments on bug 461083: 255984 | 256004