Attachment 255715 Details for Bug 474516 – patch to fix font size and colors

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

patch to fix font size and colors

bug474516.patch.txt (text/plain), 1.60 KB, created by Carolyn MacLeod

on 2015-08-07 16:56:23 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carolyn MacLeod

Created: 2015-08-07 16:56:23 EDT

Size: 1.60 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/widgets/themes/ThemeBuilder.js b/bundles/org.eclipse.orion.client.ui/web/orion/widgets/themes/ThemeBuilder.js
>index aa07bf2..1a3027e 100644
>--- a/bundles/org.eclipse.orion.client.ui/web/orion/widgets/themes/ThemeBuilder.js
>+++ b/bundles/org.eclipse.orion.client.ui/web/orion/widgets/themes/ThemeBuilder.js
>@@ -337,7 +337,7 @@
> 
> 		for (var i = 0; i < scopeList.length; i++){
> 			if (scopeList[i].id === "editorThemeFontSize"){
>-				htmlString = htmlString + "<li><span>" + scopeList[i].display + "</span><select id='editorThemeFontSize'>";
>+				htmlString = htmlString + "<li><label for='editorThemeFontSize'>" + scopeList[i].display + "</label><select id='editorThemeFontSize'>";
> 				for (var l = 8; l < 19; l++){
> 					htmlString = htmlString + "<option value='" + l+"px'>"+l+"px</option>";
> 				}
>@@ -348,7 +348,7 @@
> 			}
> 			else {
> 				var hideValueCSS = hiddenValues.indexOf(scopeList[i].id) >= 0 ? "style='display: none'" : ""; //$NON-NLS-0$
>-				htmlString = htmlString + "<li " + hideValueCSS + "><span>" + scopeList[i].display + "</span><input id='"+scopeList[i].id+"' class='colorpicker-input" + ieClass + "' type='color' value='" + scopeList[i].value + "'></li>";//$NON-NLS-3$ //$NON-NLS-2$ //$NON-NLS-1$ //$NON-NLS-0$
>+				htmlString = htmlString + "<li " + hideValueCSS + "><label for='"+scopeList[i].id+"'>" + scopeList[i].display + "</label><input id='"+scopeList[i].id+"' class='colorpicker-input" + ieClass + "' type='color' value='" + scopeList[i].value + "'></li>";//$NON-NLS-3$ //$NON-NLS-2$ //$NON-NLS-1$ //$NON-NLS-0$
> 			}
> 		}
> 		return htmlString;

Actions: View

Attachments on bug 474516: 255715