Attachment 251896 Details for Bug 400670 – Patch - to prevent toggle on save when formatter is applied on all lines

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch - to prevent toggle on save when formatter is applied on all lines

toggleOnSave.patch (text/plain), 1.23 KB, created by Noopur Gupta

on 2015-03-25 08:34:30 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Noopur Gupta

Created: 2015-03-25 08:34:30 EDT

Size: 1.23 KB

patch

obsolete

>diff --git a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CodeFormatFix.java b/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CodeFormatFix.java
>index 5e1b31a..d30bcf2 100644
>--- a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CodeFormatFix.java
>+++ b/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CodeFormatFix.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2013 IBM Corporation and others.
>+ * Copyright (c) 2000, 2015 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -137,7 +137,8 @@
> 					}
> 				}
> 
>-				if (correctIndentation) {
>+				// Don't apply correct indentation if already formatting all lines
>+				if (correctIndentation && (!format || regions != null)) {
> 					JavaPlugin.getDefault().getJavaTextTools().setupJavaDocumentPartitioner(document, IJavaPartitions.JAVA_PARTITIONING);
> 					TextEdit edit= IndentAction.indent(document, cu.getJavaProject());
> 					if (edit != null) {

Actions: View | Diff

Attachments on bug 400670: 226996 | 251894 | 251896 | 252004 | 252035 | 252631