Attachment 246955 Details for Bug 361123 – Proposed Patch for Bug 361123

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed Patch for Bug 361123

eclipse.pde.ui.patch (text/plain), 7.53 KB, created by Himanshu Mishra

on 2014-09-11 08:04:08 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Himanshu Mishra

Created: 2014-09-11 08:04:08 EDT

Size: 7.53 KB

patch

obsolete

>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java
>index b676b22..b214d74 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java
>@@ -1439,6 +1439,7 @@
> 	public static String EditorActions_cut;
> 	public static String EditorActions_copy;
> 	public static String EditorActions_paste;
>+	public static String EditorActions_selectall;
> 	public static String EditorActions_revert;
> 	public static String Actions_open_label;
> 	public static String Actions_delete_label;
>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/PDEFormEditorContributor.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/PDEFormEditorContributor.java
>index 395ea11..7ee6a75 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/PDEFormEditorContributor.java
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/PDEFormEditorContributor.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2003, 2012 IBM Corporation and others.
>+ * Copyright (c) 2003, 2014 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -10,8 +10,6 @@
>  *     Joern Dinkla <devnull@dinkla.com> - bug 197821
>  *******************************************************************************/
> package org.eclipse.pde.internal.ui.editor;
>-
>-import org.eclipse.jface.action.Action;
> 
> import java.util.Hashtable;
> import org.eclipse.jface.action.*;
>@@ -42,6 +40,8 @@
> 	private ClipboardAction fCopyAction;
> 
> 	private ClipboardAction fPasteAction;
>+
>+	private SelectAllAction fSelectAllAction;
> 
> 	private Hashtable<String, Action> fGlobalActions = new Hashtable<String, Action>();
> 
>@@ -123,6 +123,15 @@
> 		}
> 	}
> 
>+	class SelectAllAction extends ClipboardAction {
>+		public SelectAllAction() {
>+			super(ActionFactory.SELECT_ALL.getId());
>+			setText(PDEUIMessages.EditorActions_selectall);
>+			setActionDefinitionId(ActionFactory.SELECT_ALL.getCommandId());
>+			setEnabled(true);
>+		}
>+	}
>+
> 	class SaveAction extends Action implements IUpdate {
> 		public SaveAction() {
> 		}
>@@ -168,6 +177,8 @@
> 		mng.add(fCutAction);
> 		mng.add(fCopyAction);
> 		mng.add(fPasteAction);
>+		mng.add(new Separator());
>+		mng.add(fSelectAllAction);
> 		mng.add(new Separator());
> 		mng.add(fRevertAction);
> 	}
>@@ -221,6 +232,7 @@
> 		fCutAction = new CutAction();
> 		fCopyAction = new CopyAction();
> 		fPasteAction = new PasteAction();
>+		fSelectAllAction = new SelectAllAction();
> 		addGlobalAction(ActionFactory.CUT.getId(), fCutAction);
> 		addGlobalAction(ActionFactory.COPY.getId(), fCopyAction);
> 		addGlobalAction(ActionFactory.PASTE.getId(), fPasteAction);
>@@ -229,7 +241,7 @@
> 		addGlobalAction(ActionFactory.UNDO.getId());
> 		addGlobalAction(ActionFactory.REDO.getId());
> 		// select/find
>-		addGlobalAction(ActionFactory.SELECT_ALL.getId());
>+		addGlobalAction(ActionFactory.SELECT_ALL.getId(), fSelectAllAction);
> 		addGlobalAction(ActionFactory.FIND.getId());
> 		// bookmark
> 		addGlobalAction(IDEActionFactory.BOOKMARK.getId());
>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/feature/InfoSection.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/feature/InfoSection.java
>index 6fcf90c..dc498bd 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/feature/InfoSection.java
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/feature/InfoSection.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- *  Copyright (c) 2000, 2010 IBM Corporation and others.
>+ *  Copyright (c) 2000, 2014 IBM Corporation and others.
>  *  All rights reserved. This program and the accompanying materials
>  *  are made available under the terms of the Eclipse Public License v1.0
>  *  which accompanies this distribution, and is available at
>@@ -248,6 +248,8 @@
> 		} else if (actionId.equals(ActionFactory.REDO.getId())) {
> 			fSourceViewer.doOperation(ITextOperationTarget.REDO);
> 			return true;
>+		} else if (actionId.equals(ActionFactory.SELECT_ALL.getId())) {
>+			fSourceViewer.doOperation(ITextOperationTarget.SELECT_ALL);
> 		}
> 		return false;
> 	}
>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/feature/LicenseFeatureSection.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/feature/LicenseFeatureSection.java
>index d319178..2f030f3 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/feature/LicenseFeatureSection.java
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/feature/LicenseFeatureSection.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- *  Copyright (c) 2010, 2012 IBM Corporation and others.
>+ *  Copyright (c) 2010, 2014 IBM Corporation and others.
>  *  All rights reserved. This program and the accompanying materials
>  *  are made available under the terms of the Eclipse Public License v1.0
>  *  which accompanies this distribution, and is available at
>@@ -9,8 +9,6 @@
>  *     IBM Corporation - initial API and implementation
>  *******************************************************************************/
> package org.eclipse.pde.internal.ui.editor.feature;
>-
>-import org.eclipse.pde.internal.core.ifeature.IFeatureModel;
> 
> import java.util.ArrayList;
> import org.eclipse.core.runtime.CoreException;
>@@ -33,6 +31,7 @@
> import org.eclipse.swt.layout.GridData;
> import org.eclipse.swt.layout.GridLayout;
> import org.eclipse.swt.widgets.*;
>+import org.eclipse.ui.actions.ActionFactory;
> import org.eclipse.ui.forms.IFormColors;
> import org.eclipse.ui.forms.widgets.*;
> 
>@@ -330,4 +329,30 @@
> 		}
> 		super.commit(onSave);
> 	}
>+
>+	public boolean doGlobalAction(String actionId) {
>+		if (actionId.equals(ActionFactory.CUT.getId())) {
>+			fSourceViewer.doOperation(ITextOperationTarget.CUT);
>+			return true;
>+		} else if (actionId.equals(ActionFactory.COPY.getId())) {
>+			fSourceViewer.doOperation(ITextOperationTarget.COPY);
>+			return true;
>+		} else if (actionId.equals(ActionFactory.PASTE.getId())) {
>+			fSourceViewer.doOperation(ITextOperationTarget.PASTE);
>+			return true;
>+		} else if (actionId.equals(ActionFactory.DELETE.getId())) {
>+			fSourceViewer.doOperation(ITextOperationTarget.DELETE);
>+			return true;
>+		} else if (actionId.equals(ActionFactory.UNDO.getId())) {
>+			fSourceViewer.doOperation(ITextOperationTarget.UNDO);
>+			return true;
>+		} else if (actionId.equals(ActionFactory.REDO.getId())) {
>+			fSourceViewer.doOperation(ITextOperationTarget.REDO);
>+			return true;
>+		} else if (actionId.equals(ActionFactory.SELECT_ALL.getId())) {
>+			fSourceViewer.doOperation(ITextOperationTarget.SELECT_ALL);
>+		}
>+		return false;
>+	}
>+
> }
>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
>index 11e49f5..e904846 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
>@@ -1187,6 +1187,7 @@
> EditorActions_cut = Cu&t
> EditorActions_copy = &Copy
> EditorActions_paste = &Paste
>+EditorActions_selectall = Select &All
> EditorActions_revert = Re&vert
> Actions_open_label = &Open
> Actions_delete_label = &Delete

Actions: View | Diff

Attachments on bug 361123: 246955 | 247293