Attachment 246270 Details for Bug 438892 – proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed fix

assist-prefix.patch (text/plain), 1.00 KB, created by Michael Rennie

on 2014-08-22 15:43:27 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Rennie

Created: 2014-08-22 15:43:27 EDT

Size: 1.00 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.editor/web/orion/editor/contentAssist.js b/bundles/org.eclipse.orion.client.editor/web/orion/editor/contentAssist.js
>index 9672e14..6e911a8 100644
>--- a/bundles/org.eclipse.orion.client.editor/web/orion/editor/contentAssist.js
>+++ b/bundles/org.eclipse.orion.client.editor/web/orion/editor/contentAssist.js
>@@ -166,7 +166,11 @@
> 			}
> 			
> 			if (proposal.overwrite) {
>-				start = this.getPrefixStart(model, mapStart);
>+			    if(typeof proposal.prefix === 'string') {
>+			        start = mapStart-proposal.prefix.length;
>+			    } else {
>+				    start = this.getPrefixStart(model, mapStart);
>+				}
> 			}
> 
> 			var data = {
>@@ -373,7 +377,9 @@
> 							if (!proposal) {
> 								return false;
> 							}
>-							
>+							if(typeof proposal.prefix === 'string') {
>+							    prefixText = proposal.prefix;
>+							}
> 							if ((STYLES[proposal.style] === STYLES.hr)
> 								|| (STYLES[proposal.style] === STYLES.noemphasis_title)) {
> 								return true;

Actions: View | Diff

Attachments on bug 438892: 246270