Attachment 24367 Details for Bug 99155 – New patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] New patch

patch_99155.txt (text/plain), 6.47 KB, created by Chris Gross

on 2005-07-05 16:55:46 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Gross

Created: 2005-07-05 16:55:46 EDT

Size: 6.47 KB

patch

obsolete

>Index: Eclipse UI/org/eclipse/ui/IPageLayout.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/IPageLayout.java,v
>retrieving revision 1.24
>diff -u -r1.24 IPageLayout.java
>--- Eclipse UI/org/eclipse/ui/IPageLayout.java	9 Jun 2005 01:04:14 -0000	1.24
>+++ Eclipse UI/org/eclipse/ui/IPageLayout.java	5 Jul 2005 20:54:41 -0000
>@@ -351,6 +351,37 @@
>             int relationship, float ratio, String refId);
> 
>     /**
>+     * Adds a standalone view placeholder to this page layout.
>+     * A view placeholder is used to define the position of a view before the view
>+     * appears.  Initially, it is invisible; however, if the user ever opens a view
>+     * whose compound id matches the placeholder, the view will appear at the same
>+     * location as the placeholder.  
>+     * See the {@link IPageLayout} type documentation for more details about compound ids.
>+     * If the placeholder contains wildcards, it remains in the layout, otherwise 
>+     * it is replaced by the view.
>+     * If the primary id of the placeholder has no wildcards, it must refer to a view 
>+     * contributed to the workbench's view extension point 
>+     * (named <code>"org.eclipse.ui.views"</code>).
>+     *
>+     * @param viewId the compound view id (wildcards allowed)
>+     * @param relationship the position relative to the reference part;
>+     *  one of <code>TOP</code>, <code>BOTTOM</code>, <code>LEFT</code>,
>+     *  or <code>RIGHT</code>
>+     * @param ratio a ratio specifying how to divide the space currently occupied by the reference part,
>+     *    in the range <code>0.05f</code> to <code>0.95f</code>.
>+     *    Values outside this range will be clipped to facilitate direct manipulation.
>+     *    For a vertical split, the part on top gets the specified ratio of the current space
>+     *    and the part on bottom gets the rest.
>+     *    Likewise, for a horizontal split, the part at left gets the specified ratio of the current space
>+     *    and the part at right gets the rest.
>+     * @param refId the id of the reference part; either a view id, a folder id,
>+     *   or the special editor area id returned by <code>getEditorArea</code>
>+     * @param showTitle true to show the view's title, false if not
>+     */
>+    public void addStandaloneViewPlaceholder(String viewId,
>+            int relationship, float ratio, String refId,boolean showTitle);
>+    
>+    /**
>      * Returns the special identifier for the editor area in this page 
>      * layout.  The identifier for the editor area is also stored in
>      * <code>ID_EDITOR_AREA</code>.
>Index: Eclipse UI/org/eclipse/ui/internal/PageLayout.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PageLayout.java,v
>retrieving revision 1.41
>diff -u -r1.41 PageLayout.java
>--- Eclipse UI/org/eclipse/ui/internal/PageLayout.java	26 May 2005 02:47:33 -0000	1.41
>+++ Eclipse UI/org/eclipse/ui/internal/PageLayout.java	5 Jul 2005 20:54:42 -0000
>@@ -429,6 +429,42 @@
>         return new PlaceholderFolderLayout(this, folder);
>     }
> 
>+    /* (non-Javadoc)
>+     * @see org.eclipse.ui.IPageLayout#addStandaloneViewPlaceholder(java.lang.String, int, float, java.lang.String, boolean)
>+     */
>+    public void addStandaloneViewPlaceholder(String viewId,
>+            int relationship, float ratio, String refId,boolean showTitle) {
>+    	
>+    	String stackId = viewId + ".standalonefolder"; //$NON-NLS-1$
>+
>+    	//Check to see if the view is already in the layout
>+        if (!checkValidPlaceholderId(viewId)) {
>+            return;
>+        }
>+    	        
>+        // Create the folder.
>+        ContainerPlaceholder folder = new ContainerPlaceholder(null);
>+        folder.setContainer(rootLayoutContainer);
>+        int appearance = PresentationFactoryUtil.ROLE_STANDALONE;
>+        if (!showTitle)
>+        	appearance = PresentationFactoryUtil.ROLE_STANDALONE_NOTITLE;
>+        folder.setRealContainer(new ViewStack(rootLayoutContainer.page,true, appearance, null));
>+        folder.setID(stackId); 
>+        addPart(folder, stackId, relationship, ratio, refId);
>+
>+        // Create a wrapper.
>+        PlaceholderFolderLayout placeHolder =  new PlaceholderFolderLayout(this, folder);
>+        
>+        //Add the standalone view immediately
>+        placeHolder.addPlaceholder(viewId);
>+        
>+        
>+        ViewLayoutRec rec = getViewLayoutRec(viewId, true);
>+        rec.isStandalone = true;
>+        rec.showTitle = showTitle;
>+    }
>+        
>+    
>     /**
>      * Create a new <code>LayoutPart</code>.
>      * 
>@@ -823,4 +859,5 @@
> 			mapIDtoViewLayoutRec.remove(id);
> 		}
> 	}
>+
> }
>Index: Eclipse UI/org/eclipse/ui/internal/registry/PerspectiveExtensionReader.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/PerspectiveExtensionReader.java,v
>retrieving revision 1.18
>diff -u -r1.18 PerspectiveExtensionReader.java
>--- Eclipse UI/org/eclipse/ui/internal/registry/PerspectiveExtensionReader.java	6 Jun 2005 20:16:54 -0000	1.18
>+++ Eclipse UI/org/eclipse/ui/internal/registry/PerspectiveExtensionReader.java	5 Jul 2005 20:54:43 -0000
>@@ -9,6 +9,8 @@
>  *     IBM Corporation - initial API and implementation
>  *     Dan Rubel <dan_rubel@instantiations.com>
>  *     - Fix for bug 11490 - define hidden view (placeholder for view) in plugin.xml
>+ *     Chris Gross <schtoo@schtoo.com> - Fix for 99155 - allow standalone view
>+ *     		placeholders
>  *******************************************************************************/
> 
> package org.eclipse.ui.internal.registry;
>@@ -256,7 +258,14 @@
>                     pageLayout.addView(id, intRelation, ratio, relative);
>                 }
>             } else {
>-                pageLayout.addPlaceholder(id, intRelation, ratio, relative);
>+            	//Fix for 99155, CGross (schtoo@schtoo.com)
>+            	//Adding standalone placeholder for standalone views
>+            	if (VAL_TRUE.equals(standalone)) {
>+            		pageLayout.addStandaloneViewPlaceholder(id, intRelation, ratio, relative,!VAL_FALSE
>+                            .equals(showTitle));
>+            	} else {
>+            		pageLayout.addPlaceholder(id, intRelation, ratio, relative);
>+            	}
>             }
>         }
>         if (closeable != null) {

Actions: View | Diff

Attachments on bug 99155: 24360 | 24367