Attachment 243524 Details for Bug 435810 – Fix to solve the issues

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix to solve the issues

435810_fix.patch (text/plain), 3.12 KB, created by Vikas Chandra

on 2014-05-27 06:16:41 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Vikas Chandra

Created: 2014-05-27 06:16:41 EDT

Size: 3.12 KB

patch

obsolete

>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/OverviewPage.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/OverviewPage.java
>index a5b0ea1..06b200b 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/OverviewPage.java
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/OverviewPage.java
>@@ -146,6 +146,8 @@
> 				} else {
> 					content = PDEUIMessages.OverviewPage_NoPluginConverterPlugin;
> 				}
>+				FormText errorText = createClient(container, content, toolkit);
>+				errorText.setImage("error", lp.get(PDEPluginImages.DESC_ERROR_ST_OBJ, 0)); //$NON-NLS-1$
> 			} else {
> 				// Provide link to run the conversion service
> 				if (isFragment()) {
>@@ -153,9 +155,10 @@
> 				} else {
> 					content = PDEUIMessages.OverviewPage_osgi;
> 				}
>+				FormText warningText = createClient(container, content, toolkit);
>+				warningText.setImage("warning", lp.get(PDEPluginImages.DESC_WARNING_ST_OBJ, 0)); //$NON-NLS-1$
> 			}
>-			FormText warningText = createClient(container, content, toolkit);
>-			warningText.setImage("warning", lp.get(PDEPluginImages.DESC_WARNING_ST_OBJ, 0)); //$NON-NLS-1$
>+
> 		}
> 
> 		FormText text = createClient(container, isFragment() ? PDEUIMessages.OverviewPage_fContent : PDEUIMessages.OverviewPage_content, toolkit);
>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
>index bdbd12f..afaa85d 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
>@@ -1704,10 +1704,10 @@
> <li style="image" value="warning">You must <a href="action.convert">create an OSGi bundle manifest</a> to run this fragment without the compatibility software 'Eclipse 2.0 Style Plugin Support'.</li>\
> </form>
> OverviewPage_NoPluginConverterFragment = <form>\
>-<li style="image" value="warning">You must either manually create an OSGi bundle manifest or <a href="action.installPluginConverter">install the 'Eclipse 2.0 Style Plugin Support'</a> from 'The Eclipse Project Updates' software site to run this fragment.</li>\
>+<li style="image" value="error">You must either manually create an OSGi bundle manifest or <a href="action.installPluginConverter">install the 'Eclipse 2.0 Style Plugin Support'</a> from 'The Eclipse Project Updates' software site to compile or run this fragment.</li>\
> </form>
> OverviewPage_NoPluginConverterPlugin = <form>\
>-<li style="image" value="warning">You must either manually create an OSGi bundle manifest or <a href="action.installPluginConverter">install the 'Eclipse 2.0 Style Plugin Support'</a> from 'The Eclipse Project Updates' software site to run this plug-in.</li>\
>+<li style="image" value="error">You must either manually create an OSGi bundle manifest or <a href="action.installPluginConverter">install the 'Eclipse 2.0 Style Plugin Support'</a> from 'The Eclipse Project Updates' software site to compile or run this plug-in.</li>\
> </form>
> OverviewPage_error=Error
> OverviewPage_fContent=<form>\

Actions: View | Diff

Attachments on bug 435810: 243524 | 243526