Attachment 243291 Details for Bug 435284 – Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix

eclipse.platform.ui.patch (text/plain), 1.06 KB, created by Dani Megert

on 2014-05-20 09:19:21 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dani Megert

Created: 2014-05-20 09:19:21 EDT

Size: 1.06 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>diff --git Eclipse UI/org/eclipse/ui/internal/ShowInMenu.java Eclipse UI/org/eclipse/ui/internal/ShowInMenu.java
>index 4f771cd..28462ac 100644
>--- Eclipse UI/org/eclipse/ui/internal/ShowInMenu.java
>+++ Eclipse UI/org/eclipse/ui/internal/ShowInMenu.java
>@@ -37,6 +37,7 @@
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.widgets.Menu;
> import org.eclipse.swt.widgets.MenuItem;
>+import org.eclipse.swt.widgets.Shell;
> import org.eclipse.ui.IEditorPart;
> import org.eclipse.ui.ISourceProvider;
> import org.eclipse.ui.ISources;
>@@ -325,7 +326,14 @@
> 
> 		IWorkbenchPage page = window.getActivePage();
> 		if (page != null) {
>-			return page.getActivePart();
>+			IWorkbenchPart activePart = page.getActivePart();
>+			/*
>+			 * NOTE: Do not use window.getShell() to test since this won't work
>+			 * for detached views (see bug 412285)
>+			 */
>+			Shell activePartShell = activePart.getSite().getShell();
>+			if (activePartShell == activePartShell.getDisplay().getActiveShell())
>+				return activePart;
> 		}
> 		return null;
> 	}

Actions: View | Diff

Attachments on bug 435284: 243291