Attachment 241114 Details for Bug 430903 – patch for platform ui

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch for platform ui

platfrom.ui.patch (text/plain), 2.50 KB, created by Philippe Marschall

on 2014-03-21 14:07:13 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Marschall

Created: 2014-03-21 14:07:13 EDT

Size: 2.50 KB

patch

obsolete

>From d0caade05bf254a00b9deb4fc3fc5bbd50d31103 Mon Sep 17 00:00:00 2001
>From: Philippe Marschall <philippe.marschall@gmail.com>
>Date: Fri, 21 Mar 2014 19:03:16 +0100
>Subject: [PATCH] Bug 430903 - [Workbench] System summary should not be
> computed in the UI thread
>
>Change-Id: I7f315679c31a62507eecf35cd77975ff08d03b20
>Signed-off-by: Philippe Marschall <philippe.marschall@gmail.com>
>---
> .../eclipse/ui/internal/about/AboutSystemPage.java  | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
>
>diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutSystemPage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutSystemPage.java
>index 6c299b2..11dfc7e 100644
>--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutSystemPage.java	
>+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutSystemPage.java	
>@@ -15,6 +15,7 @@ import org.eclipse.core.runtime.IProgressMonitor;
> import org.eclipse.core.runtime.IStatus;
> import org.eclipse.core.runtime.Platform;
> import org.eclipse.core.runtime.Status;
>+import org.eclipse.core.runtime.jobs.Job;
> import org.eclipse.jface.dialogs.IDialogConstants;
> import org.eclipse.jface.resource.JFaceResources;
> import org.eclipse.swt.SWT;
>@@ -29,7 +30,6 @@ import org.eclipse.ui.PlatformUI;
> import org.eclipse.ui.internal.ConfigurationInfo;
> import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
> import org.eclipse.ui.internal.WorkbenchMessages;
>-import org.eclipse.ui.progress.WorkbenchJob;
> 
> /**
>  * Displays system information about the eclipse application. The content of
>@@ -148,12 +148,21 @@ public final class AboutSystemPage extends ProductInfoPage {
> 
> 	private void fetchConfigurationInfo(final Text text) {
> 		text.setText(WorkbenchMessages.AboutSystemPage_RetrievingSystemInfo);
>-		WorkbenchJob job = new WorkbenchJob(
>+		Job job = new Job(
> 				WorkbenchMessages.AboutSystemPage_FetchJobTitle) {
>-			public IStatus runInUIThread(IProgressMonitor monitor) {
>-				String info = ConfigurationInfo.getSystemSummary();
>-				if (!text.isDisposed())
>-					text.setText(info);
>+			public IStatus run(IProgressMonitor monitor) {
>+				final String info = ConfigurationInfo.getSystemSummary();
>+				if (!text.isDisposed()) {
>+					text.getDisplay().asyncExec(new Runnable() {
>+
>+						@Override
>+						public void run() {
>+							if (!text.isDisposed())
>+								text.setText(info);
>+
>+						}
>+					});
>+				}
> 				return Status.OK_STATUS;
> 			}
> 		};
>-- 
>1.8.4.1
>

Actions: View | Diff

Attachments on bug 430903: 241114