Attachment 239379 Details for Bug 420735 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

420735_multipleToggleRelevance.patch (text/plain), 3.03 KB, created by Maissmaallsmyss Maulhs-Vvuillss

on 2014-01-28 05:12:36 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Maissmaallsmyss Maulhs-Vvuillss

Created: 2014-01-28 05:12:36 EST

Size: 3.03 KB

patch

obsolete

>diff --git a/org.eclipse.jubula.client.ui.rcp/plugin.xml b/org.eclipse.jubula.client.ui.rcp/plugin.xml
>index 41f33bf..cc597c5 100644
>--- a/org.eclipse.jubula.client.ui.rcp/plugin.xml
>+++ b/org.eclipse.jubula.client.ui.rcp/plugin.xml
>@@ -2699,12 +2699,9 @@
>       class="org.eclipse.jubula.client.ui.rcp.handlers.ToggleRelevanceHandler"
>       commandId="org.eclipse.jubula.client.ui.commands.ToggleRelevance">
>       <activeWhen>
>-        <and>
>-          <count value="1" />
>           <with variable="activePartId">
>             <equals value="org.eclipse.jubula.client.ui.views.TestresultSummaryView" />
>           </with>
>-        </and>
>       </activeWhen>
>     </handler>
>     <handler
>diff --git a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/handlers/ToggleRelevanceHandler.java b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/handlers/ToggleRelevanceHandler.java
>index f86dee2..d79ff9a 100644
>--- a/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/handlers/ToggleRelevanceHandler.java
>+++ b/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/handlers/ToggleRelevanceHandler.java
>@@ -10,21 +10,39 @@
>  *******************************************************************************/
> package org.eclipse.jubula.client.ui.rcp.handlers;
> 
>+import java.util.Iterator;
>+
> import org.eclipse.core.commands.ExecutionEvent;
>+import org.eclipse.jface.viewers.ISelection;
>+import org.eclipse.jface.viewers.IStructuredSelection;
> import org.eclipse.jubula.client.core.businessprocess.TestresultSummaryBP;
> import org.eclipse.jubula.client.core.model.ITestResultSummaryPO;
> import org.eclipse.jubula.client.ui.handlers.AbstractTestResultViewHandler;
>+import org.eclipse.ui.handlers.HandlerUtil;
> 
> /**
>  * @author BREDEX GmbH
>- * @created Mar 3, 2011
>+ * @created January 28, 20114
>  */
> public class ToggleRelevanceHandler extends AbstractTestResultViewHandler {
>     /** {@inheritDoc} */
>     public Object executeImpl(ExecutionEvent event) {
>-        ITestResultSummaryPO selectedSummary = getSelectedSummary(event);
>-        TestresultSummaryBP.getInstance().setRelevance(selectedSummary,
>-            !selectedSummary.isTestsuiteRelevant());
>+        ISelection selection = HandlerUtil.getCurrentSelection(event);
>+        if (selection instanceof IStructuredSelection) {
>+            IStructuredSelection structuredSelection =
>+                (IStructuredSelection)selection;
>+            for (Iterator iterator = structuredSelection.iterator(); iterator
>+                    .hasNext();) {
>+                Object selectedObject = iterator.next();
>+                if (selectedObject instanceof ITestResultSummaryPO) {
>+                    ITestResultSummaryPO selectedSummary =
>+                            (ITestResultSummaryPO)selectedObject;
>+                    TestresultSummaryBP.getInstance().setRelevance(
>+                            selectedSummary,
>+                            !selectedSummary.isTestsuiteRelevant());
>+                }
>+            }
>+        }
>         return null;
>     }
> }

Flags:

sebastian.jubula: iplog+

Actions: View | Diff

Attachments on bug 420735: 239379