Attachment 239030 Details for Bug 425695 – fix if just calling init() is valid

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix if just calling init() is valid

registry.patch (text/plain), 1.79 KB, created by Silenio Quarti

on 2014-01-15 13:19:10 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Silenio Quarti

Created: 2014-01-15 13:19:10 EST

Size: 1.79 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.core/web/orion/pluginregistry.js b/bundles/org.eclipse.orion.client.core/web/orion/pluginregistry.js
>index 0fec1a8..aeed129 100644
>--- a/bundles/org.eclipse.orion.client.core/web/orion/pluginregistry.js
>+++ b/bundles/org.eclipse.orion.client.core/web/orion/pluginregistry.js
>@@ -1103,6 +1103,17 @@
>             _plugins.sort(function(a, b) {
>                 return a._getCreated() < b._getCreated() ? -1 : 1;
>             });
>+            
>+            if (configuration.parent) {
>+            	_parent = configuration.parent;
>+            } else {
>+	            _parent = document.createElement("div"); //$NON-NLS-0$
>+	            if (!configuration.visible) {
>+                    _parent.style.display = "none"; //$NON-NLS-0$
>+                    _parent.style.visibility = "hidden"; //$NON-NLS-0$
>+                }
>+	            document.body.appendChild(_parent);
>+            }
> 
>             if (configuration.plugins) {
>                 Object.keys(configuration.plugins).forEach(function(url) {
>@@ -1136,18 +1147,6 @@
>             if (_state !== "starting") {
>                 return new Deferred().reject("Cannot start framework. Framework is already " + _state + ".");
>             }
>-            
>-            if (configuration.parent) {
>-            	_parent = configuration.parent;
>-            } else {
>-	            _parent = document.createElement("div"); //$NON-NLS-0$
>-	            if (!configuration.visible) {
>-                    _parent.style.display = "none"; //$NON-NLS-0$
>-                    _parent.style.visibility = "hidden"; //$NON-NLS-0$
>-                }
>-	            document.body.appendChild(_parent);
>-            }
>-
>             var deferreds = [];
>             var now = new Date().getTime();
>             _plugins.forEach(function(plugin) {

Actions: View | Diff

Attachments on bug 425695: 239030