Attachment 238392 Details for Bug 424172 – Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch

Fixed-bug-424172-1.8-organize-imports-Unused-static-import.patch (text/plain), 2.10 KB, created by Noopur Gupta

on 2013-12-17 03:59:17 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Noopur Gupta

Created: 2013-12-17 03:59:17 EST

Size: 2.10 KB

patch

obsolete

>diff --git a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/codemanipulation/ImportReferencesCollector.java b/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/codemanipulation/ImportReferencesCollector.java
>index f2e78fc..49f80ca 100644
>--- a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/codemanipulation/ImportReferencesCollector.java
>+++ b/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/codemanipulation/ImportReferencesCollector.java
>@@ -24,6 +24,7 @@
> import org.eclipse.jdt.core.dom.ClassInstanceCreation;
> import org.eclipse.jdt.core.dom.CompilationUnit;
> import org.eclipse.jdt.core.dom.Expression;
>+import org.eclipse.jdt.core.dom.ExpressionMethodReference;
> import org.eclipse.jdt.core.dom.FieldAccess;
> import org.eclipse.jdt.core.dom.IBinding;
> import org.eclipse.jdt.core.dom.IMethodBinding;
>@@ -46,10 +47,13 @@
> import org.eclipse.jdt.core.dom.SimpleName;
> import org.eclipse.jdt.core.dom.SimpleType;
> import org.eclipse.jdt.core.dom.SingleMemberAnnotation;
>+import org.eclipse.jdt.core.dom.StructuralPropertyDescriptor;
> import org.eclipse.jdt.core.dom.SuperConstructorInvocation;
>+import org.eclipse.jdt.core.dom.SuperMethodReference;
> import org.eclipse.jdt.core.dom.TagElement;
> import org.eclipse.jdt.core.dom.ThisExpression;
> import org.eclipse.jdt.core.dom.TypeDeclaration;
>+import org.eclipse.jdt.core.dom.TypeMethodReference;
> 
> import org.eclipse.jdt.internal.corext.dom.GenericVisitor;
> import org.eclipse.jdt.internal.corext.dom.ScopeAnalyzer;
>@@ -162,6 +166,12 @@
> 				}
> 			}
> 		} else if (binding instanceof IMethodBinding) {
>+			StructuralPropertyDescriptor locationInParent= simpleName.getLocationInParent();
>+			if (locationInParent == ExpressionMethodReference.NAME_PROPERTY
>+					|| locationInParent == TypeMethodReference.NAME_PROPERTY
>+					|| locationInParent == SuperMethodReference.NAME_PROPERTY) {
>+				return;
>+			}
> 			IMethodBinding methodBinding= ((IMethodBinding) binding).getMethodDeclaration();
> 			ITypeBinding declaringClass= methodBinding.getDeclaringClass();
> 			if (declaringClass != null && !declaringClass.isLocal()) {

Actions: View | Diff

Attachments on bug 424172: 238392 | 238395 | 238849