Attachment 237921 Details for Bug 422974 – patch for 2.2

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch for 2.2

Make-MULTI-text-fields-always-mousefocusable-in-IE9.patch (text/plain), 1.77 KB, created by Tim Buschtoens

on 2013-12-02 11:32:51 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2013-12-02 11:32:51 EST

Size: 1.77 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>diff --git js/rwt/widgets/Text.js js/rwt/widgets/Text.js
>index cba4aef..bd92505 100644
>--- js/rwt/widgets/Text.js
>+++ js/rwt/widgets/Text.js
>@@ -188,6 +188,10 @@
>       this.base( arguments, value, oldValue );
>       if( this._inputTag == "textarea" ) {
>         this._styleWrap();
>+        if( rwt.client.Client.isNewMshtml() && rwt.client.Client.getVersion() === 9 ) {
>+          // Bug 422974 - [Text] Multi-Line Text with border-radius not focusable by mouse in IE9
>+          rwt.html.Style.setBackgroundImage( this._inputElement, "static/image/blank.gif" );
>+        }
>       }
>       // Fix for bug 306354
>       this._inputElement.style.paddingRight = "1px";
>#P org.eclipse.rap.rwt.jstest
>diff --git js/org/eclipse/rwt/test/tests/TextTest.js js/org/eclipse/rwt/test/tests/TextTest.js
>index f7dfc40..b1593dd 100644
>--- js/org/eclipse/rwt/test/tests/TextTest.js
>+++ js/org/eclipse/rwt/test/tests/TextTest.js
>@@ -1427,6 +1427,24 @@
>       TestUtil.restoreAppearance();
>     },
> 
>+    testSetTextAreaBackgroundImage : function() {
>+      createText( false, true );
>+
>+      var element = text._getTargetNode().firstChild;
>+      var image = TestUtil.getCssBackgroundImage( element );
>+      // Bug 422974 - [Text] Multi-Line Text with border-radius not focusable by mouse in IE9
>+      var expected = rwt.client.Client.isNewMshtml() && rwt.client.Client.getVersion() === 9;
>+      assertEquals( expected, image.indexOf( "blank.gif" ) !== -1 );
>+    },
>+
>+    testSetInputBackgroundImage : function() {
>+      createText( false, false );
>+
>+      var element = text._getTargetNode().firstChild;
>+      var image = TestUtil.getCssBackgroundImage( element );
>+      assertTrue( image.indexOf( "blank.gif" ) === -1 );
>+    },
>+
>     /////////
>     // Helper
>

Flags:

tbuschto: review?
rsternberg: review+

Actions: View | Diff

Attachments on bug 422974: 237921