Attachment 237747 Details for Bug 422645 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Redraw-all-grid-rows-on-horizontal-grid-resize.patch (text/plain), 1.41 KB, created by Tim Buschtoens

on 2013-11-27 04:59:12 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2013-11-27 04:59:12 EST

Size: 1.41 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>diff --git js/rwt/widgets/Grid.js js/rwt/widgets/Grid.js
>index 379908c..03fa78a 100644
>--- js/rwt/widgets/Grid.js
>+++ js/rwt/widgets/Grid.js
>@@ -1354,6 +1354,7 @@
>       this._horzScrollBar.setWidth( width );
>       this._rowContainer.setWidth( width );
>       this._updateScrollWidth();
>+      this._scheduleUpdate();
>     },
> 
>     _layoutY : function() {
>#P org.eclipse.rap.rwt.jstest
>diff --git js/org/eclipse/rwt/test/tests/GridTest.js js/org/eclipse/rwt/test/tests/GridTest.js
>index 4645eda..34a721a 100644
>--- js/org/eclipse/rwt/test/tests/GridTest.js
>+++ js/org/eclipse/rwt/test/tests/GridTest.js
>@@ -784,6 +784,26 @@
>       tree.destroy();
>     },
> 
>+    testRenderItemsOnResizeWidth : function() {
>+      var tree = new rwt.widgets.Grid( { "appearance": "tree" } );
>+      this._fakeAppearance();
>+      tree.addToDocument();
>+      tree.setWidth( 300 );
>+      tree.setHeight( 300 );
>+      TestUtil.flush();
>+      var log = [];
>+      var row = tree.getRowContainer().getChildren()[ 0 ];
>+      row.addEventListener( "itemRendered", function( event ) {
>+        log.push( event );
>+      } );
>+
>+      tree.setWidth( 700 );
>+      TestUtil.flush();
>+
>+      assertEquals( 1, log.length );
>+      tree.destroy();
>+    },
>+
>     testSimpleInternalLayoutWithBorder : function() {
>       var tree = new rwt.widgets.Grid( { "appearance": "tree" } );
>       this._fakeAppearance();

Flags:

ivan: review+
rsternberg: review+

Actions: View | Diff

Attachments on bug 422645: 237747