Attachment 236897 Details for Bug 418750 – fix for first problem

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

fix for first problem

file_418750.txt (text/plain), 2.25 KB, created by Silenio Quarti

on 2013-10-25 09:17:03 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Silenio Quarti

Created: 2013-10-25 09:17:03 EDT

Size: 2.25 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/webui/tooltip.js b/bundles/org.eclipse.orion.client.ui/web/orion/webui/tooltip.js
>index 4ab049a..82262ef 100644
>--- a/bundles/org.eclipse.orion.client.ui/web/orion/webui/tooltip.js
>+++ b/bundles/org.eclipse.orion.client.ui/web/orion/webui/tooltip.js
>@@ -58,7 +58,7 @@
> 			// set up events
> 			if (this._trigger === "click") { //$NON-NLS-0$
> 				this._showDelay = 0;
>-				this._node.addEventListener("click", function(event) { //$NON-NLS-0$
>+				this._node.addEventListener("click", this._clickHandler = function(event) { //$NON-NLS-0$
> 					if (event.target === self._node) {
> 						self.show();
> 						lib.stop(event);
>@@ -67,19 +67,19 @@
> 			} else if (this._trigger === "mouseover") { //$NON-NLS-0$
> 				this._showDelay = options.showDelay === undefined ? 500 : options.showDelay;
> 				var leave = ["mouseout", "click"];  //$NON-NLS-1$ //$NON-NLS-0$
>-				this._node.addEventListener("mouseover", function(event) { //$NON-NLS-0$
>+				this._node.addEventListener("mouseover", this._mouseoverHandler = function(event) { //$NON-NLS-0$
> 					if (lib.contains(self._node, event.target)) {
> 						self.show();
> 						lib.stop(event);
> 					}
> 				}, false);
>-				
>+				this._leaveHandler = function(event) { //$NON-NLS-0$
>+					if (lib.contains(self._node, event.target)) {
>+						self.hide();
>+					}
>+				};
> 				for (var i=0; i<leave.length; i++) {
>-					this._node.addEventListener(leave[i], function(event) { //$NON-NLS-0$
>-						if (lib.contains(self._node, event.target)) {
>-							self.hide();
>-						}
>-					}, false);
>+					this._node.addEventListener(leave[i], this._leaveHandler, false);
> 				}
> 			}						
> 		},
>@@ -282,6 +282,15 @@
> 				this._tipTextContent = null;
> 				this._tail = null;
> 			}
>+			if (this._node) {
>+				this._node.removeEventListener("click", this._clickHandler, false); //$NON-NLS-0$
>+				this._node.removeEventListener("mouseover", this._mouseoverHandler, false); //$NON-NLS-0$
>+				var leave = ["mouseout", "click"];  //$NON-NLS-1$ //$NON-NLS-0$
>+				for (var i=0; i<leave.length; i++) {
>+					this._node.removeEventListener(leave[i], this._leaveHandler, false);
>+				}
>+				this._node = null;
>+			}
> 		}
> 	};
> 	Tooltip.prototype.constructor = Tooltip;

Actions: View

Attachments on bug 418750: 236145 | 236897 | 236898