Attachment 236706 Details for Bug 351713 – Patch that fixes the NPE in Change Function Signature dialog

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch that fixes the NPE in Change Function Signature dialog

bug351713.patch (text/plain), 1.80 KB, created by Victor Rubezhny

on 2013-10-21 09:18:55 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Rubezhny

Created: 2013-10-21 09:18:55 EDT

Size: 1.80 KB

patch

obsolete

>From 89e9ceb974bff447d768e21ffb9eadae7812c79a Mon Sep 17 00:00:00 2001
>From: vrubezhny <vrubezhny@exadel.com>
>Date: Mon, 21 Oct 2013 17:03:04 +0400
>Subject: [PATCH] Bug 351713 - [refactoring] Change Function Signature broken.
> Cannot use at all.
>
>NPE is fixed
>---
> .../corext/refactoring/structure/ChangeSignatureRefactoring.java      | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/bundles/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/corext/refactoring/structure/ChangeSignatureRefactoring.java b/bundles/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/corext/refactoring/structure/ChangeSignatureRefactoring.java
>index c63089d..c556ba4 100644
>--- a/bundles/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/corext/refactoring/structure/ChangeSignatureRefactoring.java
>+++ b/bundles/org.eclipse.wst.jsdt.ui/src/org/eclipse/wst/jsdt/internal/corext/refactoring/structure/ChangeSignatureRefactoring.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 IBM Corporation and others.
>+ * Copyright (c) 2000, 2013 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -485,7 +485,7 @@ public class ChangeSignatureRefactoring extends ScriptableRefactoring implements
> 			result.addFatalError(msg);
> 			return;
> 		}
>-		if (fMethodName.equals(fMethod.getDeclaringType().getElementName())) {
>+		if (fMethod.getDeclaringType() != null && fMethodName.equals(fMethod.getDeclaringType().getElementName())) {
> 			String msg= RefactoringCoreMessages.ChangeSignatureRefactoring_constructor_name; 
> 			result.addWarning(msg);
> 		}
>-- 
>1.8.3.1
>

Actions: View | Diff

Attachments on bug 351713: 236706