Attachment 236506 Details for Bug 417729 – proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed fix

git-config-values.patch (text/plain), 1.03 KB, created by Michael Rennie

on 2013-10-15 16:34:49 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Rennie

Created: 2013-10-15 16:34:49 EDT

Size: 1.03 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.git/web/orion/git/gitCommands.js b/bundles/org.eclipse.orion.client.git/web/orion/git/gitCommands.js
>index 6340536..c52510e 100644
>--- a/bundles/org.eclipse.orion.client.git/web/orion/git/gitCommands.js
>+++ b/bundles/org.eclipse.orion.client.git/web/orion/git/gitCommands.js
>@@ -2047,7 +2047,14 @@
> 		});
> 		commandService.addCommand(addConfigEntryCommand);
> 		
>-		var editConfigParameters = new mCommandRegistry.ParametersDescription([new mCommandRegistry.CommandParameter('value', 'text', messages['Value:'])]); //$NON-NLS-1$ //$NON-NLS-0$
>+		var editConfigParameters = new mCommandRegistry.ParametersDescription([], null, function(commandInvocation) {
>+			var items = commandInvocation.items;
>+			var val;
>+			if(items) {
>+				val = items.Value;
>+			}
>+			return [new mCommandRegistry.CommandParameter('value', 'text', messages['Value:'], val)]; //$NON-NLS-2$ //$NON-NLS-1$ //$NON-NLS-0$
>+		});
> 		
> 		var editConfigEntryCommand = new mCommands.Command({
> 			name: messages["Edit"],

Actions: View | Diff

Attachments on bug 417729: 236506