Attachment 236412 Details for Bug 419170 – second patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

second patch

patch419170_2.txt (text/plain), 1.36 KB, created by libing wang

on 2013-10-11 14:17:53 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: libing wang

Created: 2013-10-11 14:17:53 EDT

Size: 1.36 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/explorers/explorerNavHandler.js b/bundles/org.eclipse.orion.client.ui/web/orion/explorers/explorerNavHandler.js
>index b676693..5c82efd 100644
>--- a/bundles/org.eclipse.orion.client.ui/web/orion/explorers/explorerNavHandler.js
>+++ b/bundles/org.eclipse.orion.client.ui/web/orion/explorers/explorerNavHandler.js
>@@ -187,6 +187,13 @@
> 					}
> 					if(that._selections.length > 0){
> 						that.cursorOn(that._selections[0], true, false, noScroll);
>+					} else {//If there is no selection, we should just the first item as the cursored items.  
>+						that.cursorOn();
>+					}
>+					//If shift selection anchor exists and in the refreshed selection range, we just keep it otherwise clear the anchor
>+					//See https://bugs.eclipse.org/bugs/show_bug.cgi?id=419170
>+					if(!(that._shiftSelectionAnchor && that._inSelection(that._shiftSelectionAnchor) >= 0)){
>+						that._shiftSelectionAnchor = null;
> 					}
> 				});
> 			}
>@@ -204,6 +211,8 @@
> 			}
> 			this._modelIterator.setTree(this.topIterationNodes);
> 			if(!noReset && this.explorer.selection){
>+				//refresh the current cursor visual, otherwise the next cursorOn() call will not remove the previoous cursor visual properly.
>+				this.toggleCursor(this._modelIterator.cursor(), false);
> 				this._modelIterator.reset();
> 			}
> 			this.refreshSelection(true);

Actions: View

Attachments on bug 419170: 236379 | 236412