Attachment 236350 Details for Bug 410842 – proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

proposed patch

patch410842.txt (text/plain), 1.75 KB, created by Grant Gayed

on 2013-10-10 15:01:04 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Grant Gayed

Created: 2013-10-10 15:01:04 EDT

Size: 1.75 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/commands.js b/bundles/org.eclipse.orion.client.ui/web/orion/commands.js
>index 5a71352..3a0f9e3 100644
>--- a/bundles/org.eclipse.orion.client.ui/web/orion/commands.js
>+++ b/bundles/org.eclipse.orion.client.ui/web/orion/commands.js
>@@ -359,6 +359,11 @@
> 			} else {  // no href
> 				element.href = "#"; //$NON-NLS-0$
> 			}
>+			element.addEventListener("keydown", function(e) { //$NON-NLS-0$
>+				if (e.keyCode === lib.KEY.ENTER || e.keyCode === lib.KEY.SPACE) {
>+					element.click();
>+				}
>+			}, false);
> 		} else {
> 			element = document.createElement("span"); //$NON-NLS-0$
> 			element.tabIndex = 0;
>@@ -370,6 +375,12 @@
> 					dropdown.close(true);
> 					onClick.call(commandInvocation.handler, commandInvocation);
> 				}, false);
>+				element.addEventListener("keydown", function(e) { //$NON-NLS-0$
>+					if (e.keyCode === lib.KEY.ENTER || e.keyCode === lib.KEY.SPACE) {
>+						e.preventDefault(); /* prevents dropdown from receiving event and re-opening */
>+						element.click();
>+					}
>+				}, false);
> 			}
> 		}
> 		if (command.tooltip) {
>diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/widgets/UserMenu.js b/bundles/org.eclipse.orion.client.ui/web/orion/widgets/UserMenu.js
>index 9aa15a3..2cd853d 100644
>--- a/bundles/org.eclipse.orion.client.ui/web/orion/widgets/UserMenu.js
>+++ b/bundles/org.eclipse.orion.client.ui/web/orion/widgets/UserMenu.js
>@@ -146,6 +146,11 @@
> 					link.textContent = item.textContent;
> 					li.appendChild(link);
> 					category.appendChild(li);
>+					link.addEventListener("keydown", function(e) { //$NON-NLS-0$
>+						if (e.keyCode === lib.KEY.ENTER || e.keyCode === lib.KEY.SPACE) {	
>+							link.click();
>+						}
>+					}, false);
> 				}.bind(this));
> 
> 				if(this.keyAssistFunction){

Actions: View

Attachments on bug 410842: 236350